issue_comments

Table actions

9 rows where issue = 763361458 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • "Stream all rows" is not at all obvious · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
745162571 https://github.com/simonw/datasette/issues/1142#issuecomment-745162571 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NTE2MjU3MQ== nitinpaultifr 6622733 2020-12-15T09:22:58Z 2020-12-15T09:22:58Z NONE

You're right, probably more straightforward to have the links for JSON. I was imagining to toggle the href for the 'Export JSON' link (button) to the selected shape, but it'll probably be needlessly complex in the end.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
744576894 https://github.com/simonw/datasette/issues/1142#issuecomment-744576894 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NDU3Njg5NA== simonw 9599 2020-12-14T17:03:13Z 2020-12-14T17:03:13Z OWNER

I'm not sure about the radio boxes for JSON, just because you can't right-click on a radio box and copy it to your clipboard like you can with links. Worth trying it out though.

The radio boxes for that CSV option are definitely the right way to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
744563209 https://github.com/simonw/datasette/issues/1142#issuecomment-744563209 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NDU2MzIwOQ== simonw 9599 2020-12-14T16:41:11Z 2020-12-14T16:41:11Z OWNER

To check out and start the server:

/tmp % git clone git@github.com:nitinpaul/datasette
Cloning into 'datasette'...
remote: Enumerating objects: 124, done.
# ...
datasette % python3 -m venv venv
datasette % source venv/bin/activate
(venv) datasette % pip install -e '.[test]'
Obtaining file:///private/tmp/datasette
Collecting asgiref<3.4.0,>=3.2.10
Using cached asgiref-3.3.1-py3-none-any.whl (19 kB)
# ...
(venv) datasette % datasette
INFO:     Started server process [24002]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://127.0.0.1:8001 (Press CTRL+C to quit)

And to run the tests:

(venv) datasette % pytest
======================================================================== test session starts ========================================================================
platform darwin -- Python 3.9.1, pytest-6.1.2, py-1.10.0, pluggy-0.13.1
SQLite: 3.34.0
rootdir: /private/tmp/datasette, configfile: pytest.ini
plugins: asyncio-0.14.0, timeout-1.4.2
collected 841 items

tests/test_package.py ..                                                                                                                                      [  0%]

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
744522099 https://github.com/simonw/datasette/issues/1142#issuecomment-744522099 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NDUyMjA5OQ== nitinpaultifr 6622733 2020-12-14T15:37:47Z 2020-12-14T15:37:47Z NONE

Alright I could give it a try! This might be a stupid question, can you tell me how to run the server from my fork? So that I can test the changes?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
744251252 https://github.com/simonw/datasette/issues/1142#issuecomment-744251252 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NDI1MTI1Mg== simonw 9599 2020-12-14T07:56:38Z 2020-12-14T07:56:38Z OWNER

That's a really solid design for this! I'd be very happy to review a pull request - you should be able to implement this with just template edits and some CSS changes I think.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
743998792 https://github.com/simonw/datasette/issues/1142#issuecomment-743998792 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0Mzk5ODc5Mg== nitinpaultifr 6622733 2020-12-13T12:14:06Z 2020-12-13T12:14:06Z NONE

Agreed, it would definitely provide better controls. However, I do feel it makes for a bit of inconsistent UX for the 'Advanced export' section, with links to download for JSON, checkboxes and radio buttons + button to download for CSV. Do you think this example makes the UX a bit nicer/consistent?

I could give it a try if you'd like but I've never contributed to an actual project!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
743913004 https://github.com/simonw/datasette/issues/1142#issuecomment-743913004 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0MzkxMzAwNA== simonw 9599 2020-12-12T22:17:46Z 2020-12-12T22:17:46Z OWNER

You're actually choosing between two options here: the 100 rows you can see on the screen, or the x,000 rows that match the current query.

Maybe a radio box would be more obvious?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
743912875 https://github.com/simonw/datasette/issues/1142#issuecomment-743912875 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0MzkxMjg3NQ== simonw 9599 2020-12-12T22:16:38Z 2020-12-12T22:16:38Z OWNER

Yeah, maybe with the number of rows to make it completely clear. Include all 2,455 rows perhaps.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
743732440 https://github.com/simonw/datasette/issues/1142#issuecomment-743732440 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0MzczMjQ0MA== nitinpaultifr 6622733 2020-12-12T09:56:40Z 2020-12-12T09:56:40Z NONE

'Include all rows' seem like a fairly obvious alternative

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);