issue_comments

Table actions

4 rows where issue = 773913793 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

author_association 3

issue 1

  • Modernize code to Python 3.6+ · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
750390741 https://github.com/simonw/datasette/pull/1158#issuecomment-750390741 https://api.github.com/repos/simonw/datasette/issues/1158 MDEyOklzc3VlQ29tbWVudDc1MDM5MDc0MQ== simonw 9599 2020-12-23T17:05:32Z 2020-12-23T17:05:32Z OWNER

Thanks for this!

I'm fine keeping the os.path stuff as is.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Modernize code to Python 3.6+ 773913793  
750389683 https://github.com/simonw/datasette/pull/1158#issuecomment-750389683 https://api.github.com/repos/simonw/datasette/issues/1158 MDEyOklzc3VlQ29tbWVudDc1MDM4OTY4Mw== eumiro 6774676 2020-12-23T17:02:50Z 2020-12-23T17:02:50Z CONTRIBUTOR

The dict/set suggestion comes from pyupgrade --py36-plus, but then had to black the change.

The rest comes from PyCharm's Inspect code function. I reviewed all the suggestions and fixed a thing or two, such as leading/trailing spaces in the docstrings or turned around the chained conditions.

Then I tried to convert all os.path/glob/open to Path, but there were some local test issues, so I'll have to start over in smaller chunks if you want to have that too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Modernize code to Python 3.6+ 773913793  
750373603 https://github.com/simonw/datasette/pull/1158#issuecomment-750373603 https://api.github.com/repos/simonw/datasette/issues/1158 MDEyOklzc3VlQ29tbWVudDc1MDM3MzYwMw== simonw 9599 2020-12-23T16:26:21Z 2020-12-23T16:26:21Z OWNER

Did you use a tool to find these or are they all from manual code inspection?

They look good - I particularly like the set/dict literals.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Modernize code to Python 3.6+ 773913793  
750373496 https://github.com/simonw/datasette/pull/1158#issuecomment-750373496 https://api.github.com/repos/simonw/datasette/issues/1158 MDEyOklzc3VlQ29tbWVudDc1MDM3MzQ5Ng== codecov[bot] 22429695 2020-12-23T16:26:06Z 2020-12-23T16:26:06Z NONE

Codecov Report

Merging #1158 (37ce72f) into main (90eba4c) will not change coverage. The diff coverage is 87.50%.

```diff @@ Coverage Diff @@

main #1158 +/-

======================================= Coverage 91.55% 91.55%
======================================= Files 32 32
Lines 3930 3930
======================================= Hits 3598 3598
Misses 332 332
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/cli.py | 77.41% <ø> (ø) | | | datasette/facets.py | 89.04% <ø> (ø) | | | datasette/filters.py | 94.35% <ø> (ø) | | | datasette/hookspecs.py | 100.00% <ø> (ø) | | | datasette/inspect.py | 36.11% <ø> (ø) | | | datasette/renderer.py | 94.02% <ø> (ø) | | | datasette/views/base.py | 95.01% <50.00%> (ø) | | | datasette/app.py | 95.85% <100.00%> (ø) | | | datasette/utils/__init__.py | 94.11% <100.00%> (ø) | | | datasette/utils/asgi.py | 92.13% <100.00%> (ø) | | | ... and 1 more | |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 90eba4c...37ce72f. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Modernize code to Python 3.6+ 773913793  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);