issue_comments

Table actions

3 rows where issue = 799663959 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • gzip support for HTML (and JSON) responses · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
771968675 https://github.com/simonw/datasette/issues/1213#issuecomment-771968675 https://api.github.com/repos/simonw/datasette/issues/1213 MDEyOklzc3VlQ29tbWVudDc3MTk2ODY3NQ== simonw 9599 2021-02-02T20:41:55Z 2021-02-02T20:41:55Z OWNER

So maybe I could a special response header which ASGI middleware can pick up that means "Don't attempt to gzip this, just stream it through".

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 gzip support for HTML (and JSON) responses 799663959  
771968177 https://github.com/simonw/datasette/issues/1213#issuecomment-771968177 https://api.github.com/repos/simonw/datasette/issues/1213 MDEyOklzc3VlQ29tbWVudDc3MTk2ODE3Nw== simonw 9599 2021-02-02T20:41:13Z 2021-02-02T20:41:13Z OWNER

Starlette accumulates the full response body in a body variable and then does this: ```python elif message_type == "http.response.body": # Remaining body in streaming GZip response. body = message.get("body", b"") more_body = message.get("more_body", False)

        self.gzip_file.write(body)
        if not more_body:
            self.gzip_file.close()

        message["body"] = self.gzip_buffer.getvalue()
        self.gzip_buffer.seek(0)
        self.gzip_buffer.truncate()

        await self.send(message)

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 gzip support for HTML (and JSON) responses 799663959  
771965281 https://github.com/simonw/datasette/issues/1213#issuecomment-771965281 https://api.github.com/repos/simonw/datasette/issues/1213 MDEyOklzc3VlQ29tbWVudDc3MTk2NTI4MQ== simonw 9599 2021-02-02T20:37:08Z 2021-02-02T20:39:24Z OWNER

Starlette's gzip middleware implementation is here: https://github.com/encode/starlette/blob/0.14.2/starlette/middleware/gzip.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 gzip support for HTML (and JSON) responses 799663959  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);