issue_comments

Table actions

8 rows where issue = 811407131 and "updated_at" is on date 2021-02-18 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • --crossdb option for joining across databases · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
781599929 https://github.com/simonw/datasette/pull/1232#issuecomment-781599929 https://api.github.com/repos/simonw/datasette/issues/1232 MDEyOklzc3VlQ29tbWVudDc4MTU5OTkyOQ== codecov[bot] 22429695 2021-02-18T19:59:54Z 2021-02-18T22:06:42Z NONE

Codecov Report

Merging #1232 (8876499) into main (4df548e) will increase coverage by 0.03%. The diff coverage is 100.00%.

```diff @@ Coverage Diff @@

main #1232 +/-

========================================== + Coverage 91.42% 91.46% +0.03%
========================================== Files 32 32
Lines 3955 3970 +15
========================================== + Hits 3616 3631 +15
Misses 339 339
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/app.py | 95.68% <100.00%> (+0.06%) | :arrow_up: | | datasette/cli.py | 76.62% <100.00%> (+0.36%) | :arrow_up: | | datasette/views/database.py | 97.19% <100.00%> (+0.01%) | :arrow_up: |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4df548e...8876499. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 --crossdb option for joining across databases 811407131  
781651283 https://github.com/simonw/datasette/pull/1232#issuecomment-781651283 https://api.github.com/repos/simonw/datasette/issues/1232 MDEyOklzc3VlQ29tbWVudDc4MTY1MTI4Mw== simonw 9599 2021-02-18T21:37:55Z 2021-02-18T21:37:55Z OWNER

UI listing the attached tables:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 --crossdb option for joining across databases 811407131  
781641728 https://github.com/simonw/datasette/pull/1232#issuecomment-781641728 https://api.github.com/repos/simonw/datasette/issues/1232 MDEyOklzc3VlQ29tbWVudDc4MTY0MTcyOA== simonw 9599 2021-02-18T21:19:34Z 2021-02-18T21:19:34Z OWNER

I tested the demo deployment like this: datasette publish cloudrun fixtures.db extra_database.db \ -m fixtures.json \ --plugins-dir=plugins \ --branch=crossdb \ --extra-options="--setting template_debug 1 --crossdb" \ --install=pysqlite3-binary \ --service=datasette-latest-crossdb

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 --crossdb option for joining across databases 811407131  
781637292 https://github.com/simonw/datasette/pull/1232#issuecomment-781637292 https://api.github.com/repos/simonw/datasette/issues/1232 MDEyOklzc3VlQ29tbWVudDc4MTYzNzI5Mg== simonw 9599 2021-02-18T21:11:31Z 2021-02-18T21:11:31Z OWNER

Due to bug #1233 I'm going to publish the additional database as extra_database.db rather than extra database.db as it is used in the tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 --crossdb option for joining across databases 811407131  
781634819 https://github.com/simonw/datasette/pull/1232#issuecomment-781634819 https://api.github.com/repos/simonw/datasette/issues/1232 MDEyOklzc3VlQ29tbWVudDc4MTYzNDgxOQ== simonw 9599 2021-02-18T21:06:43Z 2021-02-18T21:06:43Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 --crossdb option for joining across databases 811407131  
781629841 https://github.com/simonw/datasette/pull/1232#issuecomment-781629841 https://api.github.com/repos/simonw/datasette/issues/1232 MDEyOklzc3VlQ29tbWVudDc4MTYyOTg0MQ== simonw 9599 2021-02-18T20:57:23Z 2021-02-18T20:57:23Z OWNER

The new warning looks like this:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 --crossdb option for joining across databases 811407131  
781598585 https://github.com/simonw/datasette/pull/1232#issuecomment-781598585 https://api.github.com/repos/simonw/datasette/issues/1232 MDEyOklzc3VlQ29tbWVudDc4MTU5ODU4NQ== simonw 9599 2021-02-18T19:57:30Z 2021-02-18T19:57:30Z OWNER

It would also be neat if https://latest.datasette.io/ had multiple databases attached in order to demonstrate this feature.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 --crossdb option for joining across databases 811407131  
781594632 https://github.com/simonw/datasette/pull/1232#issuecomment-781594632 https://api.github.com/repos/simonw/datasette/issues/1232 MDEyOklzc3VlQ29tbWVudDc4MTU5NDYzMg== simonw 9599 2021-02-18T19:50:21Z 2021-02-18T19:50:21Z OWNER

It would be neat if the /_memory page showed a list of attached databases, to indicate that the --crossdb option is working and give people links to click to start running queries.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 --crossdb option for joining across databases 811407131  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);