issue_comments

Table actions

2 rows where issue = 828811618 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Table names containing single quotes break things · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
852686827 https://github.com/simonw/datasette/issues/1257#issuecomment-852686827 https://api.github.com/repos/simonw/datasette/issues/1257 MDEyOklzc3VlQ29tbWVudDg1MjY4NjgyNw== simonw 9599 2021-06-02T03:26:27Z 2021-06-02T03:26:27Z OWNER

I tried and failed to get this fix working for tables with double quotes in their name - I couldn't figure out what the double-quote-in-a-table-name version of this code would look like: https://github.com/simonw/datasette/blob/807de378d08752a0f05bb1b980a0a62620a70520/datasette/utils/init.py#L538-L548

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Table names containing single quotes break things 828811618  
852681622 https://github.com/simonw/datasette/issues/1257#issuecomment-852681622 https://api.github.com/repos/simonw/datasette/issues/1257 MDEyOklzc3VlQ29tbWVudDg1MjY4MTYyMg== simonw 9599 2021-06-02T03:12:18Z 2021-06-02T03:12:18Z OWNER

Created a test database like this: ``` % sqlite-utils create-table quote-in-name.db "this'hasquoteinname" id integer name text --pk id % datasette quote-in-name.db -p 8025 --pdb INFO: Started server process [86046] INFO: Waiting for application startup. INFO: Application startup complete. INFO: Uvicorn running on http://127.0.0.1:8025 (Press CTRL+C to quit)

/Users/simon/Dropbox/Development/datasette/datasette/utils/init.py(530)detect_fts() -> rows = conn.execute(detect_fts_sql(table)).fetchall() (Pdb) c Traceback (most recent call last): File "/Users/simon/Dropbox/Development/datasette/datasette/app.py", line 1124, in route_path response = await view(request, send) File "/Users/simon/Dropbox/Development/datasette/datasette/views/base.py", line 147, in view return await self.dispatch_request( File "/Users/simon/Dropbox/Development/datasette/datasette/views/base.py", line 122, in dispatch_request return await handler(request, args, kwargs) File "/Users/simon/Dropbox/Development/datasette/datasette/views/index.py", line 72, in get "fts_table": await db.fts_table(table), File "/Users/simon/Dropbox/Development/datasette/datasette/database.py", line 279, in fts_table return await self.execute_fn(lambda conn: detect_fts(conn, table)) File "/Users/simon/Dropbox/Development/datasette/datasette/database.py", line 155, in execute_fn return await asyncio.get_event_loop().run_in_executor( File "/Users/simon/.pyenv/versions/3.8.2/lib/python3.8/concurrent/futures/thread.py", line 57, in run result = self.fn(self.args, **self.kwargs) File "/Users/simon/Dropbox/Development/datasette/datasette/database.py", line 153, in in_thread return fn(conn) File "/Users/simon/Dropbox/Development/datasette/datasette/database.py", line 279, in <lambda> return await self.execute_fn(lambda conn: detect_fts(conn, table)) File "/Users/simon/Dropbox/Development/datasette/datasette/utils/init.py", line 530, in detect_fts rows = conn.execute(detect_fts_sql(table)).fetchall() sqlite3.OperationalError: near "hasquoteinname": syntax error ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Table names containing single quotes break things 828811618  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);