issue_comments

Table actions

3 rows where issue = 837956424 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Use SQLite conn.interrupt() instead of sqlite_timelimit() · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
804299406 https://github.com/simonw/datasette/pull/1271#issuecomment-804299406 https://api.github.com/repos/simonw/datasette/issues/1271 MDEyOklzc3VlQ29tbWVudDgwNDI5OTQwNg== simonw 9599 2021-03-22T18:36:14Z 2021-03-22T21:49:27Z OWNER

This isn't actually working - the outer code attempts to send an .interrupt() call to the connection object via the connections thread-local, which doesn't work because it's a thread-local so the connection isn't visible to that code.

Need to figure out how to communicate with that thread properly.

Also a test that fails in this particular case would be a good idea!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Use SQLite conn.interrupt() instead of sqlite_timelimit() 837956424  
804265042 https://github.com/simonw/datasette/pull/1271#issuecomment-804265042 https://api.github.com/repos/simonw/datasette/issues/1271 MDEyOklzc3VlQ29tbWVudDgwNDI2NTA0Mg== simonw 9599 2021-03-22T17:45:45Z 2021-03-22T17:45:45Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Use SQLite conn.interrupt() instead of sqlite_timelimit() 837956424  
804261103 https://github.com/simonw/datasette/pull/1271#issuecomment-804261103 https://api.github.com/repos/simonw/datasette/issues/1271 MDEyOklzc3VlQ29tbWVudDgwNDI2MTEwMw== codecov[bot] 22429695 2021-03-22T17:39:57Z 2021-03-22T17:39:57Z NONE

Codecov Report

Merging #1271 (fb2ad7a) into main (c4f1ec7) will decrease coverage by 0.28%. The diff coverage is 94.28%.

```diff @@ Coverage Diff @@

main #1271 +/-

========================================== - Coverage 91.51% 91.22% -0.29%
========================================== Files 34 34
Lines 4255 4263 +8
========================================== - Hits 3894 3889 -5
- Misses 361 374 +13
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/database.py | 92.41% <94.28%> (-0.52%) | :arrow_down: | | datasette/utils/__init__.py | 92.24% <0.00%> (-1.90%) | :arrow_down: |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c4f1ec7...fb2ad7a. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Use SQLite conn.interrupt() instead of sqlite_timelimit() 837956424  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);