issue_comments

Table actions

4 rows where issue = 855446829 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

author_association 3

issue 1

  • Dockerfile: use Ubuntu 20.10 as base · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
817403642 https://github.com/simonw/datasette/pull/1296#issuecomment-817403642 https://api.github.com/repos/simonw/datasette/issues/1296 MDEyOklzc3VlQ29tbWVudDgxNzQwMzY0Mg== codecov[bot] 22429695 2021-04-12T00:29:05Z 2021-07-20T08:52:12Z NONE

Codecov Report

Merging #1296 (527a056) into main (c73af5d) will decrease coverage by 0.11%. The diff coverage is n/a.

:exclamation: Current head 527a056 differs from pull request most recent head 8f00c31. Consider uploading reports for the commit 8f00c31 to get more accurate results

```diff @@ Coverage Diff @@

main #1296 +/-

========================================== - Coverage 91.62% 91.51% -0.12%
========================================== Files 34 34
Lines 4371 4255 -116
========================================== - Hits 4005 3894 -111
+ Misses 366 361 -5
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/tracer.py | 81.60% <0.00%> (-1.35%) | :arrow_down: | | datasette/views/base.py | 95.01% <0.00%> (-0.42%) | :arrow_down: | | datasette/facets.py | 89.04% <0.00%> (-0.41%) | :arrow_down: | | datasette/utils/__init__.py | 94.13% <0.00%> (-0.21%) | :arrow_down: | | datasette/renderer.py | 94.02% <0.00%> (-0.18%) | :arrow_down: | | datasette/views/database.py | 97.19% <0.00%> (-0.10%) | :arrow_down: | | datasette/views/table.py | 95.88% <0.00%> (-0.07%) | :arrow_down: | | datasette/views/index.py | 96.36% <0.00%> (-0.07%) | :arrow_down: | | datasette/hookspecs.py | 100.00% <0.00%> (ø) | | | datasette/utils/testing.py | 95.38% <0.00%> (ø) | | | ... and 5 more | |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c73af5d...8f00c31. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Dockerfile: use Ubuntu 20.10 as base 855446829  
850583584 https://github.com/simonw/datasette/pull/1296#issuecomment-850583584 https://api.github.com/repos/simonw/datasette/issues/1296 MDEyOklzc3VlQ29tbWVudDg1MDU4MzU4NA== simonw 9599 2021-05-28T18:06:11Z 2021-05-28T18:06:11Z OWNER

As a bonus, the Docker image becomes smaller

That's a huge surprise to me! And most welcome.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Dockerfile: use Ubuntu 20.10 as base 855446829  
835491318 https://github.com/simonw/datasette/pull/1296#issuecomment-835491318 https://api.github.com/repos/simonw/datasette/issues/1296 MDEyOklzc3VlQ29tbWVudDgzNTQ5MTMxOA== blairdrummond 10801138 2021-05-08T19:59:01Z 2021-05-08T19:59:01Z CONTRIBUTOR

I have also found that ubuntu has fewer vulnerabilities than the buster based images.

➜ ~ docker pull python:3-buster ➜ ~ trivy image python:3-buster | head 2021-04-28T17:14:29.313-0400 INFO Detecting Debian vulnerabilities... 2021-04-28T17:14:29.393-0400 INFO Trivy skips scanning programming language libraries because no supported file was detected python:3-buster (debian 10.9) ============================= Total: 1621 (UNKNOWN: 13, LOW: 1106, MEDIUM: 343, HIGH: 145, CRITICAL: 14) +------------------------------+---------------------+----------+------------------------------+---------------+--------------------------------------------------------------+ | LIBRARY | VULNERABILITY ID | SEVERITY | INSTALLED VERSION | FIXED VERSION | TITLE | +------------------------------+---------------------+----------+------------------------------+---------------+--------------------------------------------------------------+

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Dockerfile: use Ubuntu 20.10 as base 855446829  
819467759 https://github.com/simonw/datasette/pull/1296#issuecomment-819467759 https://api.github.com/repos/simonw/datasette/issues/1296 MDEyOklzc3VlQ29tbWVudDgxOTQ2Nzc1OQ== camallen 295329 2021-04-14T12:07:37Z 2021-04-14T12:11:36Z CONTRIBUTOR

Removing /var/lib/apt and /var/lib/dpkg makes apt and dpkg unusable in images based on this one. Running apt-get clean and removing /var/lib/apt/lists achieves similar size savings.

this PR helps me as removing the /var/lib/apt and /var/lib/dpkg directories breaks my ability to add packages when using datasetteproject/datasette:0.56 as a base image.

Shorterm workaround for me was to use this in my Dockerfile ``` FROM datasetteproject/datasette:0.56

RUN mkdir -p /var/lib/apt RUN mkdir -p /var/lib/dpkg RUN mkdir -p /var/lib/dpkg/updates RUN mkdir -p /var/lib/dpkg/info RUN touch /var/lib/dpkg/status

RUN apt-get update # and install your packages etc ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Dockerfile: use Ubuntu 20.10 as base 855446829  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);