issue_comments

Table actions

7 rows where issue = 898904402 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • "More" link for facets that shows _facet_size=max results · 7 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
849762735 https://github.com/simonw/datasette/issues/1337#issuecomment-849762735 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTc2MjczNQ== simonw 9599 2021-05-27T16:14:14Z 2021-05-27T16:14:14Z OWNER

Here's a demo showing that once you get above 1,000 results you still get the "..." but it no longer links to anything: https://fivethirtyeight.datasettes.com/fivethirtyeight/births%2FUS_births_2000-2014_SSA?_facet=births&_facet_size=max

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "More" link for facets that shows _facet_size=max results 898904402  
849761508 https://github.com/simonw/datasette/issues/1337#issuecomment-849761508 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTc2MTUwOA== simonw 9599 2021-05-27T16:12:31Z 2021-05-27T16:12:31Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "More" link for facets that shows _facet_size=max results 898904402  
849759440 https://github.com/simonw/datasette/issues/1337#issuecomment-849759440 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTc1OTQ0MA== simonw 9599 2021-05-27T16:09:34Z 2021-05-27T16:09:34Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "More" link for facets that shows _facet_size=max results 898904402  
849725291 https://github.com/simonw/datasette/issues/1337#issuecomment-849725291 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTcyNTI5MQ== simonw 9599 2021-05-27T15:23:33Z 2021-05-27T15:23:33Z OWNER

Turns out path_with_replaced_args() is already exposed to the table.html template context: https://github.com/simonw/datasette/blob/f1c29fd6a184254aa68efadf096bcf21e848f921/datasette/views/table.py#L897-L900

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "More" link for facets that shows _facet_size=max results 898904402  
849721280 https://github.com/simonw/datasette/issues/1337#issuecomment-849721280 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTcyMTI4MA== simonw 9599 2021-05-27T15:18:08Z 2021-05-27T15:18:08Z OWNER

In order to cleanly implement this I need to expose the path_with_replaced_args utility function to Datasette's template engine. This is the first time this will become an exposed (and hence should-by-documented) API and I don't like its shape much.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "More" link for facets that shows _facet_size=max results 898904402  
849695117 https://github.com/simonw/datasette/issues/1337#issuecomment-849695117 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTY5NTExNw== simonw 9599 2021-05-27T14:44:13Z 2021-05-27T14:44:13Z OWNER

Here's a much easier way to implement this: implement ?_facet_size=max (sets it to max_returned_rows, default 1000) and then link to that from the ellipsis.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "More" link for facets that shows _facet_size=max results 898904402  
846481896 https://github.com/simonw/datasette/issues/1337#issuecomment-846481896 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0NjQ4MTg5Ng== simonw 9599 2021-05-23T00:37:52Z 2021-05-23T00:37:52Z OWNER

The tricky thing about this is that ideally I'd like this to link to a paginated set of results - but arbitrary SQL queries do not yet support pagination, see #856.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "More" link for facets that shows _facet_size=max results 898904402  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);