issue_comments

Table actions

3 rows where issue = 956303470, "updated_at" is on date 2021-07-31 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 3 ✖

issue 1

  • Tests failing with FileNotFoundError in runner.isolated_filesystem · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
890390342 https://github.com/simonw/datasette/issues/1406#issuecomment-890390342 https://api.github.com/repos/simonw/datasette/issues/1406 IC_kwDOBm6k_c41EkdG simonw 9599 2021-07-31T18:56:35Z 2021-07-31T18:56:35Z OWNER

But... I've lost enough time to this already, and removing runner.isolated_filesystem() has the tests passing again. So I'm not going to work on this any more.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Tests failing with FileNotFoundError in runner.isolated_filesystem 956303470  
890390198 https://github.com/simonw/datasette/issues/1406#issuecomment-890390198 https://api.github.com/repos/simonw/datasette/issues/1406 IC_kwDOBm6k_c41Eka2 simonw 9599 2021-07-31T18:55:33Z 2021-07-31T18:55:33Z OWNER

To clarify: the core problem here is that an error is thrown any time you call os.getcwd() but the directory you are currently in has been deleted.

runner.isolated_filesystem() assumes that the current directory in has not been deleted. But the various temporary directory utilities in pytest work by creating directories and then deleting them.

Maybe there's a larger problem here that I play a bit fast and loose with os.chdir() in both the test suite and in various lines of code in Datasette itself (in particular in the publish commands)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Tests failing with FileNotFoundError in runner.isolated_filesystem 956303470  
890259755 https://github.com/simonw/datasette/issues/1406#issuecomment-890259755 https://api.github.com/repos/simonw/datasette/issues/1406 IC_kwDOBm6k_c41EEkr simonw 9599 2021-07-31T00:04:54Z 2021-07-31T00:04:54Z OWNER

STILL failing. I'm going to try removing all instances of isolated_filesystem() in favour of a different pattern using pytest temporary files, then see if I can get that to work without the serial hack. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Tests failing with FileNotFoundError in runner.isolated_filesystem 956303470  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);