issue_comments

Table actions

9 rows where issue = 962391325 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Show count of facet values if ?_facet_size=max · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
995023410 https://github.com/simonw/datasette/issues/1423#issuecomment-995023410 https://api.github.com/repos/simonw/datasette/issues/1423 IC_kwDOBm6k_c47Ttoy simonw 9599 2021-12-15T17:48:40Z 2021-12-15T17:48:40Z OWNER

You've caused me to rethink this feature - I no longer think there's value in only showing these numbers if ?_facet_size=max as opposed to all of the time. New issue coming up.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
 Show count of facet values if ?_facet_size=max 962391325  
993876599 https://github.com/simonw/datasette/issues/1423#issuecomment-993876599 https://api.github.com/repos/simonw/datasette/issues/1423 IC_kwDOBm6k_c47PVp3 plpxsk 6165713 2021-12-14T18:48:09Z 2021-12-14T18:48:09Z NONE

Great feature.

But what is the right way to enable this to show up? Currently, it seems I need to edit the URL to add, in the right place, &_facet_size=max

Is there another (easier) way to enable this feature?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show count of facet values if ?_facet_size=max 962391325  
899749881 https://github.com/simonw/datasette/issues/1423#issuecomment-899749881 https://api.github.com/repos/simonw/datasette/issues/1423 IC_kwDOBm6k_c41oRf5 simonw 9599 2021-08-16T19:07:02Z 2021-08-16T19:07:02Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show count of facet values if ?_facet_size=max 962391325  
899744109 https://github.com/simonw/datasette/issues/1423#issuecomment-899744109 https://api.github.com/repos/simonw/datasette/issues/1423 IC_kwDOBm6k_c41oQFt simonw 9599 2021-08-16T18:58:29Z 2021-08-16T18:58:29Z OWNER

I didn't bother with the tooltip, just the visible display if ?_facet_size=max.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show count of facet values if ?_facet_size=max 962391325  
894454644 https://github.com/simonw/datasette/issues/1423#issuecomment-894454644 https://api.github.com/repos/simonw/datasette/issues/1423 IC_kwDOBm6k_c41UEt0 simonw 9599 2021-08-06T18:52:49Z 2021-08-06T18:52:49Z OWNER

This means that the counts would be unavailable to users who cannot see tooltips (e.g. mobile users) on pages that did not have any facets that broke the 30 limit and hence displayed that "..." link.

I think I'm OK with that, for the moment. May revisit in the future.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show count of facet values if ?_facet_size=max 962391325  
894454087 https://github.com/simonw/datasette/issues/1423#issuecomment-894454087 https://api.github.com/repos/simonw/datasette/issues/1423 IC_kwDOBm6k_c41UElH simonw 9599 2021-08-06T18:51:42Z 2021-08-06T18:51:42Z OWNER

The invisible tooltip could say "Showing 30 items, more available" (helping save you from counting up to 20 if you know about the secret feature). The numbers could then be fully displayed on the "..." page.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show count of facet values if ?_facet_size=max 962391325  
894453520 https://github.com/simonw/datasette/issues/1423#issuecomment-894453520 https://api.github.com/repos/simonw/datasette/issues/1423 IC_kwDOBm6k_c41UEcQ simonw 9599 2021-08-06T18:50:40Z 2021-08-06T18:50:40Z OWNER

Point of confusion: if only 30 options are shown, but there's a ... at the end, what would the number be? It can't be the total number of facets because we haven't counted them all - but if it's just the number of displayed facets that's like to be confusing.

So the original idea of showing the counts only if _facet_size=max is a good one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show count of facet values if ?_facet_size=max 962391325  
894452990 https://github.com/simonw/datasette/issues/1423#issuecomment-894452990 https://api.github.com/repos/simonw/datasette/issues/1423 IC_kwDOBm6k_c41UET- simonw 9599 2021-08-06T18:49:37Z 2021-08-06T18:49:37Z OWNER

Could display them always, like this:

That's with <span style="font-size: 0.8em;color: #666;">23</span>

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show count of facet values if ?_facet_size=max 962391325  
893996604 https://github.com/simonw/datasette/issues/1423#issuecomment-893996604 https://api.github.com/repos/simonw/datasette/issues/1423 IC_kwDOBm6k_c41SU48 simonw 9599 2021-08-06T04:43:07Z 2021-08-06T04:43:37Z OWNER

Problem: on a page which doesn't have quite enough facet values to trigger the display of the "..." link that links to ?_facet_size=max the user would still have to manually count the values - up to 30 by default.

So maybe the count should always be shown, perhaps as a non-bold light colored number?

I could even hide it in a non-discoverable tooltip.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show count of facet values if ?_facet_size=max 962391325  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);