issue_comments

Table actions

6 rows where issue = 974987856 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 6 ✖

issue 1

  • Mechanism to cause specific branches to deploy their own demos · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
902243498 https://github.com/simonw/datasette/issues/1442#issuecomment-902243498 https://api.github.com/repos/simonw/datasette/issues/1442 IC_kwDOBm6k_c41xySq simonw 9599 2021-08-19T21:04:01Z 2021-08-19T21:04:01Z OWNER

That successfully deployed to https://datasette-latest-deploy-this-branch-j7hipcg4aq-uc.a.run.app/ even though the tests failed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism to cause specific branches to deploy their own demos 974987856  
902239215 https://github.com/simonw/datasette/issues/1442#issuecomment-902239215 https://api.github.com/repos/simonw/datasette/issues/1442 IC_kwDOBm6k_c41xxPv simonw 9599 2021-08-19T20:56:46Z 2021-08-19T20:56:46Z OWNER

I'm going to only run the tests if it's a push to main - that way I can ship demo branches really quickly, even if they don't yet have passing tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism to cause specific branches to deploy their own demos 974987856  
902235714 https://github.com/simonw/datasette/issues/1442#issuecomment-902235714 https://api.github.com/repos/simonw/datasette/issues/1442 IC_kwDOBm6k_c41xwZC simonw 9599 2021-08-19T20:50:38Z 2021-08-19T20:50:38Z OWNER

Would this allow anyone to push a PR to this repo that would result in their code being deployed against my Cloud Run account? I'm reasonably confident that it would not, since the secrets would not be visible to their PR branch.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism to cause specific branches to deploy their own demos 974987856  
902231018 https://github.com/simonw/datasette/issues/1442#issuecomment-902231018 https://api.github.com/repos/simonw/datasette/issues/1442 IC_kwDOBm6k_c41xvPq simonw 9599 2021-08-19T20:42:08Z 2021-08-19T20:42:08Z OWNER

If I get this working I should document it on https://docs.datasette.io/en/stable/contributing.html

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism to cause specific branches to deploy their own demos 974987856  
902217726 https://github.com/simonw/datasette/issues/1442#issuecomment-902217726 https://api.github.com/repos/simonw/datasette/issues/1442 IC_kwDOBm6k_c41xr_- simonw 9599 2021-08-19T20:21:47Z 2021-08-19T20:21:47Z OWNER

I think the neatest way to implement this would be for the on -> push -> branches list to be the list of branches that should be deployed in this way. The rest of the code can react to that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism to cause specific branches to deploy their own demos 974987856  
902191150 https://github.com/simonw/datasette/issues/1442#issuecomment-902191150 https://api.github.com/repos/simonw/datasette/issues/1442 IC_kwDOBm6k_c41xlgu simonw 9599 2021-08-19T19:43:05Z 2021-08-19T19:43:59Z OWNER

Maybe as simple as teaching https://github.com/simonw/datasette/blob/main/.github/workflows/deploy-latest.yml to run on pushes to ALL branches:

https://github.com/simonw/datasette/blob/adb5b70de5cec3c3dd37184defe606a082c232cf/.github/workflows/deploy-latest.yml#L3-L6

And then quit early if the branch is not in some allow-list.

If it IS in the allow-list, use the name of the branch to dynamically construct the name of the Cloud Run service here: https://github.com/simonw/datasette/blob/adb5b70de5cec3c3dd37184defe606a082c232cf/.github/workflows/deploy-latest.yml#L60

Need to skip the documentation build and deployment stuff for other branches though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism to cause specific branches to deploy their own demos 974987856  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);