issue_comments

Table actions

5 rows where issue = 978537855 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Ability to insert file contents as text, in addition to blob · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
905022931 https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905022931 https://api.github.com/repos/simonw/sqlite-utils/issues/321 IC_kwDOCGYnMM418Y3T codecov[bot] 22429695 2021-08-24T22:38:38Z 2021-08-24T23:27:26Z NONE

Codecov Report

Merging #321 (db2dd6d) into main (9258f4b) will increase coverage by 0.16%. The diff coverage is 100.00%.

```diff @@ Coverage Diff @@

main #321 +/-

========================================== + Coverage 96.41% 96.58% +0.16%
========================================== Files 5 5
Lines 2206 2223 +17
========================================== + Hits 2127 2147 +20
+ Misses 79 76 -3
```

| Impacted Files | Coverage Δ | | |---|---|---| | sqlite_utils/cli.py | 95.69% <100.00%> (+0.42%) | :arrow_up: |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9258f4b...db2dd6d. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to insert file contents as text, in addition to blob 978537855  
905040902 https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905040902 https://api.github.com/repos/simonw/sqlite-utils/issues/321 IC_kwDOCGYnMM418dQG simonw 9599 2021-08-24T23:25:03Z 2021-08-24T23:25:03Z OWNER

I'm going to skip this test on windows.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to insert file contents as text, in addition to blob 978537855  
905040307 https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905040307 https://api.github.com/repos/simonw/sqlite-utils/issues/321 IC_kwDOCGYnMM418dGz simonw 9599 2021-08-24T23:23:36Z 2021-08-24T23:23:36Z OWNER

https://discuss.python.org/t/pep-597-use-utf-8-for-default-text-file-encoding/1819 says:

Currently, TextIOWrapper uses locale.getpreferredencoding(False) (hereinafter called “locale encoding”) when encoding is not specified. ... Package authors using macOS or Linux may forget that the default encoding is not always UTF-8.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to insert file contents as text, in addition to blob 978537855  
905039576 https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905039576 https://api.github.com/repos/simonw/sqlite-utils/issues/321 IC_kwDOCGYnMM418c7Y simonw 9599 2021-08-24T23:21:29Z 2021-08-24T23:21:29Z OWNER

Hah, the error here is actually: ```

      assert result.exit_code == 1, result.output

E AssertionError: E
E assert 0 == 1 E + where 0 = <Result okay>.exit_code ``` So I was expecting an error, but instead the command worked.

I suspect this is because on Windows the default character set may not be UTF-8?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to insert file contents as text, in addition to blob 978537855  
905037323 https://github.com/simonw/sqlite-utils/pull/321#issuecomment-905037323 https://api.github.com/repos/simonw/sqlite-utils/issues/321 IC_kwDOCGYnMM418cYL simonw 9599 2021-08-24T23:15:29Z 2021-08-24T23:15:29Z OWNER

Huh, tests are failing but only on Windows!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to insert file contents as text, in addition to blob 978537855  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);