issue_comments

Table actions

4 rows where issue = 995098231 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • ?_sort=rowid with _next= returns error · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
946097058 https://github.com/simonw/datasette/issues/1470#issuecomment-946097058 https://api.github.com/repos/simonw/datasette/issues/1470 IC_kwDOBm6k_c44ZEui simonw 9599 2021-10-18T19:30:15Z 2021-10-18T19:30:15Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ?_sort=rowid with _next= returns error 995098231  
939386591 https://github.com/simonw/datasette/issues/1470#issuecomment-939386591 https://api.github.com/repos/simonw/datasette/issues/1470 IC_kwDOBm6k_c43_ebf simonw 9599 2021-10-10T01:17:34Z 2021-10-10T01:17:34Z OWNER

I'll open a separate issue for removing _next= when running a search.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ?_sort=rowid with _next= returns error 995098231  
938131806 https://github.com/simonw/datasette/issues/1470#issuecomment-938131806 https://api.github.com/repos/simonw/datasette/issues/1470 IC_kwDOBm6k_c436sFe simonw 9599 2021-10-07T20:28:30Z 2021-10-07T20:28:30Z OWNER

On further investigation this isn't related to _search at all - it happens when you explicitly sort by _sort=rowid and apply a _next

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ?_sort=rowid with _next= returns error 995098231  
938124652 https://github.com/simonw/datasette/issues/1470#issuecomment-938124652 https://api.github.com/repos/simonw/datasette/issues/1470 IC_kwDOBm6k_c436qVs simonw 9599 2021-10-07T20:17:53Z 2021-10-07T20:18:55Z OWNER

Here's the exception: -> params[f"p{len(params)}"] = components[0] (Pdb) list 603 604 # Figure out the SQL for next-based-on-primary-key first 605 next_by_pk_clauses = [] 606 if use_rowid: 607 next_by_pk_clauses.append(f"rowid > :p{len(params)}") 608 -> params[f"p{len(params)}"] = components[0] 609 else: 610 # Apply the tie-breaker based on primary keys 611 if len(components) == len(pks): 612 param_len = len(params) 613 next_by_pk_clauses.append( Debugger shows that components is an empty array, so components[0] cannot be resolved:

-> params[f"p{len(params)}"] = components[0] (Pdb) params {'search': 'hello'} (Pdb) components []

So the bug is in this code: https://github.com/simonw/datasette/blob/adb5b70de5cec3c3dd37184defe606a082c232cf/datasette/views/table.py#L604-L617

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ?_sort=rowid with _next= returns error 995098231  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);