home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

10 rows where issue_url = "https://api.github.com/repos/simonw/datasette/issues/1331" sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

  • simonw 6
  • MarkusH 3
  • stonebig 1

author_association 2

  • OWNER 6
  • NONE 4

issue 1

  • Add support for Jinja2 version 3.0 10
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
846483426 https://github.com/simonw/datasette/issues/1331#issuecomment-846483426 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0NjQ4MzQyNg== simonw 9599 2021-05-23T00:57:30Z 2021-05-23T00:57:30Z OWNER

Here's an alpha release with updated dependencies: https://pypi.org/project/datasette/0.57a0/

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  
846482057 https://github.com/simonw/datasette/issues/1331#issuecomment-846482057 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0NjQ4MjA1Nw== simonw 9599 2021-05-23T00:39:55Z 2021-05-23T00:39:55Z OWNER

I'm stuck also because datasette wants itsdangerous~=1.1 instead of allowing itsdangerous-2.0.0

Bumped that dependency in b64d87204612a84663616e075f542499a5d82a03

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  
846481937 https://github.com/simonw/datasette/issues/1331#issuecomment-846481937 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0NjQ4MTkzNw== simonw 9599 2021-05-23T00:38:28Z 2021-05-23T00:38:28Z OWNER

I'm going to push an alpha release with the new dependencies shortly.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  
846137332 https://github.com/simonw/datasette/issues/1331#issuecomment-846137332 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0NjEzNzMzMg== stonebig 4312421 2021-05-21T17:57:53Z 2021-05-21T17:57:53Z NONE

I'm stuck also because datasette wants itsdangerous~=1.1 instead of allowing itsdangerous-2.0.0

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  
844970776 https://github.com/simonw/datasette/issues/1331#issuecomment-844970776 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0NDk3MDc3Ng== MarkusH 475613 2021-05-20T10:40:25Z 2021-05-20T10:40:25Z NONE

Any chance you could push a new datasette release with the updated dependencies in the setup.py, @simonw?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  
842499728 https://github.com/simonw/datasette/issues/1331#issuecomment-842499728 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0MjQ5OTcyOA== MarkusH 475613 2021-05-17T17:24:30Z 2021-05-17T17:24:30Z NONE

I wonder if there are any new 3.0 features we should be taking advantage of here that would justify pinning to 3.0 minimum?

The changelog reads like bug fixes and removal of deprecated parts to me

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  
842497125 https://github.com/simonw/datasette/issues/1331#issuecomment-842497125 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0MjQ5NzEyNQ== simonw 9599 2021-05-17T17:20:15Z 2021-05-17T17:20:15Z OWNER

I wonder if there are any new 3.0 features we should be taking advantage of here that would justify pinning to 3.0 minimum?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  
842495820 https://github.com/simonw/datasette/issues/1331#issuecomment-842495820 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0MjQ5NTgyMA== MarkusH 475613 2021-05-17T17:18:05Z 2021-05-17T17:18:05Z NONE

Wow, you are fast!

I didn't notice dependabot had opened a PR already. I was about to.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  
842495346 https://github.com/simonw/datasette/issues/1331#issuecomment-842495346 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0MjQ5NTM0Ng== simonw 9599 2021-05-17T17:17:19Z 2021-05-17T17:17:19Z OWNER

The tests are passing on #1324 so this may not require any code changes at all!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  
842494332 https://github.com/simonw/datasette/issues/1331#issuecomment-842494332 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0MjQ5NDMzMg== simonw 9599 2021-05-17T17:15:45Z 2021-05-17T17:16:04Z OWNER

Datasette uses async templates which evidently have been improved in Jinja 2 3.0.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add support for Jinja2 version 3.0 893537744  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 1082.881ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows