issue_comments

Table actions

5 rows where "updated_at" is on date 2020-10-28 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 2

author_association 2

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
718243062 https://github.com/simonw/datasette/pull/1060#issuecomment-718243062 https://api.github.com/repos/simonw/datasette/issues/1060 MDEyOklzc3VlQ29tbWVudDcxODI0MzA2Mg== codecov[bot] 22429695 2020-10-28T22:23:33Z 2020-10-28T22:23:33Z NONE

Codecov Report

Merging #1060 into main will increase coverage by 6.42%. The diff coverage is 100.00%.

```diff @@ Coverage Diff @@

main #1060 +/-

========================================== + Coverage 84.71% 91.13% +6.42%
========================================== Files 28 27 -1
Lines 3957 3677 -280
========================================== - Hits 3352 3351 -1
+ Misses 605 326 -279
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/cli.py | 73.63% <100.00%> (+0.13%) | :arrow_up: | | datasette/version.py | 100.00% <100.00%> (ø) | |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update abcf022...4725d46. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New explicit versioning mechanism 731827081  
718170295 https://github.com/simonw/sqlite-utils/issues/191#issuecomment-718170295 https://api.github.com/repos/simonw/sqlite-utils/issues/191 MDEyOklzc3VlQ29tbWVudDcxODE3MDI5NQ== simonw 9599 2020-10-28T19:50:16Z 2020-10-28T19:50:16Z OWNER

I think I made a mistake when I designed the initial decorator. I should have had it work like this:

python @db.register_function() def reverse_string(s): return "".join(reversed(list(s))) As this leaves open the option to add new parameters in the future.

To avoid breaking backwards compatibility I'll use the hack that detects the argument this time, but in the future I'll try to remember to always design decorators to be called like @decorator().

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Idea: @db.register_function(deterministic=True) 731740458  
718168730 https://github.com/simonw/sqlite-utils/issues/191#issuecomment-718168730 https://api.github.com/repos/simonw/sqlite-utils/issues/191 MDEyOklzc3VlQ29tbWVudDcxODE2ODczMA== simonw 9599 2020-10-28T19:47:20Z 2020-10-28T19:47:20Z OWNER

https://stackoverflow.com/a/3931903 looks useful: python def trace(*args): def _trace(func): def wrapper(*args, **kwargs): print enter_string func(*args, **kwargs) print exit_string return wrapper if len(args) == 1 and callable(args[0]): # No arguments, this is the decorator # Set default values for the arguments enter_string = 'entering' exit_string = 'exiting' return _trace(args[0]) else: # This is just returning the decorator enter_string, exit_string = args return _trace Can improve that code with functools.wraps.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Idea: @db.register_function(deterministic=True) 731740458  
718078447 https://github.com/simonw/datasette/pull/1059#issuecomment-718078447 https://api.github.com/repos/simonw/datasette/issues/1059 MDEyOklzc3VlQ29tbWVudDcxODA3ODQ0Nw== simonw 9599 2020-10-28T17:07:59Z 2020-10-28T17:08:14Z OWNER

0.6.0 (2020-10-27)

  • aiofiles is now tested on ppc64le.
  • Added name and mode properties to async file objects. #82
  • Fixed a DeprecationWarning internally. #75
  • Python 3.9 support and tests.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update aiofiles requirement from <0.6,>=0.4 to >=0.4,<0.7 731445447  
717938992 https://github.com/simonw/datasette/pull/1059#issuecomment-717938992 https://api.github.com/repos/simonw/datasette/issues/1059 MDEyOklzc3VlQ29tbWVudDcxNzkzODk5Mg== codecov[bot] 22429695 2020-10-28T13:38:46Z 2020-10-28T13:38:46Z NONE

Codecov Report

Merging #1059 into main will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1059 +/-

======================================= Coverage 84.71% 84.71%
======================================= Files 28 28
Lines 3957 3957
======================================= Hits 3352 3352
Misses 605 605
```

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7d9fedc...e46327a. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update aiofiles requirement from <0.6,>=0.4 to >=0.4,<0.7 731445447  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);