issue_comments

Table actions

17 rows where "updated_at" is on date 2020-12-09 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 3

author_association 2

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
741992106 https://github.com/simonw/datasette/issues/1091#issuecomment-741992106 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc0MTk5MjEwNg== simonw 9599 2020-12-09T19:19:54Z 2020-12-09T20:27:45Z OWNER

Could you try removing the ProxyPassReverse /datasette http://0.0.0.0:8001 line?

My hunch is that ProxyPassReverse is rewriting some of the links in the HTML (or maybe in the HTTP headers) in a way that breaks things.

Normally you would need ProxyPassReverse to compensate for the underlying application being unable to rewrite its links - but Datasette's base_url setting causes Datasette to rewrite all of the links for you, so ProxyPassReverse should be unneccessary.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
742024588 https://github.com/simonw/datasette/issues/1134#issuecomment-742024588 https://api.github.com/repos/simonw/datasette/issues/1134 MDEyOklzc3VlQ29tbWVudDc0MjAyNDU4OA== simonw 9599 2020-12-09T20:19:59Z 2020-12-09T20:20:33Z OWNER

https://byraadsarkivet.aarhus.dk/db/cases?_searchmode=raw&_search=sundhedsfrem%2A is an absolutely beautiful example of a themed Datasette! Very excited to show this to people.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "_searchmode=raw" throws an index out of range error when combined with "_search_COLUMN" 760312579  
742023775 https://github.com/simonw/datasette/issues/1134#issuecomment-742023775 https://api.github.com/repos/simonw/datasette/issues/1134 MDEyOklzc3VlQ29tbWVudDc0MjAyMzc3NQ== simonw 9599 2020-12-09T20:18:23Z 2020-12-09T20:18:23Z OWNER

A fix for this should be available if you upgrade to 0.52.5

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "_searchmode=raw" throws an index out of range error when combined with "_search_COLUMN" 760312579  
742023541 https://github.com/simonw/datasette/issues/1091#issuecomment-742023541 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc0MjAyMzU0MQ== simonw 9599 2020-12-09T20:17:54Z 2020-12-09T20:17:54Z OWNER

OK that is really weird. I'll have another go at replicating this locally.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
742023111 https://github.com/simonw/datasette/issues/1136#issuecomment-742023111 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAyMzExMQ== simonw 9599 2020-12-09T20:17:02Z 2020-12-09T20:17:02Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742022222 https://github.com/simonw/datasette/issues/1136#issuecomment-742022222 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAyMjIyMg== simonw 9599 2020-12-09T20:15:24Z 2020-12-09T20:15:51Z OWNER

Used this procedure for the first time for 0.52.5 - deploy run here: https://github.com/simonw/datasette/actions/runs/411465648 - PyPI release here: https://pypi.org/project/datasette/0.52.5/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742017622 https://github.com/simonw/datasette/issues/1136#issuecomment-742017622 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAxNzYyMg== simonw 9599 2020-12-09T20:06:47Z 2020-12-09T20:06:47Z OWNER

Then I can ship the release directly from that branch, creating the tag as part of the release process:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742014881 https://github.com/simonw/datasette/issues/1136#issuecomment-742014881 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAxNDg4MQ== simonw 9599 2020-12-09T20:01:27Z 2020-12-09T20:01:27Z OWNER

I'll write the release notes in the branch, then cherry-pick them over to main.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742014366 https://github.com/simonw/datasette/issues/1136#issuecomment-742014366 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAxNDM2Ng== simonw 9599 2020-12-09T20:00:35Z 2020-12-09T20:00:35Z OWNER

Actually I'll start from 0.52.4 and then cherry-pick the fixes.

git branch 0.52.x 0.52.4
git checkout 0.52.x
git cherry-pick COMMIT

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742010306 https://github.com/simonw/datasette/issues/1091#issuecomment-742010306 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc0MjAxMDMwNg== tballison 6739646 2020-12-09T19:53:18Z 2020-12-09T19:59:52Z NONE

I can't imagine this helps (esp. given your point about potential rewrites), but you can see that /datasette/ was correctly added to the sql form, but not to the "export-links"

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
742012324 https://github.com/simonw/datasette/issues/1134#issuecomment-742012324 https://api.github.com/repos/simonw/datasette/issues/1134 MDEyOklzc3VlQ29tbWVudDc0MjAxMjMyNA== simonw 9599 2020-12-09T19:57:05Z 2020-12-09T19:57:05Z OWNER

Thanks for the bug report!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "_searchmode=raw" throws an index out of range error when combined with "_search_COLUMN" 760312579  
742009294 https://github.com/simonw/datasette/issues/1136#issuecomment-742009294 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAwOTI5NA== simonw 9599 2020-12-09T19:51:18Z 2020-12-09T19:51:18Z OWNER

Likewise, Read The Docs publishes as stable the docs from the latest tagged release, so I would expect that to work fine as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742009101 https://github.com/simonw/datasette/issues/1136#issuecomment-742009101 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAwOTEwMQ== simonw 9599 2020-12-09T19:50:53Z 2020-12-09T19:50:53Z OWNER

My concern is if this will break anything about CI. I don't think it will - the code that deploys the latest main to https://latest.datasette.io/ should be unaffected, and the checkout code in publish.yml should check out the correct code based on the tag used for that release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742008087 https://github.com/simonw/datasette/issues/1136#issuecomment-742008087 https://api.github.com/repos/simonw/datasette/issues/1136 MDEyOklzc3VlQ29tbWVudDc0MjAwODA4Nw== simonw 9599 2020-12-09T19:48:56Z 2020-12-09T19:48:56Z OWNER

I think I'm going to create a branch called 0.52.x that starts with 8ae0f9f7f0d644b0161165a1084f53acd2786f7c and then tag the release from there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Establish pattern for release branches to support bug fixes 760621356  
742001510 https://github.com/simonw/datasette/issues/1091#issuecomment-742001510 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc0MjAwMTUxMA== tballison 6739646 2020-12-09T19:36:42Z 2020-12-09T19:38:04Z NONE

I don't think this fixes it:

grep -R datasette . ./sites-available/000-default.conf: ProxyPass /datasette http://127.0.0.1:8001/ ./sites-available/000-default.conf: #ProxyPassReverse /datasette http://127.0.0.1:8001/ ./sites-available/corpora-le-ssl.conf: ProxyPass /datasette http://0.0.0.0:8001 ./sites-available/corpora-le-ssl.conf: #ProxyPassReverse /datasette http://0.0.0.0:8001 ./sites-enabled/corpora-le-ssl.conf: ProxyPass /datasette http://0.0.0.0:8001 ./sites-enabled/corpora-le-ssl.conf: #ProxyPassReverse /datasette http://0.0.0.0:8001

And I confirmed that I actually restarted the server. :rofl:

https://corpora.tika.apache.org/datasette/file_profiles

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
741804334 https://github.com/simonw/datasette/issues/1091#issuecomment-741804334 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc0MTgwNDMzNA== tballison 6739646 2020-12-09T14:26:05Z 2020-12-09T14:26:05Z NONE

Anything we can do to help debug this? Thank you, again!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
741665253 https://github.com/simonw/datasette/issues/766#issuecomment-741665253 https://api.github.com/repos/simonw/datasette/issues/766 MDEyOklzc3VlQ29tbWVudDc0MTY2NTI1Mw== clausjuhl 2181410 2020-12-09T09:59:05Z 2020-12-09T09:59:05Z NONE

Hi Simon. Any news on using wildcard-searches with datasette? Thanks!

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Enable wildcard-searches by default 617323873  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);