home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

34 rows where "updated_at" is on date 2021-05-27 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

issue 11

  • Test Datasette Docker images built for different architectures 10
  • "More" link for facets that shows _facet_size=max results 6
  • Add Docker multi-arch support with Buildx 5
  • Figure out how to publish alpha/beta releases to Docker Hub 4
  • Improve `path_with_replaced_args()` and friends and document them 3
  • Mechanism for customizing the SQL used to select specific columns in the table view 1
  • ?_col= and ?_nocol= support for toggling columns on table view 1
  • WIP: Add Gmail takeout mbox import 1
  • ?_facet_size=X to increase number of facets results on the page 1
  • ?_col=/?_nocol= to show/hide columns on the table page 1
  • "Show all columns" cog menu item should show if ?_col= is used 1

user 3

  • simonw 31
  • codecov[bot] 2
  • maxhawkins 1

author_association 2

  • OWNER 31
  • NONE 3
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
849820019 https://github.com/simonw/datasette/issues/1344#issuecomment-849820019 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgyMDAxOQ== simonw 9599 2021-05-27T17:44:39Z 2021-05-27T17:52:58Z OWNER

This pattern appears to work, executed at the root of a checkout of datasette: docker run -it -v `pwd`:/mnt --platform linux/amd64 \ datasetteproject/datasette:0.57a1 bash -c ' pip install "pytest>=5.2.2,<6.3.0" \ "pytest-xdist>=2.2.1,<2.3" \ "pytest-asyncio>=0.10,<0.16" \ "beautifulsoup4>=4.8.1,<4.10.0" \ "black==21.5b1" \ "pytest-timeout>=1.4.2,<1.5" \ "trustme>=0.7,<0.8" \ && cd /mnt && pytest'

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849815361 https://github.com/simonw/datasette/issues/1344#issuecomment-849815361 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgxNTM2MQ== simonw 9599 2021-05-27T17:36:51Z 2021-05-27T17:36:51Z OWNER

To run the test suite... need to install a few more dependencies: https://github.com/simonw/datasette/blob/7b106e106000713bbee31b34d694b3dadbd4818c/setup.py#L71-L79

And then mount the tests/ folder into the container and run pytest.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849806581 https://github.com/simonw/datasette/issues/1344#issuecomment-849806581 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgwNjU4MQ== simonw 9599 2021-05-27T17:22:37Z 2021-05-27T17:34:27Z OWNER

~ % docker run -it --platform linux/arm/v7 -v `pwd`:/mnt -p 8001:8001 datasetteproject/datasette:0.57a1 python -c 'import platform; print(platform.uname())' Unable to find image 'datasetteproject/datasette:0.57a1' locally 0.57a1: Pulling from datasetteproject/datasette ee0a2cc24f29: Pull complete ca231153300d: Pull complete 6073fc53d406: Pull complete bb2a6a6421dd: Pull complete 14c15f441034: Pull complete 28d113f72ba5: Pull complete 40516c2c3785: Pull complete Digest: sha256:8dd469efa0b34b9e946c4e91496fc7bec702efec9c0f5ec548ccd4030f3263b2 Status: Downloaded newer image for datasetteproject/datasette:0.57a1 uname_result(system='Linux', node='c2e1a05732ed', release='4.19.121-linuxkit', version='#1 SMP Thu Jan 21 15:36:34 UTC 2021', machine='armv7l') Shorter version: ~ % docker run -it --platform linux/ppc64le datasetteproject/datasette:0.57a1 python -c 'import platform; print(platform.uname())' Unable to find image 'datasetteproject/datasette:0.57a1' locally 0.57a1: Pulling from datasetteproject/datasette c840eb5e9aed: Pull complete fc17d8b577ec: Pull complete 712a0ad995f8: Pull complete 56101149914c: Pull complete e6241dfe9d38: Pull complete 41ed85039888: Pull complete 26beeabe9213: Pull complete Digest: sha256:8dd469efa0b34b9e946c4e91496fc7bec702efec9c0f5ec548ccd4030f3263b2 Status: Downloaded newer image for datasetteproject/datasette:0.57a1 uname_result(system='Linux', node='0fe85887fa30', release='4.19.121-linuxkit', version='#1 SMP Thu Jan 21 15:36:34 UTC 2021', machine='ppc64le') ~ %

OK! Now I need to figure out how to run the full test suite on each one, then I can call this done.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849805778 https://github.com/simonw/datasette/issues/1344#issuecomment-849805778 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgwNTc3OA== simonw 9599 2021-05-27T17:21:11Z 2021-05-27T17:21:22Z OWNER

This helps: ~ % docker run -it --platform linux/s390x -v `pwd`:/mnt \ -p 8001:8001 datasetteproject/datasette:0.57a1 \ python -c 'import platform; print(platform.uname())' uname_result(system='Linux', node='d14916ca91df', release='4.19.121-linuxkit', version='#1 SMP Thu Jan 21 15:36:34 UTC 2021', machine='s390x')

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849804684 https://github.com/simonw/datasette/issues/1344#issuecomment-849804684 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgwNDY4NA== simonw 9599 2021-05-27T17:19:16Z 2021-05-27T17:19:16Z OWNER

Having pushed that to Docker Hub the following seems to work on my laptop:

docker run --platform linux/s390x \
  -v `pwd`:/mnt -p 8001:8001 \
  datasetteproject/datasette:0.57a1 datasette -p 8001 -h 0.0.0.0

I'd like to confirm that this is correctly emulating the architecture and running the correct published image though.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849801969 https://github.com/simonw/datasette/issues/1344#issuecomment-849801969 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTgwMTk2OQ== simonw 9599 2021-05-27T17:14:49Z 2021-05-27T17:14:49Z OWNER

Job completed in 13m38s - results are here: https://hub.docker.com/r/datasetteproject/datasette/tags?page=1&ordering=last_updated&name=0.57a1

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849797767 https://github.com/simonw/datasette/issues/1344#issuecomment-849797767 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTc5Nzc2Nw== simonw 9599 2021-05-27T17:08:13Z 2021-05-27T17:08:13Z OWNER

Related issue: #1272 - being able to run the test suite inside Docker inside GitHub Actions would be incredibly helpful here.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849793312 https://github.com/simonw/datasette/issues/1344#issuecomment-849793312 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTc5MzMxMg== simonw 9599 2021-05-27T17:01:16Z 2021-05-27T17:01:16Z OWNER

https://github.com/simonw/datasette/runs/2687196350 is a run of https://github.com/simonw/datasette/blob/main/.github/workflows/push_docker_tag.yml to publish the new 0.57a1 alpha to Docker Hub.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849788412 https://github.com/simonw/datasette/issues/1344#issuecomment-849788412 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTc4ODQxMg== simonw 9599 2021-05-27T16:53:28Z 2021-05-27T16:53:28Z OWNER

(Should also update https://docs.datasette.io/en/stable/contributing.html#release-process with notes on how this works)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849788159 https://github.com/simonw/datasette/issues/1344#issuecomment-849788159 https://api.github.com/repos/simonw/datasette/issues/1344 MDEyOklzc3VlQ29tbWVudDg0OTc4ODE1OQ== simonw 9599 2021-05-27T16:53:04Z 2021-05-27T16:53:04Z OWNER

I'm going to release a 0.57a1 alpha to Docker Hub using the new buildx mechanism.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Test Datasette Docker images built for different architectures 903986178  
849785098 https://github.com/simonw/datasette/pull/1319#issuecomment-849785098 https://api.github.com/repos/simonw/datasette/issues/1319 MDEyOklzc3VlQ29tbWVudDg0OTc4NTA5OA== simonw 9599 2021-05-27T16:48:21Z 2021-05-27T16:48:21Z OWNER

OK, since I have a mechanism for deploying alpha versions now I'm going to merge this and use it to publish 0.57a1.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add Docker multi-arch support with Buildx 881219362  
849784005 https://github.com/simonw/datasette/issues/1343#issuecomment-849784005 https://api.github.com/repos/simonw/datasette/issues/1343 MDEyOklzc3VlQ29tbWVudDg0OTc4NDAwNQ== simonw 9599 2021-05-27T16:46:37Z 2021-05-27T16:46:37Z OWNER

That worked: % docker run -it datasetteproject/datasette:0.57a0 Unable to find image 'datasetteproject/datasette:0.57a0' locally 0.57a0: Pulling from datasetteproject/datasette 75646c2fb410: Pull complete edf8b70d3cc4: Pull complete 229daa3ebd94: Pull complete 65d21ac50a56: Pull complete e083ad7cc3ca: Pull complete ed4de1431432: Pull complete 1da5e8b27cca: Pull complete Digest: sha256:4ab61095c1d879a91d154ed469227387356a305035da9c74542c55bd500c89db Status: Downloaded newer image for datasetteproject/datasette:0.57a0 INFO: Started server process [1] INFO: Waiting for application startup. INFO: Application startup complete. INFO: Uvicorn running on http://127.0.0.1:8001 (Press CTRL+C to quit)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Figure out how to publish alpha/beta releases to Docker Hub 903978133  
849783398 https://github.com/simonw/datasette/issues/1343#issuecomment-849783398 https://api.github.com/repos/simonw/datasette/issues/1343 MDEyOklzc3VlQ29tbWVudDg0OTc4MzM5OA== simonw 9599 2021-05-27T16:45:41Z 2021-05-27T16:45:41Z OWNER

https://hub.docker.com/r/datasetteproject/datasette/tags?page=1&ordering=last_updated now shows this at the top: https://hub.docker.com/layers/datasetteproject/datasette/0.57a0/images/sha256-4ab61095c1d879a91d154ed469227387356a305035da9c74542c55bd500c89db?context=explore

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Figure out how to publish alpha/beta releases to Docker Hub 903978133  
849782098 https://github.com/simonw/datasette/issues/1343#issuecomment-849782098 https://api.github.com/repos/simonw/datasette/issues/1343 MDEyOklzc3VlQ29tbWVudDg0OTc4MjA5OA== simonw 9599 2021-05-27T16:43:40Z 2021-05-27T16:43:55Z OWNER

https://github.com/simonw/datasette/actions/workflows/push_docker_tag.yml

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Figure out how to publish alpha/beta releases to Docker Hub 903978133  
849781747 https://github.com/simonw/datasette/issues/1343#issuecomment-849781747 https://api.github.com/repos/simonw/datasette/issues/1343 MDEyOklzc3VlQ29tbWVudDg0OTc4MTc0Nw== simonw 9599 2021-05-27T16:43:04Z 2021-05-27T16:43:04Z OWNER

I'm going to try pushing an alpha of https://github.com/simonw/datasette/releases/tag/0.57a0 using this workflow I built a few months ago: https://github.com/simonw/datasette/blob/1a8972f9c012cd22b088c6b70661a9c3d3847853/.github/workflows/push_docker_tag.yml

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Figure out how to publish alpha/beta releases to Docker Hub 903978133  
849780481 https://github.com/simonw/datasette/pull/1319#issuecomment-849780481 https://api.github.com/repos/simonw/datasette/issues/1319 MDEyOklzc3VlQ29tbWVudDg0OTc4MDQ4MQ== simonw 9599 2021-05-27T16:41:03Z 2021-05-27T16:41:03Z OWNER

It looks like all I need to do to ship an alpha version to Docker Hub is NOT point the latest tag at it after it goes live: https://github.com/simonw/datasette/blob/1a8972f9c012cd22b088c6b70661a9c3d3847853/.github/workflows/publish.yml#L75-L77

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add Docker multi-arch support with Buildx 881219362  
849778373 https://github.com/simonw/datasette/pull/1319#issuecomment-849778373 https://api.github.com/repos/simonw/datasette/issues/1319 MDEyOklzc3VlQ29tbWVudDg0OTc3ODM3Mw== simonw 9599 2021-05-27T16:37:50Z 2021-05-27T16:37:50Z OWNER

Started a conversation about this on Twitter. Ideally I'd like to push an alpha release to Docker Hub so people can start testing these out before they make it into an official non-alpha release.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add Docker multi-arch support with Buildx 881219362  
849762735 https://github.com/simonw/datasette/issues/1337#issuecomment-849762735 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTc2MjczNQ== simonw 9599 2021-05-27T16:14:14Z 2021-05-27T16:14:14Z OWNER

Here's a demo showing that once you get above 1,000 results you still get the "..." but it no longer links to anything: https://fivethirtyeight.datasettes.com/fivethirtyeight/births%2FUS_births_2000-2014_SSA?_facet=births&_facet_size=max

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
"More" link for facets that shows _facet_size=max results 898904402  
849761894 https://github.com/simonw/datasette/issues/1332#issuecomment-849761894 https://api.github.com/repos/simonw/datasette/issues/1332 MDEyOklzc3VlQ29tbWVudDg0OTc2MTg5NA== simonw 9599 2021-05-27T16:13:07Z 2021-05-27T16:13:07Z OWNER

Added ?_facet_size=max in #1337 and made the ... truncated note link to that - here's a demo: https://fivethirtyeight.datasettes.com/fivethirtyeight/antiquities-act%2Factions_under_antiquities_act?_facet=states&_facet=current_agency&_facet=pres_or_congress

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
?_facet_size=X to increase number of facets results on the page 893890496  
849761508 https://github.com/simonw/datasette/issues/1337#issuecomment-849761508 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTc2MTUwOA== simonw 9599 2021-05-27T16:12:31Z 2021-05-27T16:12:31Z OWNER

More exciting demo: https://fivethirtyeight.datasettes.com/fivethirtyeight/antiquities-act%2Factions_under_antiquities_act?_facet=states&_facet=current_agency&_facet=pres_or_congress

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
"More" link for facets that shows _facet_size=max results 898904402  
849759440 https://github.com/simonw/datasette/issues/1337#issuecomment-849759440 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTc1OTQ0MA== simonw 9599 2021-05-27T16:09:34Z 2021-05-27T16:09:34Z OWNER

Demo: https://latest.datasette.io/fixtures/facetable?_facet_size=2&_facet=state&_facet=city_id

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
"More" link for facets that shows _facet_size=max results 898904402  
849725291 https://github.com/simonw/datasette/issues/1337#issuecomment-849725291 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTcyNTI5MQ== simonw 9599 2021-05-27T15:23:33Z 2021-05-27T15:23:33Z OWNER

Turns out path_with_replaced_args() is already exposed to the table.html template context: https://github.com/simonw/datasette/blob/f1c29fd6a184254aa68efadf096bcf21e848f921/datasette/views/table.py#L897-L900

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
"More" link for facets that shows _facet_size=max results 898904402  
849724915 https://github.com/simonw/datasette/issues/1342#issuecomment-849724915 https://api.github.com/repos/simonw/datasette/issues/1342 MDEyOklzc3VlQ29tbWVudDg0OTcyNDkxNQ== simonw 9599 2021-05-27T15:23:01Z 2021-05-27T15:23:01Z OWNER

Since they are already exposed (but undocumented) this isn't actually a blocker on #1337 like I thought it was. Should still clean this up in the future though.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Improve `path_with_replaced_args()` and friends and document them 903902495  
849724108 https://github.com/simonw/datasette/issues/1342#issuecomment-849724108 https://api.github.com/repos/simonw/datasette/issues/1342 MDEyOklzc3VlQ29tbWVudDg0OTcyNDEwOA== simonw 9599 2021-05-27T15:21:54Z 2021-05-27T15:21:54Z OWNER

Turns out some of these are already being exposed to the template context on an ad-hoc basis.

In QueryView: https://github.com/simonw/datasette/blob/2bd9d54b2762c991e11950c22c88c0336158d49b/datasette/views/database.py#L295-L304

In TableView: https://github.com/simonw/datasette/blob/f1c29fd6a184254aa68efadf096bcf21e848f921/datasette/views/table.py#L897-L900

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Improve `path_with_replaced_args()` and friends and document them 903902495  
849722218 https://github.com/simonw/datasette/issues/1342#issuecomment-849722218 https://api.github.com/repos/simonw/datasette/issues/1342 MDEyOklzc3VlQ29tbWVudDg0OTcyMjIxOA== simonw 9599 2021-05-27T15:19:23Z 2021-05-27T15:19:23Z OWNER

Current implementations: https://github.com/simonw/datasette/blob/51d788114035458d8f860d9ea6d74078e6c0ea0d/datasette/utils/init.py#L214-L272

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Improve `path_with_replaced_args()` and friends and document them 903902495  
849721280 https://github.com/simonw/datasette/issues/1337#issuecomment-849721280 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTcyMTI4MA== simonw 9599 2021-05-27T15:18:08Z 2021-05-27T15:18:08Z OWNER

In order to cleanly implement this I need to expose the path_with_replaced_args utility function to Datasette's template engine. This is the first time this will become an exposed (and hence should-by-documented) API and I don't like its shape much.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
"More" link for facets that shows _facet_size=max results 898904402  
849708617 https://github.com/dogsheep/google-takeout-to-sqlite/pull/5#issuecomment-849708617 https://api.github.com/repos/dogsheep/google-takeout-to-sqlite/issues/5 MDEyOklzc3VlQ29tbWVudDg0OTcwODYxNw== maxhawkins 28565 2021-05-27T15:01:42Z 2021-05-27T15:01:42Z NONE

Any updates?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
WIP: Add Gmail takeout mbox import 813880401  
849695117 https://github.com/simonw/datasette/issues/1337#issuecomment-849695117 https://api.github.com/repos/simonw/datasette/issues/1337 MDEyOklzc3VlQ29tbWVudDg0OTY5NTExNw== simonw 9599 2021-05-27T14:44:13Z 2021-05-27T14:44:13Z OWNER

Here's a much easier way to implement this: implement ?_facet_size=max (sets it to max_returned_rows, default 1000) and then link to that from the ellipsis.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
"More" link for facets that shows _facet_size=max results 898904402  
849313380 https://github.com/simonw/datasette/pull/1319#issuecomment-849313380 https://api.github.com/repos/simonw/datasette/issues/1319 MDEyOklzc3VlQ29tbWVudDg0OTMxMzM4MA== codecov[bot] 22429695 2021-05-27T04:38:44Z 2021-05-27T04:38:44Z NONE

Codecov Report

Merging #1319 (cfca570) into main (1b69753) will increase coverage by 0.02%. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1319 +/-

========================================== + Coverage 91.51% 91.53% +0.02%
========================================== Files 34 34
Lines 4255 4255
========================================== + Hits 3894 3895 +1
+ Misses 361 360 -1
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/utils/__init__.py | 94.31% <0.00%> (+0.17%) | :arrow_up: |


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b69753...cfca570. Read the comment docs.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add Docker multi-arch support with Buildx 881219362  
849311884 https://github.com/simonw/datasette/pull/1319#issuecomment-849311884 https://api.github.com/repos/simonw/datasette/issues/1319 MDEyOklzc3VlQ29tbWVudDg0OTMxMTg4NA== simonw 9599 2021-05-27T04:33:51Z 2021-05-27T04:33:51Z OWNER

This is so cool! I wonder how I can best test it? I have a Raspberry Pi I should dig out to try this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add Docker multi-arch support with Buildx 881219362  
849310294 https://github.com/simonw/datasette/issues/1341#issuecomment-849310294 https://api.github.com/repos/simonw/datasette/issues/1341 MDEyOklzc3VlQ29tbWVudDg0OTMxMDI5NA== simonw 9599 2021-05-27T04:29:04Z 2021-05-27T04:29:04Z OWNER

For implementation simplicity I'm going to show the item even if all of the columns are visible because ?_col= has selected all of them - selecting it will still reset the view to having no ?_col= or ?_nocol= parameters.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
"Show all columns" cog menu item should show if ?_col= is used 903200328  
849309330 https://github.com/simonw/datasette/issues/615#issuecomment-849309330 https://api.github.com/repos/simonw/datasette/issues/615 MDEyOklzc3VlQ29tbWVudDg0OTMwOTMzMA== simonw 9599 2021-05-27T04:26:10Z 2021-05-27T04:26:10Z OWNER

Demos:

  • https://latest.datasette.io/fixtures/sortable?_nocol=sortable
  • https://latest.datasette.io/fixtures/sortable?_col=sortable&_col=text

Also try the column cog menu on that page.

Documentation: https://docs.datasette.io/en/latest/json_api.html#special-table-arguments

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
?_col= and ?_nocol= support for toggling columns on table view 517451234  
849308907 https://github.com/simonw/datasette/issues/292#issuecomment-849308907 https://api.github.com/repos/simonw/datasette/issues/292 MDEyOklzc3VlQ29tbWVudDg0OTMwODkwNw== simonw 9599 2021-05-27T04:25:01Z 2021-05-27T04:25:01Z OWNER

Now that ?_col= and ?_nocol= are implemented I'm closing this ticket - other customizations can already be handled by defining SQL views or creating canned SQL queries.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Mechanism for customizing the SQL used to select specific columns in the table view 326800219  
847207804 https://github.com/simonw/datasette/pull/1339#issuecomment-847207804 https://api.github.com/repos/simonw/datasette/issues/1339 MDEyOklzc3VlQ29tbWVudDg0NzIwNzgwNA== codecov[bot] 22429695 2021-05-24T17:22:13Z 2021-05-27T04:14:21Z NONE

Codecov Report

Merging #1339 (3d8598b) into main (a443dba) will increase coverage by 0.01%. The diff coverage is 91.66%.

:exclamation: Current head 3d8598b differs from pull request most recent head 387c837. Consider uploading reports for the commit 387c837 to get more accurate results

```diff @@ Coverage Diff @@

main #1339 +/-

========================================== + Coverage 91.55% 91.56% +0.01%
========================================== Files 34 34
Lines 4262 4280 +18
========================================== + Hits 3902 3919 +17
- Misses 360 361 +1
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/views/table.py | 95.83% <90.00%> (-0.05%) | :arrow_down: | | datasette/app.py | 95.84% <100.00%> (-0.01%) | :arrow_down: | | datasette/views/database.py | 97.19% <100.00%> (ø) | |


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a443dba...387c837. Read the comment docs.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
?_col=/?_nocol= to show/hide columns on the table page 899851083  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 1528.428ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows