home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

7 rows where "updated_at" is on date 2021-07-30 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

issue 3

  • Tests failing with FileNotFoundError in runner.isolated_filesystem 5
  • Share button for copying current URL 1
  • Documentation on using Datasette as a library 1

user 2

  • simonw 6
  • aitoehigie 1

author_association 2

  • OWNER 6
  • NONE 1
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
889599513 https://github.com/simonw/datasette/issues/1398#issuecomment-889599513 https://api.github.com/repos/simonw/datasette/issues/1398 IC_kwDOBm6k_c41BjYZ aitoehigie 192984 2021-07-30T03:21:49Z 2021-07-30T03:21:49Z NONE

Does the library support this now?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Documentation on using Datasette as a library 947044667  
889555977 https://github.com/simonw/datasette/issues/1406#issuecomment-889555977 https://api.github.com/repos/simonw/datasette/issues/1406 IC_kwDOBm6k_c41BYwJ simonw 9599 2021-07-30T01:06:57Z 2021-07-30T01:06:57Z OWNER

Looking at the source code in Click for isolated_filesystem(): https://github.com/pallets/click/blob/9da166957f5848b641231d485467f6140bca2bc0/src/click/testing.py#L450-L468

python @contextlib.contextmanager def isolated_filesystem( self, temp_dir: t.Optional[t.Union[str, os.PathLike]] = None ) -> t.Iterator[str]: """A context manager that creates a temporary directory and changes the current working directory to it. This isolates tests that affect the contents of the CWD to prevent them from interfering with each other. :param temp_dir: Create the temporary directory under this directory. If given, the created directory is not removed when exiting. .. versionchanged:: 8.0 Added the ``temp_dir`` parameter. """ cwd = os.getcwd() t = tempfile.mkdtemp(dir=temp_dir) os.chdir(t) How about if I pass in that optional temp_dir as a temp directory created using the pytest-xdist aware pytest mechanisms: https://docs.pytest.org/en/6.2.x/tmpdir.html

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Tests failing with FileNotFoundError in runner.isolated_filesystem 956303470  
889553052 https://github.com/simonw/datasette/issues/1406#issuecomment-889553052 https://api.github.com/repos/simonw/datasette/issues/1406 IC_kwDOBm6k_c41BYCc simonw 9599 2021-07-30T00:58:43Z 2021-07-30T00:58:43Z OWNER

Tests are still failing in the job that calculates coverage.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Tests failing with FileNotFoundError in runner.isolated_filesystem 956303470  
889550391 https://github.com/simonw/datasette/issues/1406#issuecomment-889550391 https://api.github.com/repos/simonw/datasette/issues/1406 IC_kwDOBm6k_c41BXY3 simonw 9599 2021-07-30T00:49:31Z 2021-07-30T00:49:31Z OWNER

That fixed it. My hunch is that Click's runner.isolated_filesystem() mechanism doesn't play well with pytest-xdist.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Tests failing with FileNotFoundError in runner.isolated_filesystem 956303470  
889548536 https://github.com/simonw/datasette/issues/1406#issuecomment-889548536 https://api.github.com/repos/simonw/datasette/issues/1406 IC_kwDOBm6k_c41BW74 simonw 9599 2021-07-30T00:43:47Z 2021-07-30T00:43:47Z OWNER

Still couldn't replicate on my laptop. On a hunch, I'm going to add @pytest.mark.serial to every test that uses runner.isolated_filesystem().

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Tests failing with FileNotFoundError in runner.isolated_filesystem 956303470  
889547142 https://github.com/simonw/datasette/issues/1406#issuecomment-889547142 https://api.github.com/repos/simonw/datasette/issues/1406 IC_kwDOBm6k_c41BWmG simonw 9599 2021-07-30T00:39:49Z 2021-07-30T00:39:49Z OWNER

It happens in CI but not on my laptop. I think I need to run the tests on my laptop like this: https://github.com/simonw/datasette/blob/121e10c29c5b412fddf0326939f1fe46c3ad9d4a/.github/workflows/test.yml#L27-L30

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Tests failing with FileNotFoundError in runner.isolated_filesystem 956303470  
889539227 https://github.com/simonw/datasette/issues/1241#issuecomment-889539227 https://api.github.com/repos/simonw/datasette/issues/1241 IC_kwDOBm6k_c41BUqb simonw 9599 2021-07-30T00:15:26Z 2021-07-30T00:15:26Z OWNER

One possible treatment:

```html

<style> a.action-button { display: inline-block; border: 1.5px solid #666; border-radius: 0.5em; background-color: #ffffff; color: #666; padding: 0.1em 0.8em; text-decoration: none; margin-right: 0.3em; font-size: 0.85em; } </style>

{% if query.sql and allow_execute_sql %} View and edit SQL {% endif %} Copy and share link

```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Share button for copying current URL 814595021  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 536.157ms · About: github-to-sqlite