issue_comments

Table actions

8 rows where "updated_at" is on date 2022-01-19 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 2

author_association 2

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1016977725 https://github.com/simonw/datasette/issues/1605#issuecomment-1016977725 https://api.github.com/repos/simonw/datasette/issues/1605 IC_kwDOBm6k_c48ndk9 simonw 9599 2022-01-19T23:55:08Z 2022-01-19T23:55:08Z OWNER

Oh that's interesting. I was thinking about this from a slightly different angle recently - pondering what a static site generator built on top of Datasette might look like.

Just a sketch at the moment, but I was imagining a YAML configuration file with a SQL query that returns a list of paths - then a tool that runs that query and uses the equivalent of datasette --get to create a static copy of each of those paths.

I think these two ideas can probably be merged. I'd love to know more about how you are solving this right now!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Scripted exports 1108671952  
1016651485 https://github.com/simonw/datasette/issues/1601#issuecomment-1016651485 https://api.github.com/repos/simonw/datasette/issues/1601 IC_kwDOBm6k_c48mN7d eyeseast 25778 2022-01-19T16:39:03Z 2022-01-19T16:39:03Z CONTRIBUTOR

I think both of these are Spatialite specific. They get generated when you first initialize the extension. KNN is actually deprecated in favor of KNN2, as I understand it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add KNN and data_licenses to hidden tables list 1105916061  
1016637722 https://github.com/simonw/datasette/issues/1601#issuecomment-1016637722 https://api.github.com/repos/simonw/datasette/issues/1601 IC_kwDOBm6k_c48mKka simonw 9599 2022-01-19T16:25:07Z 2022-01-19T16:25:07Z OWNER

Good idea - though I'm nervous about accidentally hiding a data_licenses table outside of the SpatiaLite case. I'll only hide that one if SpatiaLite is loaded.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add KNN and data_licenses to hidden tables list 1105916061  
1016636561 https://github.com/simonw/datasette/issues/1604#issuecomment-1016636561 https://api.github.com/repos/simonw/datasette/issues/1604 IC_kwDOBm6k_c48mKSR simonw 9599 2022-01-19T16:23:54Z 2022-01-19T16:23:54Z OWNER

Potential design:

datasette publish cloudrun data.db \
  --service my-service \
  --domain demo.datasette.io

I think I'm OK with calling this --domain even when it is being used with a subdomain.

This will require datasette.io to already have been verified with Google.

Not sure how best to handle the DNS part - maybe print out instructions for the necessary CNAME?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Option to assign a domain/subdomain using `datasette publish cloudrun` 1108300685  
1016589519 https://github.com/simonw/datasette/issues/1603#issuecomment-1016589519 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48l-zP simonw 9599 2022-01-19T15:36:38Z 2022-01-19T15:36:38Z OWNER

Also people can use a custom base template and link to a custom favicon if they want to.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 A proper favicon 1108235694  
1016589140 https://github.com/simonw/datasette/issues/1603#issuecomment-1016589140 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48l-tU simonw 9599 2022-01-19T15:36:16Z 2022-01-19T15:36:16Z OWNER

For the moment then I will hard-code a new favicon and leave it to ASGI plugins if people want to define their own.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 A proper favicon 1108235694  
1016588326 https://github.com/simonw/datasette/issues/1603#issuecomment-1016588326 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48l-gm simonw 9599 2022-01-19T15:35:33Z 2022-01-19T15:35:33Z OWNER

I don't think abusing the template loader mechanism for this will work: Jinja provides an API for loading text templates, but I don't think it can be sensibly abused to open binary image files instead. Loaded code is here: https://github.com/pallets/jinja/blob/main/src/jinja2/loaders.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 A proper favicon 1108235694  
1016579661 https://github.com/simonw/datasette/issues/1603#issuecomment-1016579661 https://api.github.com/repos/simonw/datasette/issues/1603 IC_kwDOBm6k_c48l8ZN simonw 9599 2022-01-19T15:27:05Z 2022-01-19T15:27:05Z OWNER

I'd like this to be customizable. I'm going to load it from the template loading system such that a custom favicon for a specific instance can be dropped in using a file in templates/.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 A proper favicon 1108235694  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);