issue_comments

Now live here: https://docs.datasette.io/en/latest/changelog.html#v0-62

I'm not going to write annotated release notes for this one. I think the existing release notes are detailed enough, and the most exciting parts of this release relate to Datasette Lite which I have already written about extensively (and linked from the new release notes).

Tested that with:

datasette publish cloudrun fixtures.db --service issue-1779 --min-instances 2 --max-instances 4

Here's the start of the man page for gcloud run deploy: ``` NAME gcloud run deploy - deploy a container to Cloud Run

SYNOPSIS gcloud run deploy [[SERVICE] --namespace=NAMESPACE] [--args=[ARG,...]] [--async] [--command=[COMMAND,...]] [--concurrency=CONCURRENCY] [--cpu=CPU] [--ingress=INGRESS; default="all"] [--max-instances=MAX_INSTANCES] [--memory=MEMORY] [--min-instances=MIN_INSTANCES] `` I'm going to expose--max-instancesand--min-instancesas extra option todatasette publish cloudrun`.

(I deleted my issue-1779 project using the UI at https://console.cloud.google.com/run?project=datasette-222320)

Just tried this instead, and it still worked and deployed OK:

datasette publish cloudrun fixtures.db --memory 16Gi --cpu 4 --service issue-1779

@fgregg I'm not able to replicate your deployment failure I'm afraid.

Just spotted this in the failing Actions workflow:

gcloud config set run/region us-central1

I tried that locally too but the deploy still succeeds.

datasette publish cloudrun fixtures.db --memory 8Gi --cpu 2 --service issue-1779 still works.

Maybe I need to upgrade: % gcloud --version Google Cloud SDK 378.0.0 alpha 2022.03.18 bq 2.0.74 core 2022.03.18 gsutil 5.8 Updates are available for some Google Cloud CLI components. To install them, please run: $ gcloud components update ``` % gcloud components update Beginning update. This process may take several minutes.

Your current Google Cloud CLI version is: 378.0.0 You will be upgraded to version: 397.0.0

┌─────────────────────────────────────────────────────────────────────────────┐ │ These components will be updated. │ ├─────────────────────────────────────────────────────┬────────────┬──────────┤ │ Name │ Version │ Size │ ├─────────────────────────────────────────────────────┼────────────┼──────────┤ │ BigQuery Command Line Tool │ 2.0.75 │ 1.6 MiB │ │ BigQuery Command Line Tool (Platform Specific) │ 2.0.75 │ < 1 MiB │ │ Cloud Storage Command Line Tool │ 5.11 │ 15.5 MiB │ │ Cloud Storage Command Line Tool (Platform Specific) │ 5.11 │ < 1 MiB │ │ Google Cloud CLI Core Libraries │ 2022.08.05 │ 24.3 MiB │ │ Google Cloud CLI Core Libraries (Platform Specific) │ 2022.08.05 │ < 1 MiB │ │ anthoscli │ 0.2.28 │ 48.0 MiB │ │ gcloud Alpha Commands │ 2022.08.05 │ < 1 MiB │ │ gcloud cli dependencies │ 2022.07.29 │ 11.2 MiB │ └─────────────────────────────────────────────────────┴────────────┴──────────┘

A lot has changed since your last upgrade. For the latest full release notes, please visit: https://cloud.google.com/sdk/release_notes % gcloud --version
Google Cloud SDK 397.0.0 alpha 2022.08.05 bq 2.0.75 core 2022.08.05 gsutil 5.11 ```

Tried duplicating this error locally but the following command succeeded when I expected it to fail:

datasette publish cloudrun fixtures.db --memory 8Gi --cpu 2 --service issue-1779

Here's the relevant part of the datasette publish command from that failed Actions workflow: datasette publish cloudrun f7.db nlrb.db opdr.db old_nlrb.db voluntary_recognitions.db work_stoppages.db lm20.db chips.db \ --memory 8Gi \ --cpu 2

Actually I disagree that Datasette isn't setup to make use of container scaling: part of the idea behind the Baked Data pattern is that you can scale to handle effectively unlimited traffic by running multiple copies of your application, each with their own duplicate copy of the database.

So I'm going to default maxScale to 10 and still let people customize it.

I'm going to default maxscale to 2 but provide an extra command line option for datasette publish cloudrun which lets people set it to something higher if they want to.

Here's what it looks like:

I put the disabled attribute on the form submission button too. There's no visible difference in how that button is displayed but since this is only a state that should be seen by the developer I think that's OK, especially combined with the warning at the top of the page.

Decision: I'm going to implement this:

Don't allow the user to even submit the form - show a message saying that this canned query is unavailable because the database cannot be written to

That fixed both bugs.

This isn't just a mobile display issue.

https://latest.datasette.io/fixtures/compound_three_primary_keys?_sort_desc=pk1 - click "Apply" and each time it adds another ?_sort_desc=pk1 to the URL.

This doesn't happen for ?_sort=pk - only for ?_sort_desc=pk1: https://latest.datasette.io/fixtures/compound_three_primary_keys?_sort=pk1

https://latest.datasette.io/fixtures/sortable?_sort_desc=sortable&_col=sortable_with_nulls works now.

Also trying this locally:

datasette publish cloudrun fixtures.db --service issue-1768

https://issue-1768-j7hipcg4aq-uc.a.run.app/-/versions

Tested locally with:

datasette package fixtures.db --extra-options="--setting sql_time_limit_ms 2500" \
  -t datasette-package-python-upgrade

And then:

docker run -p 8081:8001 datasette-package-python-upgrade INFO: Started server process [8] INFO: Waiting for application startup. INFO: Application startup complete. INFO: Uvicorn running on http://0.0.0.0:8001 (Press CTRL+C to quit)

https://hub.docker.com/layers/python/library/python/3.10.6-slim-bullseye/images/sha256-cf85cd32e60184a94d88a0103c289d09024abffaa77680d116d7cc837668ea15?context=explore is the most recent - 3.10.6-slim-bullseye.

I've tested this with datasette-sentry and it works well.

I'm going to promote it here too: https://docs.datasette.io/en/latest/getting_started.html