issue_comments

Table actions

10 rows where "updated_at" is on date 2022-12-17 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • simonw · 10 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1356489200 https://github.com/simonw/datasette/issues/1955#issuecomment-1356489200 https://api.github.com/repos/simonw/datasette/issues/1955 IC_kwDOBm6k_c5Q2mHw simonw 9599 2022-12-17T22:29:51Z 2022-12-17T22:29:51Z OWNER

No, it still causes the tests to hang (I let them run for 12 minutes):

Interesting that the regular tests passed an then the pytest -m serial ones seem to have failed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 invoke_startup() is not run in some conditions, e.g. gunicorn/uvicorn workers, breaking lots of things 1496652622  
1356487139 https://github.com/simonw/datasette/issues/1955#issuecomment-1356487139 https://api.github.com/repos/simonw/datasette/issues/1955 IC_kwDOBm6k_c5Q2lnj simonw 9599 2022-12-17T22:16:52Z 2022-12-17T22:16:52Z OWNER

I'm trying this fix again, after a bunch of work on the test suite in: - #1959

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 invoke_startup() is not run in some conditions, e.g. gunicorn/uvicorn workers, breaking lots of things 1496652622  
1356481595 https://github.com/simonw/datasette/issues/1843#issuecomment-1356481595 https://api.github.com/repos/simonw/datasette/issues/1843 IC_kwDOBm6k_c5Q2kQ7 simonw 9599 2022-12-17T22:02:40Z 2022-12-17T22:02:40Z OWNER

This is interesting:

python import resource print(resource.getrlimit(resource.RLIMIT_NOFILE)) On Mac: ```pycon

print(resource.getrlimit(resource.RLIMIT_NOFILE)) (256, 9223372036854775807) On Ubuntu (in a Docker `ubuntu:22.04` container):pycon resource.getrlimit(resource.RLIMIT_NOFILE) (1048576, 1048576) ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Intermittent "Too many open files" error running tests 1408757705  
1356480256 https://github.com/simonw/datasette/issues/1843#issuecomment-1356480256 https://api.github.com/repos/simonw/datasette/issues/1843 IC_kwDOBm6k_c5Q2j8A simonw 9599 2022-12-17T22:01:13Z 2022-12-17T22:01:13Z OWNER

The refactor in the following issue did NOT prevent this error from occurring when I try to run the full pytest suite on my Mac laptop:

  • 1959

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Intermittent "Too many open files" error running tests 1408757705  
1356478792 https://github.com/simonw/datasette/issues/1959#issuecomment-1356478792 https://api.github.com/repos/simonw/datasette/issues/1959 IC_kwDOBm6k_c5Q2jlI simonw 9599 2022-12-17T21:49:36Z 2022-12-17T21:49:36Z OWNER

Made a really good start on this in the just-merged PR: - #1960

The follow-up work will happen in: - #1962

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor test suite to use mostly `async def` tests 1499081664  
1356478575 https://github.com/simonw/datasette/pull/1960#issuecomment-1356478575 https://api.github.com/repos/simonw/datasette/issues/1960 IC_kwDOBm6k_c5Q2jhv simonw 9599 2022-12-17T21:47:48Z 2022-12-17T21:47:48Z OWNER

Stick a twig in it, this will do for the moment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Port as many tests as possible to async def tests against ds_client 1499150951  
1356476886 https://github.com/simonw/datasette/pull/1960#issuecomment-1356476886 https://api.github.com/repos/simonw/datasette/issues/1960 IC_kwDOBm6k_c5Q2jHW simonw 9599 2022-12-17T21:37:05Z 2022-12-17T21:37:05Z OWNER

I think this test may be to blame:

https://github.com/simonw/datasette/blob/5ee954e34b6eb762ccecbdb2be0791d0166fd19c/tests/test_plugins.py#L950-L972

It's over-riding _metadata_local and then failing to set it back to original in a finally: block at the end.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Port as many tests as possible to async def tests against ds_client 1499150951  
1356476583 https://github.com/simonw/datasette/pull/1960#issuecomment-1356476583 https://api.github.com/repos/simonw/datasette/issues/1960 IC_kwDOBm6k_c5Q2jCn simonw 9599 2022-12-17T21:34:51Z 2022-12-17T21:34:51Z OWNER

These are all the places that tests touch _metadata_local at the moment: ``` (venv) root@76a81d2417f5:/tmp/datasette/tests# rg _metadata_local
test_facets.py 596: ds._metadata_local = { 605: ds._metadata_local["databases"]["test_facet_size"]["tables"]["neighbourhoods"][

test_permissions.py 62: padlock_client.ds._metadata_local["allow"] = allow 77: del padlock_client.ds._metadata_local["allow"] 522: cascade_app_client.ds._metadata_local = updated_metadata 533: cascade_app_client.ds._metadata_local = previous_metadata 549: previous_metadata = cascade_app_client.ds._metadata_local 551: cascade_app_client.ds._metadata_local = metadata 566: cascade_app_client.ds._metadata_local = previous_metadata 842: perms_ds._metadata_local = updated_metadata 849: perms_ds._metadata_local = previous_metadata

test_html.py 1114: orig = ds_client.ds._metadata_local 1115: ds_client.ds._metadata_local = metadata 1123: ds_client.ds._metadata_local = orig

test_plugins.py 1034: ds_client.ds._metadata_local = { ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Port as many tests as possible to async def tests against ds_client 1499150951  
1356056018 https://github.com/simonw/datasette/pull/1960#issuecomment-1356056018 https://api.github.com/repos/simonw/datasette/issues/1960 IC_kwDOBm6k_c5Q08XS simonw 9599 2022-12-17T05:33:26Z 2022-12-17T05:33:26Z OWNER

I think I've found the problem. The failing test is this one:

paginated_view.json-201-9

That's this example:

https://github.com/simonw/datasette/blob/cede1efeedbc3d928397d53d5a1611eecc598fde/tests/test_table_api.py#L179-L180

Why is it expected to take 9 pages and not 5, when the definition of that view is this:

sql CREATE VIEW paginated_view AS SELECT content, '- ' || content || ' -' AS content_extra FROM no_primary_key; Because paginated_view has extra configuration in metadata.json:

https://github.com/simonw/datasette/blob/5ee954e34b6eb762ccecbdb2be0791d0166fd19c/tests/fixtures.py#L357

So this test is showing that metadata can be used to set an alternative page size for a view.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Port as many tests as possible to async def tests against ds_client 1499150951  
1356038242 https://github.com/simonw/datasette/pull/1960#issuecomment-1356038242 https://api.github.com/repos/simonw/datasette/issues/1960 IC_kwDOBm6k_c5Q04Bi simonw 9599 2022-12-17T04:56:22Z 2022-12-17T04:57:04Z OWNER

May have spotted the problem with that test_paginate_tables_and_views test:

(Pdb) path, expected_rows, expected_pages (None, 201, 9) path should not be None here:

https://github.com/simonw/datasette/blob/cede1efeedbc3d928397d53d5a1611eecc598fde/tests/test_table_api.py#L175-L212

No that's not it either - path is reassigned on purpose.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Port as many tests as possible to async def tests against ds_client 1499150951  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);