issue_comments

Table actions

14 rows where "updated_at" is on date 2023-08-07 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

author_association 3

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1668720671 https://github.com/simonw/datasette/pull/2118#issuecomment-1668720671 https://api.github.com/repos/simonw/datasette/issues/2118 IC_kwDOBm6k_c5jdqgf simonw 9599 2023-08-07T23:58:21Z 2023-08-07T23:58:21Z OWNER

11 tests left: FAILED tests/test_html.py::test_alternate_url_json[/fixtures-http://localhost/fixtures.json] - KeyError: 'link' FAILED tests/test_html.py::test_alternate_url_json[/fixtures?sql=select+*+from+facetable-http://localhost/fixtures.json?sql=select+*+from+facetable] - assert '<link rel="alternate" type="application/json+datasette" href="http://localhost/fixtures.json?sql=select+*+from+facetable">' in '<!DOCTYPE html>\n<html>\n<head>\n <title>fixtures: select * from... FAILED tests/test_html.py::test_query_page_truncates - assert equals failed FAILED tests/test_html.py::test_templates_considered[/fixtures-database-fixtures.html, *database.html] - assert '<!-- Templates considered: database-fixtures.html, *database.html -->' in '<!DOCTYPE html>\n<html>\n<head>\n <title>fixtures</title>\n <link rel="stylesheet" href="/-/static/app.css?d599...... FAILED tests/test_html.py::test_query_json_csv_export_links - assert '<a href="/fixtures.csv?sql=select+1&_size=max">CSV</a>' in '<!DOCTYPE html>\n<html>\n<head>\n <title>fixtures: select 1</title>\n <link rel="stylesheet" href="/-/static/ap...se"}, "view... FAILED tests/test_plugins.py::test_hook_extra_css_urls[/fixtures-expected_decoded_object1] - AssertionError: assert equals failed FAILED tests/test_api.py::test_cors[/fixtures.json?sql=select+blah-400] - KeyError: 'Access-Control-Allow-Origin' FAILED tests/test_plugins.py::test_hook_extra_body_script[/fixtures-expected_extra_body_script1] - AssertionError: assert equals failed FAILED tests/test_table_api.py::test_max_returned_rows - KeyError: 'query' FAILED tests/test_plugins.py::test_view_names[/fixtures-database] - AssertionError: assert equals failed FAILED tests/test_plugins.py::test_view_names[/fixtures?sql=select+1-database] - AssertionError: assert equals failed ======================================================================= 11 failed, 1301 passed, 2 skipped, 1 xfailed in 64.10s (0:01:04) =======================================================================

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New JSON design for query views 1823352380  
1668695958 https://github.com/simonw/datasette/issues/2130#issuecomment-1668695958 https://api.github.com/repos/simonw/datasette/issues/2130 IC_kwDOBm6k_c5jdkeW simonw 9599 2023-08-07T23:21:07Z 2023-08-07T23:21:16Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Render plugin mechanism needs `error` and `truncated` fields 1840329615  
1668691898 https://github.com/simonw/datasette/pull/2118#issuecomment-1668691898 https://api.github.com/repos/simonw/datasette/issues/2118 IC_kwDOBm6k_c5jdje6 simonw 9599 2023-08-07T23:15:14Z 2023-08-07T23:16:28Z OWNER

New error design: json {"ok": false, "error": "Error message here", "rows": [], "columns": [], "truncated": false} I guess that means I need to add "ok": true to the default format as well - which makes sense because table JSON has that already:

https://latest.datasette.io/fixtures/facetable.json

json { "ok": true, "next": null, "rows": [...] }

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New JSON design for query views 1823352380  
1668687891 https://github.com/simonw/datasette/pull/2118#issuecomment-1668687891 https://api.github.com/repos/simonw/datasette/issues/2118 IC_kwDOBm6k_c5jdigT simonw 9599 2023-08-07T23:11:04Z 2023-08-07T23:14:34Z OWNER

One of the failing tests is because this URL on my local environment returns this:

http://127.0.0.1:8001/_memory.json?sql=select+blah json {"rows": [], "columns": [], "truncated": false} With a 200 status code. It should be an error.

https://latest.datasette.io/_memory.json?sql=select+blah returns a 400 status code with the following JSON:

json { "ok": false, "database": "_memory", "query_name": null, "rows": [], "truncated": false, "columns": [], "query": { "sql": "select blah", "params": {} }, "error": "no such column: blah", "private": false, "allow_execute_sql": true, "query_ms": 2.68310698447749, "source": "tests/fixtures.py", "source_url": "https://github.com/simonw/datasette/blob/main/tests/fixtures.py", "license": "Apache License 2.0", "license_url": "https://github.com/simonw/datasette/blob/main/LICENSE" } So I need a design for what this should look like for the error case.

I should consider what errors look like for alternative formats too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New JSON design for query views 1823352380  
1668690232 https://github.com/simonw/datasette/issues/2129#issuecomment-1668690232 https://api.github.com/repos/simonw/datasette/issues/2129 IC_kwDOBm6k_c5jdjE4 simonw 9599 2023-08-07T23:13:24Z 2023-08-07T23:13:24Z OWNER

This may end up being a renderer plugin hook design question too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 CSV ?sql= should indicate errors 1840324765  
1668688947 https://github.com/simonw/datasette/pull/2118#issuecomment-1668688947 https://api.github.com/repos/simonw/datasette/issues/2118 IC_kwDOBm6k_c5jdiwz simonw 9599 2023-08-07T23:12:37Z 2023-08-07T23:12:37Z OWNER

https://latest.datasette.io/_memory.csv?sql=select+blah is a blank page right now:

bash curl -I 'https://latest.datasette.io/_memory.csv?sql=select+blah' HTTP/2 200 access-control-allow-origin: * access-control-allow-headers: Authorization, Content-Type access-control-expose-headers: Link access-control-allow-methods: GET, POST, HEAD, OPTIONS access-control-max-age: 3600 content-type: text/plain; charset=utf-8 x-databases: _memory, _internal, fixtures, fixtures2, extra_database, ephemeral date: Mon, 07 Aug 2023 23:12:15 GMT server: Google Frontend

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New JSON design for query views 1823352380  
1668578107 https://github.com/simonw/datasette/pull/2118#issuecomment-1668578107 https://api.github.com/repos/simonw/datasette/issues/2118 IC_kwDOBm6k_c5jdHs7 simonw 9599 2023-08-07T21:06:50Z 2023-08-07T21:06:50Z OWNER

15: =========================================================================================== short test summary info ============================================================================================ FAILED tests/test_cli.py::test_sql_errors_logged_to_stderr - assert 0 == 1 FAILED tests/test_html.py::test_show_hide_sql_query - AssertionError: assert False FAILED tests/test_canned_queries.py::test_magic_parameters_cannot_be_used_in_arbitrary_queries - assert 400 == 200 FAILED tests/test_html.py::test_templates_considered[/fixtures-database-fixtures.html, *database.html] - assert '<!-- Templates considered: database-fixtures.html, *database.html -->' in '<!DOCTYPE html>\n<html>\n<head>\n <title>fixtures</title>\n <link rel="stylesheet" href="/-/static/app.css?d599...... FAILED tests/test_html.py::test_query_json_csv_export_links - assert '<a href="/fixtures.csv?sql=select+1&_size=max">CSV</a>' in '<!DOCTYPE html>\n<html>\n<head>\n <title>fixtures: select 1</title>\n <link rel="stylesheet" href="/-/static/ap...se"}, "view... FAILED tests/test_html.py::test_base_url_config[True-/fixtures?sql=select+1] - AssertionError: { FAILED tests/test_api.py::test_cors[/fixtures.json?sql=select+blah-400] - assert 200 == 400 FAILED tests/test_html.py::test_alternate_url_json[/fixtures?sql=select+*+from+facetable-http://localhost/fixtures.json?sql=select+*+from+facetable] - assert '<link rel="alternate" type="application/json+datasette" href="http://localhost/fixtures.json?sql=select+*+from+facetable">' in '<!DOCTYPE html>\n<html>\n<head>\n <title>fixtures: select * from... FAILED tests/test_plugins.py::test_hook_extra_css_urls[/fixtures-expected_decoded_object1] - AssertionError: assert equals failed FAILED tests/test_plugins.py::test_view_names[/fixtures-database] - AssertionError: assert equals failed FAILED tests/test_plugins.py::test_view_names[/fixtures?sql=select+1-database] - AssertionError: assert equals failed FAILED tests/test_plugins.py::test_hook_extra_body_script[/fixtures-expected_extra_body_script1] - AssertionError: assert equals failed FAILED tests/test_html.py::test_base_url_config[False-/fixtures?sql=select+1] - AssertionError: { FAILED tests/test_table_api.py::test_max_returned_rows - KeyError: 'query' FAILED tests/test_html.py::test_alternate_url_json[/fixtures-http://localhost/fixtures.json] - KeyError: 'link' ============================================================================ 15 failed, 1297 passed, 2 skipped, 1 xfailed in 58.15s ============================================================================

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New JSON design for query views 1823352380  
1668568445 https://github.com/simonw/datasette/pull/2118#issuecomment-1668568445 https://api.github.com/repos/simonw/datasette/issues/2118 IC_kwDOBm6k_c5jdFV9 simonw 9599 2023-08-07T20:57:46Z 2023-08-07T20:57:46Z OWNER

17 failing tests now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 New JSON design for query views 1823352380  
1668187546 https://github.com/simonw/datasette/pull/2125#issuecomment-1668187546 https://api.github.com/repos/simonw/datasette/issues/2125 IC_kwDOBm6k_c5jboWa dependabot[bot] 49699333 2023-08-07T16:20:26Z 2023-08-07T16:20:26Z CONTRIBUTOR

Looks like sphinx is up-to-date now, so this is no longer needed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx from 6.1.3 to 7.1.2 1833193570  
1668186872 https://github.com/simonw/datasette/pull/2121#issuecomment-1668186872 https://api.github.com/repos/simonw/datasette/issues/2121 IC_kwDOBm6k_c5jboL4 dependabot[bot] 49699333 2023-08-07T16:20:19Z 2023-08-07T16:20:19Z CONTRIBUTOR

Looks like furo is up-to-date now, so this is no longer needed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump furo from 2023.3.27 to 2023.7.26 1824399610  
1668186815 https://github.com/simonw/datasette/pull/2098#issuecomment-1668186815 https://api.github.com/repos/simonw/datasette/issues/2098 IC_kwDOBm6k_c5jboK_ dependabot[bot] 49699333 2023-08-07T16:20:18Z 2023-08-07T16:20:18Z CONTRIBUTOR

Looks like blacken-docs is up-to-date now, so this is no longer needed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump blacken-docs from 1.14.0 to 1.15.0 1796830110  
1668143992 https://github.com/simonw/datasette/pull/2128#issuecomment-1668143992 https://api.github.com/repos/simonw/datasette/issues/2128 IC_kwDOBm6k_c5jbdt4 codecov[bot] 22429695 2023-08-07T15:58:08Z 2023-08-07T15:58:08Z NONE

Codecov Report

Patch and project coverage have no change.

Comparison is base (adf54f5) 92.38% compared to head (935d336) 92.38%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2128 +/- ## ======================================= Coverage 92.38% 92.38% ======================================= Files 39 39 Lines 5803 5803 ======================================= Hits 5361 5361 Misses 442 442 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump blacken-docs, furo, blacken-docs 1839766197  
1668113177 https://github.com/simonw/sqlite-utils/issues/578#issuecomment-1668113177 https://api.github.com/repos/simonw/sqlite-utils/issues/578 IC_kwDOCGYnMM5jbWMZ eyeseast 25778 2023-08-07T15:41:49Z 2023-08-07T15:41:49Z CONTRIBUTOR

I wonder if this should be two hooks: input and output. The current --csv (and --tsv) options apply to both. Haven't looked at how it's implemented. Or maybe it's one hook that returns a format for reading and for writing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plugin hook for adding new output formats 1818838294  
1667011607 https://github.com/simonw/datasette/issues/2127#issuecomment-1667011607 https://api.github.com/repos/simonw/datasette/issues/2127 IC_kwDOBm6k_c5jXJQX simonw 9599 2023-08-07T00:02:49Z 2023-08-07T00:02:49Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Context base class to support documenting the context 1838469176  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);