issue_comments

Table actions

7 rows where "updated_at" is on date 2023-08-28 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

author_association 3

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1696378239 https://github.com/simonw/datasette/issues/2102#issuecomment-1696378239 https://api.github.com/repos/simonw/datasette/issues/2102 IC_kwDOBm6k_c5lHK1_ simonw 9599 2023-08-28T20:38:01Z 2023-08-28T20:38:01Z OWNER

I want to test "for this set of restrictions, does a GET/POST to this path return 200 or 403"?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 API tokens with view-table but not view-database/view-instance cannot access the table 1805076818  
1696361304 https://github.com/simonw/datasette/issues/2102#issuecomment-1696361304 https://api.github.com/repos/simonw/datasette/issues/2102 IC_kwDOBm6k_c5lHGtY simonw 9599 2023-08-28T20:23:47Z 2023-08-28T20:24:35Z OWNER

Here's an existing relevant test:

https://github.com/simonw/datasette/blob/2e2825869fc2655b5fcadc743f6f9dec7a49bc65/tests/test_permissions.py#L616-L666

It's not quite right for this new set of tests though, since they need to be exercising actual endpoints (/.json etc) in order to check that this works correctly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 API tokens with view-table but not view-database/view-instance cannot access the table 1805076818  
1696355634 https://github.com/simonw/datasette/issues/2153#issuecomment-1696355634 https://api.github.com/repos/simonw/datasette/issues/2153 IC_kwDOBm6k_c5lHFUy simonw 9599 2023-08-28T20:19:15Z 2023-08-28T20:19:15Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Datasette --get --actor option 1865232341  
1696267473 https://github.com/simonw/datasette/pull/2161#issuecomment-1696267473 https://api.github.com/repos/simonw/datasette/issues/2161 IC_kwDOBm6k_c5lGvzR codecov[bot] 22429695 2023-08-28T19:38:28Z 2023-08-28T19:39:33Z NONE

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.05% :tada:

Comparison is base (527cec6) 92.76% compared to head (a5cbf80) 92.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2161 +/- ## ========================================== + Coverage 92.76% 92.81% +0.05% ========================================== Files 40 40 Lines 5943 5944 +1 ========================================== + Hits 5513 5517 +4 + Misses 430 427 -3 ``` | [Files Changed](https://app.codecov.io/gh/simonw/datasette/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/cli.py](https://app.codecov.io/gh/simonw/datasette/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2NsaS5weQ==) | `82.37% <75.00%> (+1.02%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 -s/--setting x y gets merged into datasette.yml, refs #2143, #2156 1870345352  
1696260446 https://github.com/simonw/datasette/issues/2156#issuecomment-1696260446 https://api.github.com/repos/simonw/datasette/issues/2156 IC_kwDOBm6k_c5lGuFe simonw 9599 2023-08-28T19:33:05Z 2023-08-28T19:33:05Z OWNER

Now a PR: - #2161 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette -s/--setting option for setting nested configuration options 1865649347  
1695736691 https://github.com/simonw/datasette/pull/2152#issuecomment-1695736691 https://api.github.com/repos/simonw/datasette/issues/2152 IC_kwDOBm6k_c5lEuNz dependabot[bot] 49699333 2023-08-28T13:49:35Z 2023-08-28T13:49:35Z CONTRIBUTOR

Superseded by #2160.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump the python-packages group with 3 updates 1865174661  
1694823972 https://github.com/simonw/sqlite-utils/issues/588#issuecomment-1694823972 https://api.github.com/repos/simonw/sqlite-utils/issues/588 IC_kwDOCGYnMM5lBPYk simonw 9599 2023-08-28T00:41:54Z 2023-08-28T00:41:54Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `table.get(column=value)` option for retrieving things not by their primary key 1868713944  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);