issue_comments

Table actions

8 rows where user = 12617395 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

  • bsilverm · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
548058715 https://github.com/simonw/datasette/issues/605#issuecomment-548058715 https://api.github.com/repos/simonw/datasette/issues/605 MDEyOklzc3VlQ29tbWVudDU0ODA1ODcxNQ== bsilverm 12617395 2019-10-30T18:44:41Z 2019-10-30T18:55:37Z NONE

Sure. I imagine it being pretty straight forward. Today when you click on the database, the UI displays:

-Table 1- -fields- -row count- -Table 2- -fields- -row count- Queries: -query1- -query2- .. ...

My proposal would be to display as follows:

-Table 1- -fields- -row count- Queries: -query1- -query2- .. ... -Table 2- -fields- -row count- Queries: -query1- -query2- .. ...

This way, if a given table is not present in the database, the associated queries are also not present. Today, I have a list of queries, some work, some result in errors depending on whether the dependent tables exist in the database.

Let me know if that makes sense. Thanks again!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support queries at the table level 510076368  
544502617 https://github.com/simonw/datasette/issues/588#issuecomment-544502617 https://api.github.com/repos/simonw/datasette/issues/588 MDEyOklzc3VlQ29tbWVudDU0NDUwMjYxNw== bsilverm 12617395 2019-10-21T12:58:22Z 2019-10-21T12:58:22Z NONE

Thanks for the reply. I was hoping queries per table were supported, as I have an application that builds tables depending on the user input to the application. It will either create one table, or two.. and if one or the other is missing, certain queries will return errors. Of course I can work around this by labeling the query name and hope users don't click queries they have not created a table for, but ideally the user would see the queries available based on the tables that exist in their database. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Queries per DB table in metadata.json 505512251  
404576136 https://github.com/simonw/datasette/issues/339#issuecomment-404576136 https://api.github.com/repos/simonw/datasette/issues/339 MDEyOklzc3VlQ29tbWVudDQwNDU3NjEzNg== bsilverm 12617395 2018-07-12T16:45:08Z 2018-07-12T16:45:08Z NONE

Thanks for the quick reply. Looks like that is working well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Expose SANIC_RESPONSE_TIMEOUT config option in a sensible way 340396247  
399173916 https://github.com/simonw/datasette/issues/321#issuecomment-399173916 https://api.github.com/repos/simonw/datasette/issues/321 MDEyOklzc3VlQ29tbWVudDM5OTE3MzkxNg== bsilverm 12617395 2018-06-21T17:00:10Z 2018-06-21T17:00:10Z NONE

Oh I see.. My issue is that the query executes with an empty string prior to the user submitting the parameters. I'll try adding your workaround to some of my queries. Thanks again,

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Wildcard support in query parameters 334190959  
399129220 https://github.com/simonw/datasette/issues/321#issuecomment-399129220 https://api.github.com/repos/simonw/datasette/issues/321 MDEyOklzc3VlQ29tbWVudDM5OTEyOTIyMA== bsilverm 12617395 2018-06-21T14:45:02Z 2018-06-21T14:45:02Z NONE

Those queries look identical. How can this be prevented if the queries are in a metadata.json file?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Wildcard support in query parameters 334190959  
399106871 https://github.com/simonw/datasette/issues/321#issuecomment-399106871 https://api.github.com/repos/simonw/datasette/issues/321 MDEyOklzc3VlQ29tbWVudDM5OTEwNjg3MQ== bsilverm 12617395 2018-06-21T13:39:37Z 2018-06-21T13:39:37Z NONE

One thing I've noticed with this approach is that the query is executed with no parameters which I do not believe was the case previously. In the case the table contains a lot of data, this adds some time executing the query before the user can enter their input and run it with the parameters they want.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Wildcard support in query parameters 334190959  
399098080 https://github.com/simonw/datasette/issues/321#issuecomment-399098080 https://api.github.com/repos/simonw/datasette/issues/321 MDEyOklzc3VlQ29tbWVudDM5OTA5ODA4MA== bsilverm 12617395 2018-06-21T13:10:48Z 2018-06-21T13:10:48Z NONE

Perfect, thank you!!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Wildcard support in query parameters 334190959  
398778485 https://github.com/simonw/datasette/issues/188#issuecomment-398778485 https://api.github.com/repos/simonw/datasette/issues/188 MDEyOklzc3VlQ29tbWVudDM5ODc3ODQ4NQ== bsilverm 12617395 2018-06-20T14:48:39Z 2018-06-20T14:48:39Z NONE

This would be a great feature to have!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability to bundle metadata and templates inside the SQLite file 309047460  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);