issue_comments
8,883 rows where user = 9599 sorted by updated_at descending
This data as json, CSV (advanced)
user 1
- simonw · 6,577 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
1072904703 | https://github.com/simonw/datasette/issues/1661#issuecomment-1072904703 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_8zn_ | simonw 9599 | 2022-03-19T00:37:36Z | 2022-03-19T00:37:36Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | ||
1072901159 | https://github.com/simonw/datasette/issues/1661#issuecomment-1072901159 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_8ywn | simonw 9599 | 2022-03-19T00:20:27Z | 2022-03-19T00:20:27Z | OWNER | I can remove the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | |
1072898923 | https://github.com/simonw/datasette/pull/1664#issuecomment-1072898923 | https://api.github.com/repos/simonw/datasette/issues/1664 | IC_kwDOBm6k_c4_8yNr | simonw 9599 | 2022-03-19T00:11:33Z | 2022-03-19T00:11:33Z | OWNER | I'm going to land this and handle those in separate commits. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove hashed URL mode 1173017980 | |
1072898797 | https://github.com/simonw/datasette/pull/1664#issuecomment-1072898797 | https://api.github.com/repos/simonw/datasette/issues/1664 | IC_kwDOBm6k_c4_8yLt | simonw 9599 | 2022-03-19T00:11:09Z | 2022-03-19T00:11:09Z | OWNER | Still need to remove it from the documentation and do something about that |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove hashed URL mode 1173017980 | |
1072890524 | https://github.com/simonw/datasette/pull/1664#issuecomment-1072890524 | https://api.github.com/repos/simonw/datasette/issues/1664 | IC_kwDOBm6k_c4_8wKc | simonw 9599 | 2022-03-18T23:44:33Z | 2022-03-19T00:06:51Z | OWNER | Looks like that was set here: https://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/datasette/views/base.py#L490-L492 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove hashed URL mode 1173017980 | |
1072890205 | https://github.com/simonw/datasette/pull/1664#issuecomment-1072890205 | https://api.github.com/repos/simonw/datasette/issues/1664 | IC_kwDOBm6k_c4_8wFd | simonw 9599 | 2022-03-18T23:43:15Z | 2022-03-18T23:43:15Z | OWNER | Now almost everything is working except for foreign key expansion: Using the debugger I tracked it down to this code: Turns out |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove hashed URL mode 1173017980 | |
1072834273 | https://github.com/simonw/sqlite-utils/issues/416#issuecomment-1072834273 | https://api.github.com/repos/simonw/sqlite-utils/issues/416 | IC_kwDOCGYnMM4_8ibh | simonw 9599 | 2022-03-18T21:36:05Z | 2022-03-18T21:36:05Z | OWNER | Python's
Imitating this might be the way to go. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Options for how `r.parsedate()` should handle invalid dates 1173023272 | |
1072833174 | https://github.com/simonw/sqlite-utils/issues/416#issuecomment-1072833174 | https://api.github.com/repos/simonw/sqlite-utils/issues/416 | IC_kwDOCGYnMM4_8iKW | simonw 9599 | 2022-03-18T21:34:06Z | 2022-03-18T21:34:06Z | OWNER | Good call-out: right now the It would be better if this was configurable by the user (and properly documented) - options could include "set null if date is invalid" and "leave the value as it is if invalid" in addition to throwing an error. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Options for how `r.parsedate()` should handle invalid dates 1173023272 | |
1071813296 | https://github.com/simonw/datasette/pull/1664#issuecomment-1071813296 | https://api.github.com/repos/simonw/datasette/issues/1664 | IC_kwDOBm6k_c4_4pKw | simonw 9599 | 2022-03-17T23:26:22Z | 2022-03-17T23:26:22Z | OWNER | Probably caused by the convoluted code is |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove hashed URL mode 1173017980 | |
1071809988 | https://github.com/simonw/datasette/pull/1664#issuecomment-1071809988 | https://api.github.com/repos/simonw/datasette/issues/1664 | IC_kwDOBm6k_c4_4oXE | simonw 9599 | 2022-03-17T23:24:57Z | 2022-03-17T23:24:57Z | OWNER | My hunch is that this is broken because of this: Note how the table uses |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove hashed URL mode 1173017980 | |
1071803114 | https://github.com/simonw/datasette/pull/1664#issuecomment-1071803114 | https://api.github.com/repos/simonw/datasette/issues/1664 | IC_kwDOBm6k_c4_4mrq | simonw 9599 | 2022-03-17T23:22:00Z | 2022-03-17T23:22:00Z | OWNER | Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove hashed URL mode 1173017980 | |
1071797707 | https://github.com/simonw/datasette/issues/1661#issuecomment-1071797707 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_4lXL | simonw 9599 | 2022-03-17T23:19:24Z | 2022-03-17T23:19:24Z | OWNER | Moving this to PR so I can comment on individual lines: - #1664 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | |
1071793307 | https://github.com/simonw/datasette/issues/1661#issuecomment-1071793307 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_4kSb | simonw 9599 | 2022-03-17T23:17:32Z | 2022-03-17T23:17:32Z | OWNER | Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | |
1071706993 | https://github.com/simonw/datasette/issues/1661#issuecomment-1071706993 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_4PNx | simonw 9599 | 2022-03-17T22:42:21Z | 2022-03-17T22:42:21Z | OWNER | As part of this I'm going to get rid of this mechanism: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/base.py#L170-L173 Unwrapping |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | |
1071519407 | https://github.com/simonw/datasette/issues/1663#issuecomment-1071519407 | https://api.github.com/repos/simonw/datasette/issues/1663 | IC_kwDOBm6k_c4_3hav | simonw 9599 | 2022-03-17T21:32:35Z | 2022-03-17T21:32:35Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Document the internals that were used in datasette-hashed-urls 1170554975 | ||
1069570893 | https://github.com/simonw/datasette/issues/1532#issuecomment-1069570893 | https://api.github.com/repos/simonw/datasette/issues/1532 | IC_kwDOBm6k_c4_wFtN | simonw 9599 | 2022-03-16T20:11:41Z | 2022-03-16T20:13:34Z | OWNER | Could also build a CLI Rich/Textual app to exercise the API - which could embed Datasette as a dependency and work using Could be a plugin that adds a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Use datasette-table Web Component to guide the design of the JSON API for 1.0 1065429936 | |
1068742624 | https://github.com/simonw/datasette/issues/1663#issuecomment-1068742624 | https://api.github.com/repos/simonw/datasette/issues/1663 | IC_kwDOBm6k_c4_s7fg | simonw 9599 | 2022-03-16T05:17:45Z | 2022-03-16T05:17:45Z | OWNER | Should be documented here: https://docs.datasette.io/en/stable/internals.html |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Document the internals that were used in datasette-hashed-urls 1170554975 | |
1068728484 | https://github.com/simonw/datasette/issues/1661#issuecomment-1068728484 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_s4Ck | simonw 9599 | 2022-03-16T04:47:39Z | 2022-03-16T04:47:39Z | OWNER | https://datasette.io/plugins/datasette-hashed-urls is released now. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | |
1068630353 | https://github.com/simonw/datasette/issues/1661#issuecomment-1068630353 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_sgFR | simonw 9599 | 2022-03-16T01:24:56Z | 2022-03-16T01:25:49Z | OWNER | Here's the only bit of code that references that And here's the test: Related issue: - #471 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | |
1068628839 | https://github.com/simonw/datasette/issues/1661#issuecomment-1068628839 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_sftn | simonw 9599 | 2022-03-16T01:21:36Z | 2022-03-16T01:21:48Z | OWNER | From https://docs.datasette.io/en/0.60.2/performance.html#hashed-url-mode
I'm going to drop |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | |
1068554827 | https://github.com/simonw/datasette/issues/1661#issuecomment-1068554827 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_sNpL | simonw 9599 | 2022-03-15T23:16:58Z | 2022-03-15T23:18:58Z | OWNER | If you attempt to use the old setting:
It should error with a message saying that the feature has been moved to a plugin. I'll do this with a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | |
1068553454 | https://github.com/simonw/datasette/issues/1661#issuecomment-1068553454 | https://api.github.com/repos/simonw/datasette/issues/1661 | IC_kwDOBm6k_c4_sNTu | simonw 9599 | 2022-03-15T23:14:37Z | 2022-03-15T23:14:37Z | OWNER | This is going to simplify the code in the various view classes substantially: - #1660 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Remove Hashed URL mode 1170355774 | |
1068552696 | https://github.com/simonw/datasette/issues/647#issuecomment-1068552696 | https://api.github.com/repos/simonw/datasette/issues/647 | IC_kwDOBm6k_c4_sNH4 | simonw 9599 | 2022-03-15T23:13:06Z | 2022-03-15T23:13:06Z | OWNER | The plugin works. I'm going to implement one last feature for it: Then I can remove hashed URL mode in a separate issue. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Move hashed URL mode out to a plugin 531755959 | |
1068539404 | https://github.com/simonw/datasette/issues/647#issuecomment-1068539404 | https://api.github.com/repos/simonw/datasette/issues/647 | IC_kwDOBm6k_c4_sJ4M | simonw 9599 | 2022-03-15T22:49:01Z | 2022-03-15T22:49:01Z | OWNER | I shipped the first version of this: https://github.com/simonw/datasette-hashed-urls Next step: test it with a live demo: - https://github.com/simonw/datasette-hashed-urls/issues/2 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Move hashed URL mode out to a plugin 531755959 | |
1068461449 | https://github.com/simonw/datasette/issues/1439#issuecomment-1068461449 | https://api.github.com/repos/simonw/datasette/issues/1439 | IC_kwDOBm6k_c4_r22J | simonw 9599 | 2022-03-15T20:51:26Z | 2022-03-15T20:51:26Z | OWNER | I'm happy with this now that I've landed Tilde encoding in #1657. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Rethink how .ext formats (v.s. ?_format=) works before 1.0 973139047 | |
1068450483 | https://github.com/simonw/datasette/issues/857#issuecomment-1068450483 | https://api.github.com/repos/simonw/datasette/issues/857 | IC_kwDOBm6k_c4_r0Kz | simonw 9599 | 2022-03-15T20:43:55Z | 2022-03-15T20:43:55Z | OWNER | Dupe of #1510. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Comprehensive documentation for variables made available to templates 642297505 | |
1068445412 | https://github.com/simonw/datasette/issues/1509#issuecomment-1068445412 | https://api.github.com/repos/simonw/datasette/issues/1509 | IC_kwDOBm6k_c4_ry7k | simonw 9599 | 2022-03-15T20:37:50Z | 2022-03-15T20:38:56Z | OWNER | ... maybe Datasette itself should include interactive API documentation, in addition to documenting it in the manual?
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette 1.0 JSON API (and documentation) 1054243511 | |
1068444767 | https://github.com/simonw/datasette/issues/1509#issuecomment-1068444767 | https://api.github.com/repos/simonw/datasette/issues/1509 | IC_kwDOBm6k_c4_ryxf | simonw 9599 | 2022-03-15T20:37:03Z | 2022-03-15T20:37:03Z | OWNER | Idea: I could add Pydantic https://pydantic-docs.helpmanual.io/usage/schema/ as an optional test dependency and use it to generate JSON schemas and run validation against examples in the API documentation. Maybe generate API documentation from it too? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette 1.0 JSON API (and documentation) 1054243511 | |
1068443509 | https://github.com/simonw/datasette/issues/1510#issuecomment-1068443509 | https://api.github.com/repos/simonw/datasette/issues/1510 | IC_kwDOBm6k_c4_ryd1 | simonw 9599 | 2022-03-15T20:35:29Z | 2022-03-15T20:35:29Z | OWNER | If I set a rule that everything available in the template context MUST also be available via the JSON API (maybe through an extras mechanism) I can combine this with API documentation and solve both at once. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette 1.0 documented template context (maybe via API docs) 1054244712 | |
650696054 | https://github.com/simonw/datasette/issues/870#issuecomment-650696054 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDY5NjA1NA== | simonw 9599 | 2020-06-28T04:52:41Z | 2022-03-15T20:07:17Z | OWNER | This would be a lot easier if I had extracted out the hash logic to a plugin, see: - #647 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
1068418619 | https://github.com/simonw/datasette/issues/1660#issuecomment-1068418619 | https://api.github.com/repos/simonw/datasette/issues/1660 | IC_kwDOBm6k_c4_rsY7 | simonw 9599 | 2022-03-15T20:06:19Z | 2022-03-15T20:06:19Z | OWNER | Also related: - #878 - #1512 - #1518 - #870 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor and simplify Datasette routing and views 1170144879 | |
1068417357 | https://github.com/simonw/datasette/issues/1660#issuecomment-1068417357 | https://api.github.com/repos/simonw/datasette/issues/1660 | IC_kwDOBm6k_c4_rsFN | simonw 9599 | 2022-03-15T20:05:08Z | 2022-03-15T20:05:08Z | OWNER |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor and simplify Datasette routing and views 1170144879 | |
1068415072 | https://github.com/simonw/datasette/issues/1660#issuecomment-1068415072 | https://api.github.com/repos/simonw/datasette/issues/1660 | IC_kwDOBm6k_c4_rrhg | simonw 9599 | 2022-03-15T20:02:36Z | 2022-03-15T20:02:36Z | OWNER | This is one of the worst bits - the Then And its own render method that adds extra stuff to the template context and handles the rel: alternate header: Then To streaming CSV responses: https://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/datasette/views/base.py#L286-L308 To handling SQLite exceptions: https://github.com/simonw/datasette/blob/77a904fea14f743560af9cc668146339bdbbd0a9/datasette/views/base.py#L514-L526 And a ton more. It' s a big mess. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor and simplify Datasette routing and views 1170144879 | |
1068327874 | https://github.com/simonw/datasette/issues/1062#issuecomment-1068327874 | https://api.github.com/repos/simonw/datasette/issues/1062 | IC_kwDOBm6k_c4_rWPC | simonw 9599 | 2022-03-15T18:33:49Z | 2022-03-15T18:33:49Z | OWNER | I can get regular |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor .csv to be an output renderer - and teach register_output_renderer to stream all rows 732674148 | |
1068319530 | https://github.com/simonw/datasette/issues/1651#issuecomment-1068319530 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_rUMq | simonw 9599 | 2022-03-15T18:25:42Z | 2022-03-15T18:25:42Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | ||
1068318454 | https://github.com/simonw/datasette/issues/1657#issuecomment-1068318454 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_rT72 | simonw 9599 | 2022-03-15T18:25:11Z | 2022-03-15T18:25:11Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | ||
1068306916 | https://github.com/simonw/datasette/issues/1657#issuecomment-1068306916 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_rRHk | simonw 9599 | 2022-03-15T18:15:11Z | 2022-03-15T18:15:11Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | ||
1068296042 | https://github.com/simonw/datasette/issues/1657#issuecomment-1068296042 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_rOdq | simonw 9599 | 2022-03-15T18:05:54Z | 2022-03-15T18:05:54Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | ||
1068181623 | https://github.com/simonw/datasette/issues/1657#issuecomment-1068181623 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_qyh3 | simonw 9599 | 2022-03-15T16:18:23Z | 2022-03-15T16:18:23Z | OWNER | Moving this to a PR. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1068148013 | https://github.com/simonw/datasette/issues/1657#issuecomment-1068148013 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_qqUt | simonw 9599 | 2022-03-15T15:50:15Z | 2022-03-15T15:50:15Z | OWNER | The thing that broke everything was this change: I'm going to bring back the horrible |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1068138578 | https://github.com/simonw/datasette/issues/1658#issuecomment-1068138578 | https://api.github.com/repos/simonw/datasette/issues/1658 | IC_kwDOBm6k_c4_qoBS | simonw 9599 | 2022-03-15T15:42:49Z | 2022-03-15T15:42:49Z | OWNER | Easiest way to do this was with three reverts, then cherry-pick back the code of conduct. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Revert main to version that passes tests 1169840669 | |
1068126821 | https://github.com/simonw/datasette/issues/1657#issuecomment-1068126821 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_qlJl | simonw 9599 | 2022-03-15T15:31:54Z | 2022-03-15T15:31:54Z | OWNER | The state I had got to prior to that revert is in https://github.com/simonw/datasette/tree/issue-1657-wip |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1068125636 | https://github.com/simonw/datasette/issues/1657#issuecomment-1068125636 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_qk3E | simonw 9599 | 2022-03-15T15:30:54Z | 2022-03-15T15:30:54Z | OWNER | I've made a real mess of this. I'm going to revert Datasette |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1067423720 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067423720 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_n5fo | simonw 9599 | 2022-03-14T23:59:56Z | 2022-03-14T23:59:56Z | OWNER | Updated test:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1067414156 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067414156 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_n3KM | simonw 9599 | 2022-03-14T23:38:41Z | 2022-03-14T23:38:41Z | OWNER | And in https://datatracker.ietf.org/doc/html/rfc3986#section-2.3 "Unreserved Characters":
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1067413691 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067413691 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_n3C7 | simonw 9599 | 2022-03-14T23:37:42Z | 2022-03-14T23:37:42Z | OWNER | Relevant: https://datatracker.ietf.org/doc/html/rfc3986#section-2.1 ```
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1067382442 | https://github.com/simonw/datasette/issues/1651#issuecomment-1067382442 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_nvaq | simonw 9599 | 2022-03-14T22:59:10Z | 2022-03-14T22:59:10Z | OWNER | This work is now blocked on: - https://github.com/simonw/datasette/issues/1657 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1067382232 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067382232 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_nvXY | simonw 9599 | 2022-03-14T22:58:47Z | 2022-03-14T22:58:47Z | OWNER | Asked about this on Twitter:
Replies so far seem like it should be OK - Apache has supported this for home directories for a couple of decades now without any problems. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1067381556 | https://github.com/simonw/datasette/issues/1657#issuecomment-1067381556 | https://api.github.com/repos/simonw/datasette/issues/1657 | IC_kwDOBm6k_c4_nvM0 | simonw 9599 | 2022-03-14T22:57:27Z | 2022-03-14T22:57:45Z | OWNER | The problem with the dash encoding mechanism is that it turns out dashes are used in a LOT of existing Datasette instances - much of https://fivethirtyeight.datasettes.com/fivethirtyeight for example, and even https://datasette.io/ itself: https://datasette.io/dogsheep-index It's pretty ugly to force all of those to change to their dash-encoded equivalent - and in fact it broke https://datasette.io/ in a subtle way: I'm going to try using |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Tilde encoding: use ~ instead of - for dash-encoding 1168995756 | |
1065988403 | https://github.com/simonw/datasette/issues/1439#issuecomment-1065988403 | https://api.github.com/repos/simonw/datasette/issues/1439 | IC_kwDOBm6k_c4_ibEz | simonw 9599 | 2022-03-13T00:06:38Z | 2022-03-13T00:07:19Z | OWNER | If I want to reserve
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Rethink how .ext formats (v.s. ?_format=) works before 1.0 973139047 | |
1065987808 | https://github.com/simonw/datasette/issues/1439#issuecomment-1065987808 | https://api.github.com/repos/simonw/datasette/issues/1439 | IC_kwDOBm6k_c4_ia7g | simonw 9599 | 2022-03-13T00:02:32Z | 2022-03-13T00:02:32Z | OWNER | OK, this has broken a lot more than I expected it would. Turns out https://datasette.io/-/databases for example has two:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Rethink how .ext formats (v.s. ?_format=) works before 1.0 973139047 | |
1065597709 | https://github.com/simonw/sqlite-utils/issues/411#issuecomment-1065597709 | https://api.github.com/repos/simonw/sqlite-utils/issues/411 | IC_kwDOCGYnMM4_g7sN | simonw 9599 | 2022-03-11T22:32:43Z | 2022-03-11T22:32:43Z | OWNER | Trying to figure out what that extra field in
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Support for generated columns 1160034488 | |
1065596417 | https://github.com/simonw/sqlite-utils/issues/411#issuecomment-1065596417 | https://api.github.com/repos/simonw/sqlite-utils/issues/411 | IC_kwDOCGYnMM4_g7YB | simonw 9599 | 2022-03-11T22:30:15Z | 2022-03-11T22:30:15Z | OWNER | I tried it out in Jupyter and it works as advertised: Introspection is a bit weird: there doesn't seem to be a way to introspect generated columns outside of parsing the stored SQL schema for the columns at the moment! And the Here's why: ```
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Support for generated columns 1160034488 | |
1065402557 | https://github.com/simonw/sqlite-utils/issues/411#issuecomment-1065402557 | https://api.github.com/repos/simonw/sqlite-utils/issues/411 | IC_kwDOCGYnMM4_gMC9 | simonw 9599 | 2022-03-11T19:01:08Z | 2022-03-11T21:42:25Z | OWNER | Just spotted this in https://www.sqlite.org/gencol.html
So to add stored columns to an existing table we would need to use the Here's where |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Support for generated columns 1160034488 | |
1065389386 | https://github.com/simonw/sqlite-utils/issues/411#issuecomment-1065389386 | https://api.github.com/repos/simonw/sqlite-utils/issues/411 | IC_kwDOCGYnMM4_gI1K | simonw 9599 | 2022-03-11T18:42:53Z | 2022-03-11T21:40:51Z | OWNER | The Python API could be:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Support for generated columns 1160034488 | |
1065458729 | https://github.com/simonw/sqlite-utils/issues/411#issuecomment-1065458729 | https://api.github.com/repos/simonw/sqlite-utils/issues/411 | IC_kwDOCGYnMM4_gZwp | simonw 9599 | 2022-03-11T19:58:50Z | 2022-03-11T20:00:25Z | OWNER | I'm coming round to your suggestion to have this as extra arguments to I'd like to come up with syntax for https://sqlite-utils.datasette.io/en/stable/cli-reference.html#create-table Maybe extra |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Support for generated columns 1160034488 | |
1065440445 | https://github.com/simonw/sqlite-utils/issues/411#issuecomment-1065440445 | https://api.github.com/repos/simonw/sqlite-utils/issues/411 | IC_kwDOCGYnMM4_gVS9 | simonw 9599 | 2022-03-11T19:52:15Z | 2022-03-11T19:52:15Z | OWNER | Two new parameters to
These columns will be added at the end of the table, but you can use the |
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
Support for generated columns 1160034488 | |
1065386352 | https://github.com/simonw/sqlite-utils/issues/411#issuecomment-1065386352 | https://api.github.com/repos/simonw/sqlite-utils/issues/411 | IC_kwDOCGYnMM4_gIFw | simonw 9599 | 2022-03-11T18:41:37Z | 2022-03-11T18:41:37Z | OWNER | I like |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Support for generated columns 1160034488 | |
1065384183 | https://github.com/simonw/sqlite-utils/issues/414#issuecomment-1065384183 | https://api.github.com/repos/simonw/sqlite-utils/issues/414 | IC_kwDOCGYnMM4_gHj3 | simonw 9599 | 2022-03-11T18:40:39Z | 2022-03-11T18:40:39Z | OWNER | That fixed it: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
I forgot to include the changelog in the 3.25.1 release 1166731361 | |
1065382145 | https://github.com/simonw/sqlite-utils/issues/414#issuecomment-1065382145 | https://api.github.com/repos/simonw/sqlite-utils/issues/414 | IC_kwDOCGYnMM4_gHEB | simonw 9599 | 2022-03-11T18:39:05Z | 2022-03-11T18:39:05Z | OWNER | https://sqlite-utils.datasette.io/en/3.25.1/changelog.html is currently wrong: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
I forgot to include the changelog in the 3.25.1 release 1166731361 | |
1065381047 | https://github.com/simonw/sqlite-utils/issues/414#issuecomment-1065381047 | https://api.github.com/repos/simonw/sqlite-utils/issues/414 | IC_kwDOCGYnMM4_gGy3 | simonw 9599 | 2022-03-11T18:38:27Z | 2022-03-11T18:38:27Z | OWNER | OK that fixed it here: https://sqlite-utils.datasette.io/en/stable/changelog.html I'm going to trigger a rebuild of |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
I forgot to include the changelog in the 3.25.1 release 1166731361 | |
1065380286 | https://github.com/simonw/sqlite-utils/issues/414#issuecomment-1065380286 | https://api.github.com/repos/simonw/sqlite-utils/issues/414 | IC_kwDOCGYnMM4_gGm- | simonw 9599 | 2022-03-11T18:37:23Z | 2022-03-11T18:37:23Z | OWNER | On ReadTheDocs that triggered a new |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
I forgot to include the changelog in the 3.25.1 release 1166731361 | |
1065379528 | https://github.com/simonw/sqlite-utils/issues/414#issuecomment-1065379528 | https://api.github.com/repos/simonw/sqlite-utils/issues/414 | IC_kwDOCGYnMM4_gGbI | simonw 9599 | 2022-03-11T18:36:17Z | 2022-03-11T18:36:17Z | OWNER | I created a new tag and release: https://github.com/simonw/sqlite-utils/releases/tag/3.25.1 And I cancelled the publish workflow: https://github.com/simonw/sqlite-utils/actions/runs/1970415399 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
I forgot to include the changelog in the 3.25.1 release 1166731361 | |
1065378902 | https://github.com/simonw/sqlite-utils/issues/414#issuecomment-1065378902 | https://api.github.com/repos/simonw/sqlite-utils/issues/414 | IC_kwDOCGYnMM4_gGRW | simonw 9599 | 2022-03-11T18:35:26Z | 2022-03-11T18:35:26Z | OWNER | I deleted both the release and the tag from GitHub using the web interface. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
I forgot to include the changelog in the 3.25.1 release 1166731361 | |
1065377926 | https://github.com/simonw/sqlite-utils/issues/414#issuecomment-1065377926 | https://api.github.com/repos/simonw/sqlite-utils/issues/414 | IC_kwDOCGYnMM4_gGCG | simonw 9599 | 2022-03-11T18:34:05Z | 2022-03-11T18:34:05Z | OWNER | Two options:
I'm going to try and do that first option. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
I forgot to include the changelog in the 3.25.1 release 1166731361 | |
1065357081 | https://github.com/simonw/sqlite-utils/issues/413#issuecomment-1065357081 | https://api.github.com/repos/simonw/sqlite-utils/issues/413 | IC_kwDOCGYnMM4_gA8Z | simonw 9599 | 2022-03-11T18:07:10Z | 2022-03-11T18:07:10Z | OWNER | I'm really happy with this improvement. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Display autodoc type information more legibly 1166587040 | |
1065345515 | https://github.com/simonw/sqlite-utils/issues/413#issuecomment-1065345515 | https://api.github.com/repos/simonw/sqlite-utils/issues/413 | IC_kwDOCGYnMM4_f-Hr | simonw 9599 | 2022-03-11T17:52:22Z | 2022-03-11T17:52:22Z | OWNER | Well this is a huge improvement! https://sqlite-utils.datasette.io/en/latest/reference.html#sqlite_utils.db.Table.insert I'm not crazy about the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Display autodoc type information more legibly 1166587040 | |
1065249883 | https://github.com/simonw/sqlite-utils/issues/413#issuecomment-1065249883 | https://api.github.com/repos/simonw/sqlite-utils/issues/413 | IC_kwDOCGYnMM4_fmxb | simonw 9599 | 2022-03-11T16:03:35Z | 2022-03-11T16:03:35Z | OWNER | Applying this change fixes that:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Display autodoc type information more legibly 1166587040 | |
1065247619 | https://github.com/simonw/sqlite-utils/issues/413#issuecomment-1065247619 | https://api.github.com/repos/simonw/sqlite-utils/issues/413 | IC_kwDOCGYnMM4_fmOD | simonw 9599 | 2022-03-11T16:01:20Z | 2022-03-11T16:01:20Z | OWNER | Definitely an improvement! It does highlight that I'm not currently using the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Display autodoc type information more legibly 1166587040 | |
1065245831 | https://github.com/simonw/sqlite-utils/issues/413#issuecomment-1065245831 | https://api.github.com/repos/simonw/sqlite-utils/issues/413 | IC_kwDOCGYnMM4_flyH | simonw 9599 | 2022-03-11T15:59:14Z | 2022-03-11T15:59:14Z | OWNER | Hint from https://twitter.com/AdamChainz/status/1502311047612575745
|
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Display autodoc type information more legibly 1166587040 | |
1062445113 | https://github.com/simonw/datasette/issues/1655#issuecomment-1062445113 | https://api.github.com/repos/simonw/datasette/issues/1655 | IC_kwDOBm6k_c4_U6A5 | simonw 9599 | 2022-03-09T01:01:24Z | 2022-03-09T01:01:24Z | OWNER | https://labordata.bunkum.us/-/settings shows Any thoughts on how Datasette could handle this kind of thing better? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
query result page is using 400mb of browser memory 40x size of html page and 400x size of csv data 1163369515 | |
1061891851 | https://github.com/simonw/datasette/issues/932#issuecomment-1061891851 | https://api.github.com/repos/simonw/datasette/issues/932 | IC_kwDOBm6k_c4_Sy8L | simonw 9599 | 2022-03-08T15:20:48Z | 2022-03-08T15:20:48Z | OWNER | Made a start on this here: https://datasette.io/tutorials |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
End-user documentation 678760988 | |
1061359915 | https://github.com/simonw/datasette/issues/1651#issuecomment-1061359915 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_QxEr | simonw 9599 | 2022-03-08T03:08:14Z | 2022-03-08T03:09:24Z | OWNER | A lot of the code complexity here is caused by It would be good to get rid of that subclassed shared code, figure out how to do it via a utility function instead. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1061355871 | https://github.com/simonw/datasette/issues/1645#issuecomment-1061355871 | https://api.github.com/repos/simonw/datasette/issues/1645 | IC_kwDOBm6k_c4_QwFf | simonw 9599 | 2022-03-08T02:59:28Z | 2022-03-08T02:59:28Z | OWNER | Hah, found a TODO about this: https://github.com/simonw/datasette/blob/c5791156d92615f25696ba93dae5bb2dcc192c98/datasette/app.py#L997-L999 |
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 1, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Sensible `cache-control` headers for static assets, including those served by plugins 1154399841 | |
1061282743 | https://github.com/simonw/datasette/issues/647#issuecomment-1061282743 | https://api.github.com/repos/simonw/datasette/issues/647 | IC_kwDOBm6k_c4_QeO3 | simonw 9599 | 2022-03-08T00:32:34Z | 2022-03-08T00:32:47Z | OWNER | It would be neat if the plugin could spot old-style hyphen hash URLs (maybe on 404) and redirect those too. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Move hashed URL mode out to a plugin 531755959 | |
1061276646 | https://github.com/simonw/datasette/issues/647#issuecomment-1061276646 | https://api.github.com/repos/simonw/datasette/issues/647 | IC_kwDOBm6k_c4_Qcvm | simonw 9599 | 2022-03-08T00:22:11Z | 2022-03-08T00:22:11Z | OWNER | I'm now convinced this is feasible enough that it's worth doing in time for Datasette 1.0. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Move hashed URL mode out to a plugin 531755959 | |
1061276399 | https://github.com/simonw/datasette/issues/647#issuecomment-1061276399 | https://api.github.com/repos/simonw/datasette/issues/647 | IC_kwDOBm6k_c4_Qcrv | simonw 9599 | 2022-03-08T00:21:47Z | 2022-03-08T00:21:47Z | OWNER | This seems to do the job:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Move hashed URL mode out to a plugin 531755959 | |
1061272544 | https://github.com/simonw/datasette/issues/647#issuecomment-1061272544 | https://api.github.com/repos/simonw/datasette/issues/647 | IC_kwDOBm6k_c4_Qbvg | simonw 9599 | 2022-03-08T00:14:42Z | 2022-03-08T00:14:42Z | OWNER | Maybe the plugin should interfere with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Move hashed URL mode out to a plugin 531755959 | |
1061267615 | https://github.com/simonw/datasette/issues/647#issuecomment-1061267615 | https://api.github.com/repos/simonw/datasette/issues/647 | IC_kwDOBm6k_c4_Qaif | simonw 9599 | 2022-03-08T00:05:43Z | 2022-03-08T00:05:43Z | OWNER | Built a prototype of that plugin: ```python from datasette import hookimpl from functools import wraps @hookimpl def asgi_wrapper(datasette): def wrap_with_hashed_urls(app): @wraps(app) async def hashed_urls(scope, receive, send): # Only triggers on pages with a path not starting in /-/ # and where the first page component matches a database name if scope.get("type") != "http": await app(scope, receive, send) return path = scope["path"].lstrip("/") if not path or path.startswith("-/"): await app(scope, receive, send) return potential_database = path.split("/")[0] # It may or may not be already dbname~hash if "~" in potential_database: db_name, hash = potential_database.split("~", 1) else: db_name = potential_database hash = "" # Is db_name a database we have a hash for? try: db = datasette.get_database(db_name) except KeyError: await app(scope, receive, send) return
``` One catch: it doesn't affect the way URLs are generated - so every internal link within Datasette links to the non-hash version and then triggers a 302 redirect to the hashed version. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Move hashed URL mode out to a plugin 531755959 | |
1061226942 | https://github.com/simonw/datasette/issues/647#issuecomment-1061226942 | https://api.github.com/repos/simonw/datasette/issues/647 | IC_kwDOBm6k_c4_QQm- | simonw 9599 | 2022-03-07T23:00:06Z | 2022-03-07T23:00:06Z | OWNER | This needs to take into account the changes made here: - #1439 In the new encoding scheme, I think So the plugin could check for |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Move hashed URL mode out to a plugin 531755959 | |
1061223822 | https://github.com/simonw/datasette/issues/1651#issuecomment-1061223822 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_QP2O | simonw 9599 | 2022-03-07T22:54:54Z | 2022-03-07T22:54:54Z | OWNER | I'm going to do a review of how URL routing works at the moment for the various views. I edited down the full list a bit - these are the most relevant:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1061197133 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061197133 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QJVN | simonw 9599 | 2022-03-07T22:19:35Z | 2022-03-07T22:19:35Z | OWNER | Also now live on https://datasette.io |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061184206 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061184206 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QGLO | simonw 9599 | 2022-03-07T22:04:51Z | 2022-03-07T22:04:51Z | OWNER | I'm going to add this to the main Datasette repo (done) and the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061182132 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061182132 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QFq0 | simonw 9599 | 2022-03-07T22:02:43Z | 2022-03-07T22:02:43Z | OWNER | Neat, GitHub have a template for this https://github.com/simonw/datasette/community/code-of-conduct/new?template=contributor-covenant |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061181530 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061181530 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QFha | simonw 9599 | 2022-03-07T22:02:06Z | 2022-03-07T22:02:06Z | OWNER | https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions/adding-a-code-of-conduct-to-your-project says this should be called |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061181089 | https://github.com/simonw/datasette/issues/1654#issuecomment-1061181089 | https://api.github.com/repos/simonw/datasette/issues/1654 | IC_kwDOBm6k_c4_QFah | simonw 9599 | 2022-03-07T22:01:38Z | 2022-03-07T22:01:38Z | OWNER | I'm going to use the widely adopted Contributor Covenant: https://www.contributor-covenant.org/version/1/4/code-of-conduct/ |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Adopt a code of conduct 1161969891 | |
1061170897 | https://github.com/simonw/datasette/issues/1651#issuecomment-1061170897 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_QC7R | simonw 9599 | 2022-03-07T21:48:35Z | 2022-03-07T21:48:35Z | OWNER | My attempts to simplify |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1061169528 | https://github.com/simonw/datasette/issues/1651#issuecomment-1061169528 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_QCl4 | simonw 9599 | 2022-03-07T21:47:01Z | 2022-03-07T21:47:01Z | OWNER | Wow, this code is difficult to follow! Look at this bit inside the That's modifying the arguments that were extracted from the path by the routing regular expressions to have |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1061150672 | https://github.com/simonw/datasette/issues/1653#issuecomment-1061150672 | https://api.github.com/repos/simonw/datasette/issues/1653 | IC_kwDOBm6k_c4_P9_Q | simonw 9599 | 2022-03-07T21:23:39Z | 2022-03-07T21:23:39Z | OWNER | There may be a short-term fix for this: table view could start accepting a That fragment could then be pre-populated in |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to default a table to sorting by multiple columns 1161937073 | |
1061148807 | https://github.com/simonw/datasette/issues/1653#issuecomment-1061148807 | https://api.github.com/repos/simonw/datasette/issues/1653 | IC_kwDOBm6k_c4_P9iH | simonw 9599 | 2022-03-07T21:21:23Z | 2022-03-07T21:21:23Z | OWNER | This is currently blocked on the fact that Datasette doesn't have a mechanism for sorting by more than one column: - #197 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism to default a table to sorting by multiple columns 1161937073 | |
1061053094 | https://github.com/simonw/datasette/issues/1651#issuecomment-1061053094 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_PmKm | simonw 9599 | 2022-03-07T19:29:01Z | 2022-03-07T19:29:01Z | OWNER | I found an obscure bug in #1650 which I can fix with this too. The following test should pass:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | |
1061041034 | https://github.com/simonw/datasette/issues/1650#issuecomment-1061041034 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_PjOK | simonw 9599 | 2022-03-07T19:16:51Z | 2022-03-07T19:16:51Z | OWNER | Here's the problem: https://github.com/simonw/datasette/blob/020effe47bf89f35182960a9645f2383a42ebd54/datasette/utils/init.py#L1173-L1175 Which is called here: So |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1061038414 | https://github.com/simonw/datasette/issues/1650#issuecomment-1061038414 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_PilO | simonw 9599 | 2022-03-07T19:14:04Z | 2022-03-07T19:14:04Z | OWNER | The problem seems to be that |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1060870237 | https://github.com/simonw/datasette/issues/1439#issuecomment-1060870237 | https://api.github.com/repos/simonw/datasette/issues/1439 | IC_kwDOBm6k_c4_O5hd | simonw 9599 | 2022-03-07T16:19:22Z | 2022-03-07T16:19:22Z | OWNER | I didn't need to do any of the fancy regular expression routing stuff after all, since the new dash encoding format avoids using |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Rethink how .ext formats (v.s. ?_format=) works before 1.0 973139047 | |
1060864823 | https://github.com/simonw/datasette/issues/1650#issuecomment-1060864823 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_O4M3 | simonw 9599 | 2022-03-07T16:14:33Z | 2022-03-07T16:14:33Z | OWNER | Same problem here: https://fivethirtyeight.datasettes.com/fivethirtyeight/ahca-2Dpolls%2Fahca_polls should redirect but doesn't. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1060863311 | https://github.com/simonw/datasette/issues/1650#issuecomment-1060863311 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_O31P | simonw 9599 | 2022-03-07T16:13:17Z | 2022-03-07T16:13:17Z | OWNER | This doesn't seem to work. https://latest.datasette.io/fixtures/table%2Fwith%2Fslashes.csv should be redirecting now that this is deployed - which it is, because https://latest.datasette.io/-/versions shows 644d25d1de78a36b105cca479e7b3e4375a6eadc - but I'm not getting that redirect. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1060853226 | https://github.com/simonw/datasette/issues/1651#issuecomment-1060853226 | https://api.github.com/repos/simonw/datasette/issues/1651 | IC_kwDOBm6k_c4_O1Xq | simonw 9599 | 2022-03-07T16:04:26Z | 2022-03-07T16:04:26Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Get rid of the no-longer necessary ?_format=json hack for tables called x.json 1161584460 | ||
1060836262 | https://github.com/simonw/datasette/issues/1650#issuecomment-1060836262 | https://api.github.com/repos/simonw/datasette/issues/1650 | IC_kwDOBm6k_c4_OxOm | simonw 9599 | 2022-03-07T15:52:09Z | 2022-03-07T15:52:09Z | OWNER | This is a bit tricky. I tried this, sending a redirect only if a 404 happens: ```diff diff --git a/datasette/app.py b/datasette/app.py index 8c5480c..420664c 100644 --- a/datasette/app.py +++ b/datasette/app.py @@ -1211,6 +1211,10 @@ class DatasetteRouter: return await self.handle_404(request, send)
I was expecting that to redirect to this page:
But instead it took me to another 404:
This is because that URL contains both a %-escaped |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Implement redirects from old % encoding to new dash encoding 1160750713 | |
1060067031 | https://github.com/simonw/datasette/pull/1648#issuecomment-1060067031 | https://api.github.com/repos/simonw/datasette/issues/1648 | IC_kwDOBm6k_c4_L1bX | simonw 9599 | 2022-03-06T23:50:40Z | 2022-03-06T23:58:31Z | OWNER | I may have to do extra work here
Might be able to solve that like so:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Use dash encoding for table names and row primary keys in URLs 1160432941 | |
1060065736 | https://github.com/simonw/datasette/pull/1648#issuecomment-1060065736 | https://api.github.com/repos/simonw/datasette/issues/1648 | IC_kwDOBm6k_c4_L1HI | simonw 9599 | 2022-03-06T23:43:00Z | 2022-03-06T23:43:11Z | OWNER |
Yes, I'm going to do this. At the moment if a DB file is called |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Use dash encoding for table names and row primary keys in URLs 1160432941 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue >30