id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,pull_request,body,repo,type,active_lock_reason,performed_via_github_app,reactions,draft,state_reason
1983600865,PR_kwDOBm6k_c5e7WH7,2206,Bump the python-packages group with 1 update,49699333,open,0,,,1,2023-11-08T13:18:56Z,2023-12-08T13:46:24Z,,CONTRIBUTOR,simonw/datasette/pulls/2206,"Bumps the python-packages group with 1 update: [black](https://github.com/psf/black).

<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/psf/black/releases"">black's releases</a>.</em></p>
<blockquote>
<h2>23.11.0</h2>
<h3>Highlights</h3>
<ul>
<li>Support formatting ranges of lines with the new <code>--line-ranges</code> command-line option
(<a href=""https://redirect.github.com/psf/black/issues/4020"">#4020</a>)</li>
</ul>
<h3>Stable style</h3>
<ul>
<li>Fix crash on formatting bytes strings that look like docstrings (<a href=""https://redirect.github.com/psf/black/issues/4003"">#4003</a>)</li>
<li>Fix crash when whitespace followed a backslash before newline in a docstring (<a href=""https://redirect.github.com/psf/black/issues/4008"">#4008</a>)</li>
<li>Fix standalone comments inside complex blocks crashing Black (<a href=""https://redirect.github.com/psf/black/issues/4016"">#4016</a>)</li>
<li>Fix crash on formatting code like <code>await (a ** b)</code> (<a href=""https://redirect.github.com/psf/black/issues/3994"">#3994</a>)</li>
<li>No longer treat leading f-strings as docstrings. This matches Python's behaviour and
fixes a crash (<a href=""https://redirect.github.com/psf/black/issues/4019"">#4019</a>)</li>
</ul>
<h3>Preview style</h3>
<ul>
<li>Multiline dicts and lists that are the sole argument to a function are now
indented less (<a href=""https://redirect.github.com/psf/black/issues/3964"">#3964</a>)</li>
<li>Multiline unpacked dicts and lists as the sole argument to a function are now also
indented less (<a href=""https://redirect.github.com/psf/black/issues/3992"">#3992</a>)</li>
<li>In f-string debug expressions, quote types that are visible in the final string
are now preserved (<a href=""https://redirect.github.com/psf/black/issues/4005"">#4005</a>)</li>
<li>Fix a bug where long <code>case</code> blocks were not split into multiple lines. Also enable
general trailing comma rules on <code>case</code> blocks (<a href=""https://redirect.github.com/psf/black/issues/4024"">#4024</a>)</li>
<li>Keep requiring two empty lines between module-level docstring and first function or
class definition (<a href=""https://redirect.github.com/psf/black/issues/4028"">#4028</a>)</li>
<li>Add support for single-line format skip with other comments on the same line (<a href=""https://redirect.github.com/psf/black/issues/3959"">#3959</a>)</li>
</ul>
<h3>Configuration</h3>
<ul>
<li>Consistently apply force exclusion logic before resolving symlinks (<a href=""https://redirect.github.com/psf/black/issues/4015"">#4015</a>)</li>
<li>Fix a bug in the matching of absolute path names in <code>--include</code> (<a href=""https://redirect.github.com/psf/black/issues/3976"">#3976</a>)</li>
</ul>
<h3>Performance</h3>
<ul>
<li>Fix mypyc builds on arm64 on macOS (<a href=""https://redirect.github.com/psf/black/issues/4017"">#4017</a>)</li>
</ul>
<h3>Integrations</h3>
<ul>
<li>Black's pre-commit integration will now run only on git hooks appropriate for a code
formatter (<a href=""https://redirect.github.com/psf/black/issues/3940"">#3940</a>)</li>
</ul>
<h2>23.10.1</h2>
<h3>Highlights</h3>
<ul>
<li>Maintanence release to get a fix out for GitHub Action edge case (<a href=""https://redirect.github.com/psf/black/issues/3957"">#3957</a>)</li>
</ul>
<h3>Preview style</h3>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/psf/black/blob/main/CHANGES.md"">black's changelog</a>.</em></p>
<blockquote>
<h2>23.11.0</h2>
<h3>Highlights</h3>
<ul>
<li>Support formatting ranges of lines with the new <code>--line-ranges</code> command-line option
(<a href=""https://redirect.github.com/psf/black/issues/4020"">#4020</a>)</li>
</ul>
<h3>Stable style</h3>
<ul>
<li>Fix crash on formatting bytes strings that look like docstrings (<a href=""https://redirect.github.com/psf/black/issues/4003"">#4003</a>)</li>
<li>Fix crash when whitespace followed a backslash before newline in a docstring (<a href=""https://redirect.github.com/psf/black/issues/4008"">#4008</a>)</li>
<li>Fix standalone comments inside complex blocks crashing Black (<a href=""https://redirect.github.com/psf/black/issues/4016"">#4016</a>)</li>
<li>Fix crash on formatting code like <code>await (a ** b)</code> (<a href=""https://redirect.github.com/psf/black/issues/3994"">#3994</a>)</li>
<li>No longer treat leading f-strings as docstrings. This matches Python's behaviour and
fixes a crash (<a href=""https://redirect.github.com/psf/black/issues/4019"">#4019</a>)</li>
</ul>
<h3>Preview style</h3>
<ul>
<li>Multiline dicts and lists that are the sole argument to a function are now indented
less (<a href=""https://redirect.github.com/psf/black/issues/3964"">#3964</a>)</li>
<li>Multiline unpacked dicts and lists as the sole argument to a function are now also
indented less (<a href=""https://redirect.github.com/psf/black/issues/3992"">#3992</a>)</li>
<li>In f-string debug expressions, quote types that are visible in the final string are
now preserved (<a href=""https://redirect.github.com/psf/black/issues/4005"">#4005</a>)</li>
<li>Fix a bug where long <code>case</code> blocks were not split into multiple lines. Also enable
general trailing comma rules on <code>case</code> blocks (<a href=""https://redirect.github.com/psf/black/issues/4024"">#4024</a>)</li>
<li>Keep requiring two empty lines between module-level docstring and first function or
class definition (<a href=""https://redirect.github.com/psf/black/issues/4028"">#4028</a>)</li>
<li>Add support for single-line format skip with other comments on the same line (<a href=""https://redirect.github.com/psf/black/issues/3959"">#3959</a>)</li>
</ul>
<h3>Configuration</h3>
<ul>
<li>Consistently apply force exclusion logic before resolving symlinks (<a href=""https://redirect.github.com/psf/black/issues/4015"">#4015</a>)</li>
<li>Fix a bug in the matching of absolute path names in <code>--include</code> (<a href=""https://redirect.github.com/psf/black/issues/3976"">#3976</a>)</li>
</ul>
<h3>Performance</h3>
<ul>
<li>Fix mypyc builds on arm64 on macOS (<a href=""https://redirect.github.com/psf/black/issues/4017"">#4017</a>)</li>
</ul>
<h3>Integrations</h3>
<ul>
<li>Black's pre-commit integration will now run only on git hooks appropriate for a code
formatter (<a href=""https://redirect.github.com/psf/black/issues/3940"">#3940</a>)</li>
</ul>
<h2>23.10.1</h2>
<h3>Highlights</h3>
<ul>
<li>Maintenance release to get a fix out for GitHub Action edge case (<a href=""https://redirect.github.com/psf/black/issues/3957"">#3957</a>)</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/psf/black/commit/2a1c67e0b2f81df602ec1f6e7aeb030b9709dc7c""><code>2a1c67e</code></a> Prepare release 23.11.0 (<a href=""https://redirect.github.com/psf/black/issues/4032"">#4032</a>)</li>
<li><a href=""https://github.com/psf/black/commit/72e7a2e43eef2aa0c83652bb6725eb004a2a69f3""><code>72e7a2e</code></a> Remove redundant condition from <code>has_magic_trailing_comma</code> (<a href=""https://redirect.github.com/psf/black/issues/4023"">#4023</a>)</li>
<li><a href=""https://github.com/psf/black/commit/1a7d9c2f58de1ffcbbe6d133f60f283601ba3f54""><code>1a7d9c2</code></a> Preserve visible quote types for f-string debug expressions (<a href=""https://redirect.github.com/psf/black/issues/4005"">#4005</a>)</li>
<li><a href=""https://github.com/psf/black/commit/f4c7be5445c87d9af5eba3d12faea62d2635e3d8""><code>f4c7be5</code></a> docs: fix minor typo (<a href=""https://redirect.github.com/psf/black/issues/4030"">#4030</a>)</li>
<li><a href=""https://github.com/psf/black/commit/2e4fac9d87615e904a49e46a9cab2293e0b13126""><code>2e4fac9</code></a> Apply force exclude logic before symlink resolution (<a href=""https://redirect.github.com/psf/black/issues/4015"">#4015</a>)</li>
<li><a href=""https://github.com/psf/black/commit/66008fda5dc07f5626e5f5d0dcefc476a9c12ab8""><code>66008fd</code></a> [563] Fix standalone comments inside complex blocks crashing Black (<a href=""https://redirect.github.com/psf/black/issues/4016"">#4016</a>)</li>
<li><a href=""https://github.com/psf/black/commit/50ed6221d97b265025abaa66116a7b185f2df5e2""><code>50ed622</code></a> Fix long case blocks not split into multiple lines (<a href=""https://redirect.github.com/psf/black/issues/4024"">#4024</a>)</li>
<li><a href=""https://github.com/psf/black/commit/46be1f8e54ac9a7d67723c0fa28c7bec13a0a2bf""><code>46be1f8</code></a> Support formatting specified lines (<a href=""https://redirect.github.com/psf/black/issues/4020"">#4020</a>)</li>
<li><a href=""https://github.com/psf/black/commit/ecbd9e8cf71f13068c7e6803a534e00363114c91""><code>ecbd9e8</code></a> Fix crash with f-string docstrings (<a href=""https://redirect.github.com/psf/black/issues/4019"">#4019</a>)</li>
<li><a href=""https://github.com/psf/black/commit/e808e61db8c7a8f9c7fd4b2fff2281141f6b2517""><code>e808e61</code></a> Preview: Keep requiring two empty lines between module-level docstring and fi...</li>
<li>Additional commits viewable in <a href=""https://github.com/psf/black/compare/23.9.1...23.11.0"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=black&package-manager=pip&previous-version=23.9.1&new-version=23.11.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2206.org.readthedocs.build/en/2206/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2206/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1994861266,PR_kwDOBm6k_c5fhgOS,2209,Fix query for suggested facets with column named value,198537,open,0,,,3,2023-11-15T14:13:30Z,2023-11-15T15:31:12Z,,CONTRIBUTOR,simonw/datasette/pulls/2209,"See discussion in https://github.com/simonw/datasette/issues/2208

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2209.org.readthedocs.build/en/2209/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2209/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1426379903,PR_kwDOBm6k_c5BtJNn,1870,"don't use immutable=1, only mode=ro",536941,open,0,,,7,2022-10-27T23:33:04Z,2023-10-03T19:12:37Z,,CONTRIBUTOR,simonw/datasette/pulls/1870,"Opening db files in immutable mode sometimes leads to the file being mutated, which causes duplication in the docker image layers: see #1836, #1480

That this happens in ""immutable"" mode is surprising, because the sqlite docs say that setting this should open the database as read only. 

https://www.sqlite.org/c3ref/open.html

> immutable: The immutable parameter is a boolean query parameter that indicates that the database file is stored on read-only media. When immutable is set, SQLite assumes that the database file cannot be changed, even by a process with higher privilege, and so the database is opened read-only and all locking and change detection is disabled. Caution: Setting the immutable property on a database file that does in fact change can result in incorrect query results and/or [SQLITE_CORRUPT](https://www.sqlite.org/rescode.html#corrupt) errors. See also: [SQLITE_IOCAP_IMMUTABLE](https://www.sqlite.org/c3ref/c_iocap_atomic.html).

Perhaps this is a bug in sqlite?



<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--1870.org.readthedocs.build/en/1870/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1870/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1884330740,PR_kwDOBm6k_c5ZszDF,2174,Use $DATASETTE_INTERNAL in absence of --internal,15178711,open,0,,,3,2023-09-06T16:07:15Z,2023-09-08T00:46:13Z,,CONTRIBUTOR,simonw/datasette/pulls/2174,"#refs 2157, specifically [this comment](https://github.com/simonw/datasette/issues/2157#issuecomment-1700291967)

Passing in `--internal my_internal.db` over and over again can get repetitive. 

This PR adds a new configurable env variable `DATASETTE_INTERNAL_DB_PATH`. If it's defined, then it takes place as the path to the internal database. Users can still overwrite this behavior by passing in their own `--internal internal.db` flag.

In draft mode for now, needs tests and documentation. 

Side note: Maybe we can have a sections in the docs that lists all the ""configuration environment variables"" that Datasette respects? I did a quick grep and found:

- `DATASETTE_LOAD_PLUGINS`
- `DATASETTE_SECRETS`


<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2174.org.readthedocs.build/en/2174/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2174/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1864112887,PR_kwDOBm6k_c5Yo7bk,2151,Test Datasette on multiple SQLite versions,15178711,open,0,,,1,2023-08-23T22:42:51Z,2023-08-23T22:58:13Z,,CONTRIBUTOR,simonw/datasette/pulls/2151,"still testing, hope it works!

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2151.org.readthedocs.build/en/2151/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2151/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1,
1556065335,PR_kwDOBm6k_c5Ie5nA,2004,"use single quotes for string literals, fixes #2001",193185,open,0,,,1,2023-01-25T05:08:46Z,2023-02-01T06:37:18Z,,CONTRIBUTOR,simonw/datasette/pulls/2004,"This modernizes some uses of double quotes for string literals to use only single quotes, fixes simonw/datasette#2001

While developing it, I manually enabled the stricter mode by using the code snippet at https://gist.github.com/cldellow/85bba507c314b127f85563869cd94820

I think that code snippet isn't generally safe/portable, so I haven't tried to automate it in the tests.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2004.org.readthedocs.build/en/2004/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2004/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1560982210,PR_kwDOBm6k_c5IvYKw,2008,array facet: don't materialize unnecessary columns,193185,open,0,,,8,2023-01-28T19:33:40Z,2023-01-29T18:17:40Z,,CONTRIBUTOR,simonw/datasette/pulls/2008,"The presence of `inner.*` causes SQLite to materialize a row with all the columns. Those columns will be discarded later.

Instead, we can select only the column we'll use. This lets SQLite's optimizer realize that the other columns in the CTE definition aren't needed.

On a test table with 278K rows, 98K of which had an array, this speeds up the facet calculation from 4 sec to 1 sec.

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2008.org.readthedocs.build/en/2008/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2008/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1555701851,PR_kwDOBm6k_c5IdsD7,2003,Show referring tables and rows when the referring foreign key is compound,536941,open,0,,,3,2023-01-24T21:31:31Z,2023-01-25T18:44:42Z,,CONTRIBUTOR,simonw/datasette/pulls/2003,"sqlite foreign keys can be compound, but that is not as well supported by datasette as single column foreign keys.

in particular, 

1. in a table view, there is not a link from the row to the referenced row if the foreign key is compound
2. in a row view, there is no listing of tables and rows that refer to the focal row if those referencing foreign keys are compound.

Both of these issues are discussed in #1099. 

This PR only fixes the second one, because it's not clear what the right UX is for the first issue.

![Screenshot 2023-01-24 at 19-47-40 nlrb bargaining_unit](https://user-images.githubusercontent.com/536941/214454749-d53deead-4151-4329-a5d4-8a7a454de7d3.png)

Some things that might not be desirable about this approach.

1. it changes the external API, by changing `column` => `columns` and `other_column` => `other_columns` (see inline comment for more discussion.
2. There are various places where the plural foreign keys have to be checked for length and discarded or transformed to singular. 
",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2003/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1538342965,PR_kwDOBm6k_c5HpNYo,1996,Document custom json encoder,25778,open,0,,,1,2023-01-18T16:54:14Z,2023-01-19T12:55:57Z,,CONTRIBUTOR,simonw/datasette/pulls/1996,"Closes #1983 

All documentation here. Edits welcome.


<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--1996.org.readthedocs.build/en/1996/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1996/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1033678984,PR_kwDOBm6k_c4tjgJ8,1495,Allow routes to have extra options,536941,open,0,,,5,2021-10-22T15:00:45Z,2021-11-19T15:36:27Z,,CONTRIBUTOR,simonw/datasette/pulls/1495,"Right now, datasette routes can only be a 2-tuple of `(regex, view_fn)`. 

If it was possible for datasette to handle extra options, like [standard Django does](https://docs.djangoproject.com/en/3.2/topics/http/urls/#passing-extra-options-to-view-functions), it would add flexibility for plugin authors.

For example, if extra options were enabled, then it would be easy to make a single table the home page (#1284). This plugin would accomplish it.

```python
from datasette import hookimpl
from datasette.views.table import TableView

@hookimpl
def register_routes(datasette):
        return [
        (r""^/$"", TableView.as_view(datasette), {'db_name': 'DB_NAME',
                                                'table': 'TABLE_NAME'})
    ]
```
",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1495/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
991206402,MDExOlB1bGxSZXF1ZXN0NzI5NzA0NTM3,1465,add support for -o --get /path,51016,open,0,,,0,2021-09-08T14:30:42Z,2021-09-08T14:31:45Z,,CONTRIBUTOR,simonw/datasette/pulls/1465,"Fixes https://github.com/simonw/datasette/issues/1459

Adds support for `--open --get /path` to be used in combination.

If `--open` is provided alone, datasette will open a web page to a default URL.
If `--get <url>` is provided alone, datasette will output the result of doing a GET to that URL and then exit.
If `--open --get <url>` are provided together, datasette will open a web page to that URL.

TODO items:
- [ ] update documentation
- [ ] print out error message when `--root --open --get <url>` is used
- [ ] adjust code to require that `<url>` start with a `/` when `-o --get <url>` is used
- [ ] add test(s)

note, '@CTB' is used in this PR to flag code that needs revisiting.",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1465/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",1,
756876238,MDExOlB1bGxSZXF1ZXN0NTMyMzQ4OTE5,1130,Fix footer not sticking to bottom in short pages,3243482,open,0,,,4,2020-12-04T07:29:01Z,2021-06-15T13:27:48Z,,CONTRIBUTOR,simonw/datasette/pulls/1130,Fixes https://github.com/simonw/datasette/issues/1129,107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1130/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
904598267,MDExOlB1bGxSZXF1ZXN0NjU1NzQxNDI4,1348,DRAFT: add test and scan for docker images,10801138,open,0,,,2,2021-05-28T03:02:12Z,2021-05-28T03:06:16Z,,CONTRIBUTOR,simonw/datasette/pulls/1348,"**NOTE: I don't think this PR is ready, since the arm/v6 and arm/v7 images are failing pytest due to missing dependencies (gcc and friends). But it's pretty close.**

Closes https://github.com/simonw/datasette/issues/1344 . Using a build-matrix for the platforms and [this test](https://github.com/simonw/datasette/issues/1344#issuecomment-849820019), we test all the platforms in parallel. I also threw in container scanning.

### Switch `pip install` to use either tags or commit shas

Notably! This also [changes the Dockerfile](https://github.com/blairdrummond/datasette/blob/7fe5315d68e04fce64b5bebf4e2d7feec44f8546/Dockerfile#L20) so that it accepts tags or commit-shas.

```
# It's backwards compatible with tags, but also lets you use shas
root@712071df17af:/# pip install git+git://github.com/simonw/datasette.git@0.56                                                                                                                                            
Collecting git+git://github.com/simonw/datasette.git@0.56                                                                                                                                                                  
  Cloning git://github.com/simonw/datasette.git (to revision 0.56) to /tmp/pip-req-build-u6dhm945                                                                                                                          
  Running command git clone -q git://github.com/simonw/datasette.git /tmp/pip-req-build-u6dhm945                                                                                                                           
  Running command git checkout -q af5a7f1c09f6a902bb2a25e8edf39c7034d2e5de                                                                                                                                                 
Collecting Jinja2<2.12.0,>=2.10.3                                                                            
  Downloading Jinja2-2.11.3-py2.py3-none-any.whl (125 kB) 
```

This lets you build the containers in CI every push for testing, which maybe resolves [this problem](https://github.com/simonw/datasette/issues/1272#issuecomment-808648974)?

# Workflow run example

You can see the results in my workflow [here](https://github.com/blairdrummond/datasette/pull/2/checks?check_run_id=2690570717). The commit history is different because I squashed this branch, also in the testing branch I had to change `github.com/simonw` to `github.com/blairdrummond` for the CI to pick up my git_sha.

## Why did the builds fail?

**NOTE:** The results of all the tests fail, but for different reasons! A few fail to install Rust, the amd64 passes the tests (phew!) but has critical CVEs which fail the container scan, the Arm/v6 and Arm/v7 seem to fail to install the test dependencies due to missing programs like `gcc`. (`gcc` is not sufficient though, as [this run](https://github.com/blairdrummond/datasette/pull/3/checks?check_run_id=2690672982) indicates) ",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1348/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
648749062,MDExOlB1bGxSZXF1ZXN0NDQyNTA1MDg4,883,Skip counting hidden tables,3243482,open,0,,,4,2020-07-01T07:38:08Z,2020-07-02T00:25:44Z,,CONTRIBUTOR,simonw/datasette/pulls/883,"Potential fix for https://github.com/simonw/datasette/issues/859.

Disabling table counts for hidden tables speeds up database page quite a bit. In my setup it reduced load time by 2/3 (~300 -> ~90ms)",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/883/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
440325850,MDExOlB1bGxSZXF1ZXN0Mjc1OTIzMDY2,452,SQL builder utility classes,45057,open,0,,,0,2019-05-04T13:57:47Z,2019-05-04T14:03:04Z,,CONTRIBUTOR,simonw/datasette/pulls/452,"This adds a straightforward set of classes to aid in the construction of
SQL queries.

My plan for this was to allow plugins to manipulate the
Datasette-generated SQL in a more structured way. I'm not sure that's
going to work, but I feel like this is still a step forward - it
reduces the number of intermediate variables in `TableView.data` which
aids readability, and also factors out a lot of the boring string
concatenation.

There are a fair number of minor structure changes in here too as I've
tried to make the ordering of `TableView.data` a bit more logical. As
far as I can tell, I haven't broken anything...",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/452/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,