id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,pull_request,body,repo,type,active_lock_reason,performed_via_github_app,reactions,draft,state_reason
1180778860,PR_kwDOBm6k_c41BFWj,1685,"Update jinja2 requirement from <3.1.0,>=2.10.3 to >=2.10.3,<3.2.0",49699333,closed,0,,,3,2022-03-25T13:12:13Z,2022-09-05T18:36:49Z,2022-09-05T18:36:48Z,CONTRIBUTOR,simonw/datasette/pulls/1685,"Updates the requirements on [jinja2](https://github.com/pallets/jinja) to permit the latest version.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/pallets/jinja/releases"">jinja2's releases</a>.</em></p>
<blockquote>
<h2>3.1.0</h2>
<p>This is a feature release, which includes new features and removes previously deprecated features. The 3.1.x branch is now the supported bugfix branch, the 3.0.x branch has become a tag marking the end of support for that branch. We encourage everyone to upgrade, and to use a tool such as <a href=""https://pypi.org/project/pip-tools/"">pip-tools</a> to pin all dependencies and control upgrades. We also encourage upgrading to MarkupSafe 2.1.1, the latest version at this time.</p>
<ul>
<li>Changes: <a href=""https://jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-0"">https://jinja.palletsprojects.com/en/3.1.x/changes/#version-3-1-0</a></li>
<li>Milestone: <a href=""https://github.com/pallets/jinja/milestone/8?closed=1"">https://github.com/pallets/jinja/milestone/8?closed=1</a></li>
<li>MarkupSafe changes: <a href=""https://markupsafe.palletsprojects.com/en/2.1.x/changes/#version-2-1-1"">https://markupsafe.palletsprojects.com/en/2.1.x/changes/#version-2-1-1</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/pallets/jinja/blob/main/CHANGES.rst"">jinja2's changelog</a>.</em></p>
<blockquote>
<h2>Version 3.1.0</h2>
<p>Released 2022-03-24</p>
<ul>
<li>
<p>Drop support for Python 3.6. :pr:<code>1534</code></p>
</li>
<li>
<p>Remove previously deprecated code. :pr:<code>1544</code></p>
<ul>
<li><code>WithExtension</code> and <code>AutoEscapeExtension</code> are built-in now.</li>
<li><code>contextfilter</code> and <code>contextfunction</code> are replaced by
<code>pass_context</code>. <code>evalcontextfilter</code> and
<code>evalcontextfunction</code> are replaced by <code>pass_eval_context</code>.
<code>environmentfilter</code> and <code>environmentfunction</code> are replaced
by <code>pass_environment</code>.</li>
<li><code>Markup</code> and <code>escape</code> should be imported from MarkupSafe.</li>
<li>Compiled templates from very old Jinja versions may need to be
recompiled.</li>
<li>Legacy resolve mode for <code>Context</code> subclasses is no longer
supported. Override <code>resolve_or_missing</code> instead of
<code>resolve</code>.</li>
<li><code>unicode_urlencode</code> is renamed to <code>url_quote</code>.</li>
</ul>
</li>
<li>
<p>Add support for native types in macros. :issue:<code>1510</code></p>
</li>
<li>
<p>The <code>{% trans %}</code> tag can use <code>pgettext</code> and <code>npgettext</code> by
passing a context string as the first token in the tag, like
<code>{% trans &quot;title&quot; %}</code>. :issue:<code>1430</code></p>
</li>
<li>
<p>Update valid identifier characters from Python 3.6 to 3.7.
:pr:<code>1571</code></p>
</li>
<li>
<p>Filters and tests decorated with <code>@async_variant</code> are pickleable.
:pr:<code>1612</code></p>
</li>
<li>
<p>Add <code>items</code> filter. :issue:<code>1561</code></p>
</li>
<li>
<p>Subscriptions (<code>[0]</code>, etc.) can be used after filters, tests, and
calls when the environment is in async mode. :issue:<code>1573</code></p>
</li>
<li>
<p>The <code>groupby</code> filter is case-insensitive by default, matching
other comparison filters. Added the <code>case_sensitive</code> parameter to
control this. :issue:<code>1463</code></p>
</li>
<li>
<p>Windows drive-relative path segments in template names will not
result in <code>FileSystemLoader</code> and <code>PackageLoader</code> loading from
drive-relative paths. :pr:<code>1621</code></p>
</li>
</ul>
<h2>Version 3.0.3</h2>
<p>Released 2021-11-09</p>
<ul>
<li>Fix traceback rewriting internals for Python 3.10 and 3.11.
:issue:<code>1535</code></li>
<li>Fix how the native environment treats leading and trailing spaces
when parsing values on Python 3.10. :pr:<code>1537</code></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/pallets/jinja/commit/84c0e2cf4e58655032930aeb200b979e3c6f5f32""><code>84c0e2c</code></a> Merge pull request <a href=""https://github-redirect.dependabot.com/pallets/jinja/issues/1625"">#1625</a> from pallets/release-3.1.0</li>
<li><a href=""https://github.com/pallets/jinja/commit/7b0c47fe1cd836e19242738fc53f40855c1d7971""><code>7b0c47f</code></a> release version 3.1.0</li>
<li><a href=""https://github.com/pallets/jinja/commit/ede0f98725786911031e33b70fcfbb802ae0c825""><code>ede0f98</code></a> Merge pull request <a href=""https://github-redirect.dependabot.com/pallets/jinja/issues/1621"">#1621</a> from pallets/template-safe-path</li>
<li><a href=""https://github.com/pallets/jinja/commit/040088a39527825c03107f17695d13a1752cc2f3""><code>040088a</code></a> use <code>posixpath.join</code> when loading template names</li>
<li><a href=""https://github.com/pallets/jinja/commit/a2920752fd111c2d52c88eb57487667b3cf0ea7b""><code>a292075</code></a> Merge pull request <a href=""https://github-redirect.dependabot.com/pallets/jinja/issues/1620"">#1620</a> from janfilips/patch-1</li>
<li><a href=""https://github.com/pallets/jinja/commit/6e4df02773465d7a80c75cad93289d24f70bfa74""><code>6e4df02</code></a> Fix formatting in tricks.rst</li>
<li><a href=""https://github.com/pallets/jinja/commit/3a050b122ed8c7b3b6bf0116cb91bd9d5eac7d8f""><code>3a050b1</code></a> Merge pull request <a href=""https://github-redirect.dependabot.com/pallets/jinja/issues/1617"">#1617</a> from pallets/docs-prose</li>
<li><a href=""https://github.com/pallets/jinja/commit/4b63cd8f763f58fa6e5bb43a9af0bc77e93bc987""><code>4b63cd8</code></a> rewrite include statement section</li>
<li><a href=""https://github.com/pallets/jinja/commit/a98d482186935cc535873ed3a9002bca837cc2e5""><code>a98d482</code></a> clean up faq, move technical discussions</li>
<li><a href=""https://github.com/pallets/jinja/commit/9de99f85603e3546055764fc13b1e077e1d2a7b3""><code>9de99f8</code></a> clean up engine comparisons</li>
<li>Additional commits viewable in <a href=""https://github.com/pallets/jinja/compare/2.10.3...3.1.0"">compare view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1685/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1180427792,I_kwDOCGYnMM5GW-YQ,421,"""Error: near ""("": syntax error"" when using sqlite-utils indexes CLI",24938923,closed,0,,,8,2022-03-25T07:12:51Z,2022-04-13T22:41:59Z,2022-04-13T22:41:59Z,NONE,,"This bug relates to https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1066139147

**New error when using CLI: ""sqlite-utils indexes global.db --table""**

```
(app-root) sqlite-utils indexes global.db --table
Error: near ""("": syntax error
(app-root) sqlite-utils --version
sqlite-utils, version 3.25.1
(app-root) sqlite3 --version
3.36.0 2021-06-18 18:36:39
(app-root) python --version
Python 3.8.11
```


Dockerfile
```
FROM centos/python-38-centos7

USER root

RUN yum update -y
RUN yum upgrade -y


# epel
RUN yum -y install epel-release && yum clean all

# SQLite
RUN yum -y install zlib-devel geos geos-devel proj proj-devel freexl freexl-devel libxml2-devel 

WORKDIR /build/
COPY sqlite-autoconf-3360000.tar.gz ./
RUN tar -zxf sqlite-autoconf-3360000.tar.gz
WORKDIR /build/sqlite-autoconf-3360000
RUN ./configure
RUN make
RUN make install

# 
RUN /opt/app-root/bin/python3.8 -m pip install --upgrade pip
RUN pip install sqlite-utils
```",140912432,issue,,,"{""url"": ""https://api.github.com/repos/simonw/sqlite-utils/issues/421/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1181364043,I_kwDOBm6k_c5Gai9L,1687,Make show_json.html or a similar mechanism stable for plugins,9599,open,0,,,0,2022-03-25T23:42:45Z,2022-03-25T23:42:45Z,,OWNER,,"I used `show_json.html` in the new `datasette-packages` plugin, which means it will break if that template changes:
- https://github.com/simonw/datasette-packages/issues/3

It would be useful if it (or something like it) was documented and stable for plugins to use.

Also relevant:
- #878",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1687/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1181236173,I_kwDOCGYnMM5GaDvN,422,Reconsider not running convert functions against null values,9599,open,0,,,1,2022-03-25T20:22:40Z,2022-03-25T20:23:21Z,,OWNER,,"I just got caught out by the fact that `None` values are not processed by the `.convert()` mechanism https://github.com/simonw/sqlite-utils/blob/0b7b80bd40fe86e4d66a04c9f607d94991c45c0b/sqlite_utils/db.py#L2504-L2510

I had run this code while working on #420 and I wasn't sure why it didn't work:

```
$ sqlite-utils add-column content.db articles score float
$ sqlite-utils convert content.db articles score '
import random
random.seed(10)

def convert(value):
    global random
    return random.random()
'
```
The reason it didn't work is that the newly added `score` column was full of `null` values.

I fixed it by doing this instead:

    $ sqlite-utils add-column content.db articles score float --not-null-default 1.0

But this indicates to me that the design of `convert()` here may be incorrect.",140912432,issue,,,"{""url"": ""https://api.github.com/repos/simonw/sqlite-utils/issues/422/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1181037277,I_kwDOBm6k_c5GZTLd,1686,heroku bails if app name specifed in datasette publish is the same as existing app,2115933,open,0,,,0,2022-03-25T17:10:34Z,2022-03-25T17:10:34Z,,NONE,,"Seem that `heroku` does not accept an app overwrite triggered by specifying the app name using `datasette publish`, as below:

```
datasette publish heroku some.db --name ""jazzy-name"" 
```

The resulting error has the below traceback:

```
Creating jazzy-name... !
 ▸    Name jazzy-name is already taken
Traceback (most recent call last):
  File ""/opt/homebrew/bin/datasette"", line 33, in <module>
    sys.exit(load_entry_point('datasette==0.60.1', 'console_scripts', 'datasette')())
  File ""/opt/homebrew/Cellar/datasette/0.60.1/libexec/lib/python3.10/site-packages/click/core.py"", line 1128, in __call__
    return self.main(*args, **kwargs)
  File ""/opt/homebrew/Cellar/datasette/0.60.1/libexec/lib/python3.10/site-packages/click/core.py"", line 1053, in main
    rv = self.invoke(ctx)
  File ""/opt/homebrew/Cellar/datasette/0.60.1/libexec/lib/python3.10/site-packages/click/core.py"", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File ""/opt/homebrew/Cellar/datasette/0.60.1/libexec/lib/python3.10/site-packages/click/core.py"", line 1659, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File ""/opt/homebrew/Cellar/datasette/0.60.1/libexec/lib/python3.10/site-packages/click/core.py"", line 1395, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File ""/opt/homebrew/Cellar/datasette/0.60.1/libexec/lib/python3.10/site-packages/click/core.py"", line 754, in invoke
    return __callback(*args, **kwargs)
  File ""/opt/homebrew/Cellar/datasette/0.60.1/libexec/lib/python3.10/site-packages/datasette/publish/heroku.py"", line 127, in heroku
    create_output = check_output(cmd).decode(""utf8"")
  File ""/opt/homebrew/Cellar/python@3.10/3.10.2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/subprocess.py"", line 420, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File ""/opt/homebrew/Cellar/python@3.10/3.10.2/Frameworks/Python.framework/Versions/3.10/lib/python3.10/subprocess.py"", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['heroku', 'apps:create', 'jazzy-name', '--json']' returned non-zero exit status 1.
```

It's a solid failsafe, but does `datasette publish` have a way to force an overwrite?",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/1686/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,