id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,pull_request,body,repo,type,active_lock_reason,performed_via_github_app,reactions,draft,state_reason
1719759468,PR_kwDOBm6k_c5RBXH_,2077,Bump furo from 2023.3.27 to 2023.5.20,49699333,closed,0,,,3,2023-05-22T13:58:16Z,2023-07-27T13:40:55Z,2023-07-27T13:40:53Z,CONTRIBUTOR,simonw/datasette/pulls/2077,"Bumps [furo](https://github.com/pradyunsg/furo) from 2023.3.27 to 2023.5.20.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/pradyunsg/furo/blob/main/docs/changelog.md"">furo's changelog</a>.</em></p>
<blockquote>
<h1>Changelog</h1>
<!-- raw HTML omitted -->
<h2>2023.05.20 -- Unassuming Ultramarine</h2>
<ul>
<li>✨ Add support for Sphinx 7.</li>
<li>Drop support for Sphinx 5.</li>
<li>Improve the screen-reader label for sidebar collapse.</li>
<li>Make it easier to create derived themes from Furo.</li>
<li>Bump all JS dependencies (NodeJS and npm packages).</li>
</ul>
<h2>2023.03.27 -- Tasty Tangerine</h2>
<ul>
<li>Regenerate with newer version of sphinx-theme-builder, to fix RECORD hashes.</li>
<li>Add missing class to Font Awesome examples</li>
</ul>
<h2>2023.03.23 -- Sassy Saffron</h2>
<ul>
<li>Update Python version classifiers.</li>
<li>Increase the icon size in mobile header.</li>
<li>Increase admonition title bg opacity.</li>
<li>Change the default API background to transparent.</li>
<li>Transition the API background change.</li>
<li>Remove the &quot;indent&quot; of API entries which have a background.</li>
<li>Break long inline code literals.</li>
</ul>
<h2>2022.12.07 -- Reverent Raspberry</h2>
<ul>
<li>✨ Add support for Sphinx 6.</li>
<li>✨ Improve footnote presentation with docutils 0.18+.</li>
<li>Drop support for Sphinx 4.</li>
<li>Improve documentation about what the edit button does.</li>
<li>Improve handling of empty-flexboxes for better print experience on Chrome.</li>
<li>Improve styling for inline signatures.</li>
<li>Replace the <code>meta</code> generator tag with a comment.</li>
<li>Tweak labels with icons to prevent users selecting icons as text on touch.</li>
</ul>
<h2>2022.09.29 -- Quaint Quartz</h2>
<ul>
<li>Add ability to set arbitrary URLs for edit button.</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/pradyunsg/furo/commit/d2c9ca852542820632361f05521b5c94824d1fdc""><code>d2c9ca8</code></a> Prepare release: 2023.05.20</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/662d21b66c0422693e3bcdac87e1c605ed95b32f""><code>662d21b</code></a> Update changelog</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/591780b0f01378aef769da40e5d7a917304bd1a5""><code>591780b</code></a> Bump compatible Sphinx version</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/c2e7837352d290f75579b1859233e9c77afc8911""><code>c2e7837</code></a> Bump NodeJS and package versions</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/dd85574e803bb5e9416be66696acc1a6f91f3470""><code>dd85574</code></a> Use the reference HtmlFormatter class defined on PygmentsBridge. (<a href=""https://redirect.github.com/pradyunsg/furo/issues/657"">#657</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/6bff41949f18dc204cfaeae82c42a7197ff3a200""><code>6bff419</code></a> Fix broken link (<a href=""https://redirect.github.com/pradyunsg/furo/issues/654"">#654</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/e7f732ea5133d29fc6ca62af0455b16ffaab00dc""><code>e7f732e</code></a> Improve the screen-reader label for sidebar collapse</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/48c0bf2aa983fb1ccd79b4167fe85387249afedf""><code>48c0bf2</code></a> Drop the check for the theme name</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/1b17d8102079c3ec2a49f57ebc1931f6869cd61d""><code>1b17d81</code></a> [pre-commit.ci] pre-commit autoupdate (<a href=""https://redirect.github.com/pradyunsg/furo/issues/646"">#646</a>)</li>
<li><a href=""https://github.com/pradyunsg/furo/commit/4904fd5ce0c74386eaee3bd07940aa46254a11ce""><code>4904fd5</code></a> Remove Python 3.8 constraint from Black pre-commit config (<a href=""https://redirect.github.com/pradyunsg/furo/issues/647"">#647</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/pradyunsg/furo/compare/2023.03.27...2023.05.20"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=furo&package-manager=pip&previous-version=2023.3.27&new-version=2023.5.20)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2077.org.readthedocs.build/en/2077/

<!-- readthedocs-preview datasette end -->
> **Note**
> Automatic rebases have been disabled on this pull request as it has been open for over 30 days.",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2077/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1720096994,I_kwDOCGYnMM5mhpji,554,"`IndexError` when doing `.insert(..., pk='id')` after `insert_all`",1231935,open,0,,,1,2023-05-22T17:13:02Z,2023-05-22T17:18:33Z,,NONE,,"I believe this is related to https://github.com/simonw/sqlite-utils/issues/98.

When `pk` is specified by table A's `insert` call, it throws an index error if a different table has written a row with a higher rowid than exists in the first table. Here's a basic example:

```py
from sqlite_utils import Database


def test_pk_for_insert(fresh_db):
    user = {""id"": ""abc"", ""name"": ""david""}

    fresh_db[""users""].insert(user, pk=""id"")

    fresh_db[""comments""].insert_all(
        [
            {""id"": ""def"", ""text"": ""ok""},
            {""id"": ""ghi"", ""text"": ""great""},
        ],
    )

    fresh_db[""users""].insert(
        user,
        ignore=True,
        # BUG: when specifying pk on the second insert call 
        # db.py goes into a block it doesn't expect and we get the error
        pk=""id"",
    )


if __name__ == ""__main__"":
    db = Database(""bug.db"")
    if db[""users""].exists():
        raise ValueError(
            ""bug only shows on a new database - remove bug.db before running the script""
        )
    test_pk_for_insert(db)
```

The error is:

```py
  File ""/Users/david/projects/reddit-to-sqlite/.venv/lib/python3.11/site-packages/sqlite_utils/db.py"", line 2960, in insert_chunk
    row = list(self.rows_where(""rowid = ?"", [self.last_rowid]))[0]
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range
```

The issue is in this block: 

https://github.com/simonw/sqlite-utils/blob/2747257a3334d55e890b40ec58fada57ae8cfbfd/sqlite_utils/db.py#L2954-L2958

relevant locals are:

- `pk`: `'id'`
- `result.lastrowid`: `2`

What's most interesting is the comment `# self.last_rowid will be 0 if a ""INSERT OR IGNORE"" happened`, which doesn't seem to be the case here. ",140912432,issue,,,"{""url"": ""https://api.github.com/repos/simonw/sqlite-utils/issues/554/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,