id,node_id,number,title,user,state,locked,assignee,milestone,comments,created_at,updated_at,closed_at,author_association,pull_request,body,repo,type,active_lock_reason,performed_via_github_app,reactions,draft,state_reason
1876353656,I_kwDOBm6k_c5v1uJ4,2168,Consider a request/response wrapping hook slightly higher level than asgi_wrapper(),9599,open,0,,,6,2023-08-31T21:42:04Z,2023-09-10T17:54:08Z,,OWNER,,"There's a long justification for why this might be needed here:
- https://github.com/simonw/datasette-auth-tokens/issues/10#issuecomment-1701820001

Short version: it would be neat if it was possible to stash some data on the `request` object such that a later plugin/middleware-type-thing could use that to influence the final returned response - similar to the kinds of things you can do with Django middleware.

The `asgi_wrapper()` mechanism doesn't have access to the request or response objects - it gets `scope` and can mess around with `receive` and `send`, but those are pretty low-level primitives.

Since Datasette has well-defined `request` and `response` objects now it might be nice to have a middleware layer that can manipulate those directly.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2168/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,
1875519316,PR_kwDOBm6k_c5ZPO5y,2166,Bump the python-packages group with 1 update,49699333,closed,0,,,1,2023-08-31T13:19:57Z,2023-09-06T16:34:32Z,2023-09-06T16:34:31Z,CONTRIBUTOR,simonw/datasette/pulls/2166,"Bumps the python-packages group with 1 update: [sphinx](https://github.com/sphinx-doc/sphinx).

<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/releases"">sphinx's releases</a>.</em></p>
<blockquote>
<h2>Sphinx 7.2.5</h2>
<p>Changelog: <a href=""https://www.sphinx-doc.org/en/master/changes.html"">https://www.sphinx-doc.org/en/master/changes.html</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href=""https://github.com/sphinx-doc/sphinx/blob/master/CHANGES"">sphinx's changelog</a>.</em></p>
<blockquote>
<h1>Release 7.2.5 (released Aug 30, 2023)</h1>
<h2>Bugs fixed</h2>
<ul>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11645"">#11645</a>: Fix a regression preventing autodoc from importing modules within
packages that make use of <code>if typing.TYPE_CHECKING:</code> to guard circular
imports needed by type checkers.
Patch by Matt Wozniski.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11634"">#11634</a>: Fixed inheritance diagram relative link resolution
for sibling files in a subdirectory.
Patch by Albert Shih.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11659"">#11659</a>: Allow <code>?config=...</code> in :confval:<code>mathjax_path</code>.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11654"">#11654</a>: autodoc: Fail with a more descriptive error message
when an object claims to be an instance of <code>type</code>,
but is not a class.
Patch by James Braza.</li>
<li>11620: Cease emitting :event:<code>source-read</code> events for files read via
the :dudir:<code>include</code> directive.</li>
<li>11620: Add a new :event:<code>include-read</code> for observing and transforming
the content of included files via the :dudir:<code>include</code> directive.</li>
<li><a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11627"">#11627</a>: Restore support for copyright lines of the form <code>YYYY</code>
when <code>SOURCE_DATE_EPOCH</code> is set.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/fcc38997f1d9b728bb4ffc64fc362c7763a4ee25""><code>fcc3899</code></a> Bump to 7.2.5 final</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/2a631f97ef7f4b0edc2470c9cc2b7d809dd75a87""><code>2a631f9</code></a> Restore support for YYYY copyright lines</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/2730cc3353b06f16786d697c61c8b847a91ddd30""><code>2730cc3</code></a> Remove double spaces in CHANGES</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/ff18318613db56d0000db47e5c8f0140556cef0c""><code>ff18318</code></a> Add an <code>'include-read'</code> event (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11657"">#11657</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/74329d9c51c16be54e1f3dece07461f67cfb8ab0""><code>74329d9</code></a> Fail better in <code>ExceptionDocumenter.can_document_member</code> (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11660"">#11660</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/7d046a862f06631367984b87c1e8c2acb518de4f""><code>7d046a8</code></a> Allow <code>?config=...</code> in <code>mathjax_path</code> (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11659"">#11659</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/4692208fde90f5a651f303c0550bcf2b7a8a049c""><code>4692208</code></a> Fix two relative link bugs in inheritance diagrams (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11634"">#11634</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/ca0fc7aa86cb8acfb4445aab17666a836abaee43""><code>ca0fc7a</code></a> Add git .mailmap file</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/8248be31dbd6f235b9393f39ff16fa9e67dec67c""><code>8248be3</code></a> autodoc: Reset <code>sys.modules</code> on partial import failure (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11645"">#11645</a>)</li>
<li><a href=""https://github.com/sphinx-doc/sphinx/commit/e494baa9dd3f43ceeab29454f6b433456339da78""><code>e494baa</code></a> Recommend correct replacement names for deprecated APIs (<a href=""https://redirect.github.com/sphinx-doc/sphinx/issues/11655"">#11655</a>)</li>
<li>Additional commits viewable in <a href=""https://github.com/sphinx-doc/sphinx/compare/v7.2.4...v7.2.5"">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=sphinx&package-manager=pip&previous-version=7.2.4&new-version=7.2.5)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions


</details>

<!-- readthedocs-preview datasette start -->
----
:books: Documentation preview :books:: https://datasette--2166.org.readthedocs.build/en/2166/

<!-- readthedocs-preview datasette end -->",107914493,pull,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2166/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",0,
1876407598,I_kwDOBm6k_c5v17Uu,2169,execute-sql on a database should imply view-database/view-permission,9599,closed,0,,,0,2023-08-31T22:45:56Z,2023-08-31T22:46:28Z,2023-08-31T22:46:28Z,OWNER,,"I noticed that a token with `execute-sql` permission alone did not work, because it was not allowed to view the instance of the database.",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2169/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,completed
1875739055,I_kwDOBm6k_c5vzYGv,2167,Document return type of await ds.permission_allowed(),9599,open,0,,,0,2023-08-31T15:14:23Z,2023-08-31T15:14:23Z,,OWNER,,"The return type isn't documented here: https://github.com/simonw/datasette/blob/4c3ef033110407f3b3dbce501659d523724985e0/docs/internals.rst#L327-L350

On inspecting the code I'm not 100% sure if it's possible for this. method to return `None`, or if it can only return `True` or `False`. Need to confirm that.

https://github.com/simonw/datasette/blob/4c3ef033110407f3b3dbce501659d523724985e0/datasette/app.py#L822C15-L853",107914493,issue,,,"{""url"": ""https://api.github.com/repos/simonw/datasette/issues/2167/reactions"", ""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,