home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 1058072543

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
1058072543 I_kwDOBm6k_c4_EOff 1518 Complete refactor of TableView and table.html template 9599 open 0   3268330 45 2021-11-19T02:55:16Z 2022-03-15T18:35:49Z   OWNER  

Split from #878. The current TableView class is by far the most complex part of Datasette, and the most difficult to work on: https://github.com/simonw/datasette/blob/0.59.2/datasette/views/table.py

In #878 I started exploring a new pattern for building views. In doing so it became clear that TableView is the first beast that I need to slay - if I can refactor that into something neat the pattern for building other views will emerge as a natural consequence.

I've been trying to build this as a register_routes() plugin, as originally suggested in #870 - though unfortunately it looks like those plugins can't replace existing Datasette default views at the moment, see #1517. [UPDATE: I was wrong about this, plugins can over-ride default views just fine]

I also know that I want to have a fully documented template context for table.html as a major step on the way to Datasette 1.0, see #1510.

All of this adds up to the TableView factor being a major project that will unblock a whole flurry of other things - so I'm going to work on that in this separate issue.

107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1518/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   

Links from other tables

  • 3 rows from issues_id in issues_labels
  • 45 rows from issue in issue_comments
Powered by Datasette · Queries took 2.331ms · About: github-to-sqlite