issues: 1695428235

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
1695428235 I_kwDOCGYnMM5lDi6L 538 `table.upsert_all` fails to write rows when `not_null` is present 1231935 closed 0     9 2023-05-04T07:30:38Z 2023-05-08T20:06:35Z 2023-05-08T19:27:02Z NONE  

I found an odd bug today, where calls to table.upsert_all don't write rows if you include the not_null kwarg.

Repro Example

```py from sqlite_utils import Database

db = Database("upsert-test.db")

db["comments"].upsert_all( [{"id": 1, "name": "david"}], pk="id", not_null=["name"], )

assert list(db["comments"].rows) # err! ```

The schema is correctly created:

sql CREATE TABLE [comments] ( [id] INTEGER PRIMARY KEY, [name] TEXT NOT NULL )

But no rows are created. Removing either the not_null kwargs works as expected, as does an insert_all call.

Version Info

  • Python: 3.11.0
  • sqlite-utils: 3.30
  • sqlite: 3.39.5 2022-10-14
 140912432 issue     
{
    "url": "https://api.github.com/repos/simonw/sqlite-utils/issues/538/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed

Links from other tables