home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 344695978

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
344695978 MDExOlB1bGxSZXF1ZXN0MjA0MDI5MTQy 349 publish_subcommand hook + default plugins mechanism, used for publish heroku/now 9599 closed 0     1 2018-07-26T05:03:22Z 2018-07-26T05:28:54Z 2018-07-26T05:16:00Z OWNER simonw/datasette/pulls/349

This change introduces a new plugin hook, publish_subcommand, which can be used to implement new subcommands for the "datasette publish" command family.

I've used this new hook to refactor out the "publish now" and "publish heroku" implementations into separate modules. I've also added unit tests for these two publishers, mocking the subprocess.call and subprocess.check_output functions.

As part of this, I introduced a mechanism for loading default plugins. These are defined in the new "default_plugins" list inside datasette/app.py

Closes #217 (Plugin support for "datasette publish") Closes #348 (Unit tests for "datasette publish") Refs #14, #59, #102, #103, #146, #236, #347

107914493 pull    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/349/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
0  

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 1 row from issue in issue_comments
Powered by Datasette · Queries took 1.07ms · About: github-to-sqlite