home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 443023308

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
443023308 MDU6SXNzdWU0NDMwMjMzMDg= 462 Replace most of `.inspect()` (and `datasette inspect`) with table counting 9599 closed 0   4305096 4 2019-05-11T18:26:06Z 2019-05-16T14:31:05Z 2019-05-16T14:31:05Z OWNER  

This is the last part of #419 - with the move to supporting mutable databases by default, the inspect-data mechanism currently in use no-longer makes much sense.

The one optimization I think it's worth keeping for databases opened in immutable mode is the cached table counts. I think datasette inspect should cut down to only counting the rows in the tables - the other things done by inspect (figuring out columns, foreign key relationships, FTS etc) should all be fast enough that they can be reliably performed at runtime even against large databases.

If performing them at run-time has performance issues, I would rather cache those results internally within Datasette after they are first calculated than continue to support them in the datasette inspect command - to keep things simpler.

107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/462/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed

Links from other tables

  • 1 row from issues_id in issues_labels
  • 4 rows from issue in issue_comments
Powered by Datasette · Queries took 0.938ms · About: github-to-sqlite