issues: 539985017

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
539985017 MDExOlB1bGxSZXF1ZXN0MzU0ODY5Mzkx 652 Quick (and uninformed and perhaps misguided) attempt to add a <base> url for hosting datasette at a particular host/URI 132978 closed 0     1 2019-12-18T23:37:16Z 2020-03-24T22:14:50Z 2020-03-24T22:14:50Z NONE simonw/datasette/pulls/652

As usual, I don't really know what I'm doing... so this is just a suggested approach. I've not written tests, I've not run the tests, I don't know if I've missed some absolute URLs that would need to have the leading slash dropped.

BUT, I tested it with --config base_url:http://127.0.0.1:8001/ on the command line and from what little I know about datasette it's at least working in some obvious cases.

My changes are based on what I saw in https://github.com/simonw/datasette/commit/8da2db4b71096b19e7a9ef1929369b8483d448bf (thanks!)

I'm happy to be more thorough on this if you think it's worth pursuing.

Fixes #394 (he said, optimistically).

 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/652/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  

Links from other tables