issues: 587222354

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
587222354 MDU6SXNzdWU1ODcyMjIzNTQ= 707 Consider configuring Jinja in Datasette() constructor, not .app() 9599 closed 0     0 2020-03-24T19:19:58Z 2020-03-27T01:12:57Z 2020-03-27T01:12:57Z OWNER  

Right now the following fails with an error: python ds = Datasette([], template_dir=".") rendered = await ds.render_template("index.html") The error is: ``` async def render_template( self, templates, context=None, request=None, view_name=None ): context = context or {} if isinstance(templates, Template): template = templates select_templates = [] else: if isinstance(templates, str): templates = [templates]

      template = self.jinja_env.select_template(templates)

E AttributeError: 'Datasette' object has no attribute 'jinja_env' `` This is becausejinja_envis configured in the.app()` method, here:

https://github.com/simonw/datasette/blob/a498d0fe6590f9bdbc4faf9e0dd5faeb3b06002c/datasette/app.py#L609-L633

This is a little surprising, especially now that .render_template() is part of the documented internals API: https://datasette.readthedocs.io/en/stable/internals.html#render-template-template-context-none-request-none

Maybe this should happen in the Datasette class constructor instead.

 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/707/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed

Links from other tables