home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 645975649

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
645975649 MDU6SXNzdWU2NDU5NzU2NDk= 867 register_routes() should support non-async view functions too 9599 closed 0   5533512 1 2020-06-26T03:11:25Z 2020-06-27T18:30:41Z 2020-06-27T18:30:40Z OWNER  

I was looking at this: https://github.com/simonw/datasette-block-robots/blob/main/datasette_block_robots/init.py ```python from datasette import hookimpl from datasette.utils.asgi import Response

async def robots_txt(): return Response.text("User-agent: *\nDisallow: /")

@hookimpl def register_routes(): return [ (r"^/robots.txt$", robots_txt), ] And I realized that if `register_routes()` could support non-async view functions it could be reduced to this:python @hookimpl def register_routes(): return [ (r"^/robots.txt$", lambda: Response.text("User-agent: *\nDisallow: /")), ] ```

107914493 issue    
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/867/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed

Links from other tables

  • 3 rows from issues_id in issues_labels
  • 1 row from issue in issue_comments
Powered by Datasette · Queries took 1.116ms · About: github-to-sqlite