issues: 661605489

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
661605489 MDU6SXNzdWU2NjE2MDU0ODk= 900 Some links don't honor base_url 50220 closed 0   6026070 3 2020-07-20T09:40:50Z 2020-10-23T19:44:04Z 2020-10-15T22:57:55Z NONE  

Hi,

I've been playing with Datasette behind Nginx (awesome tool, thanks !). It seems some URLs are OK but some aren't. For instance in https://github.com/simonw/datasette/blob/master/datasette/templates/query.html#L61 it seems that url_csv includes a / prefix, resulting in the base_url not beeing honored.

Actually here, it seems that dropping the prefix / to make the link relative is enough (so it may not be strictly related to base_url).

Additional information:

datasette, version 0.45+0.gf1f581b.dirty

Relevant Nginx configuration (note that all the trailing slashes have some effect):

location /datasette/ { proxy_pass http://127.0.0.1:9001/; proxy_set_header Host $host; }

Relelvant Datasette configuration (slashes matter too):

--config base_url:/datasette/

 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/900/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed

Links from other tables