issues: 957302085

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
957302085 MDU6SXNzdWU5NTczMDIwODU= 1408 Review places in codebase that use os.chdir(), in particularly relating to tests 9599 open 0     2 2021-07-31T18:57:06Z 2021-07-31T19:00:32Z   OWNER  

To clarify: the core problem here is that an error is thrown any time you call os.getcwd() but the directory you are currently in has been deleted.

runner.isolated_filesystem() assumes that the current directory in has not been deleted. But the various temporary directory utilities in pytest work by creating directories and then deleting them.

Maybe there's a larger problem here that I play a bit fast and loose with os.chdir() in both the test suite and in various lines of code in Datasette itself (in particular in the publish commands)?

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1406#issuecomment-890390198

 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1408/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    

Links from other tables