home / github / issues

Menu
  • Search all tables
  • GraphQL API

issues: 979627285

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
979627285 MDU6SXNzdWU5Nzk2MjcyODU= 323 `table.convert()` method should clean up after itself 9599 closed 0     1 2021-08-25T21:15:39Z 2021-08-25T21:25:26Z 2021-08-25T21:25:18Z OWNER  

It currently works like this: https://github.com/simonw/sqlite-utils/blob/77c240df56068341561e95e4a412cbfa24dc5bc7/sqlite_utils/db.py#L2177-L2195

It's registering a function called convert_value() and then failing to de-register that function once it has finished.

It might even be possible for two queries running against the same connection to clobber each other's convert_value() functions, leading to incorrect behaviour.

So two fixes: firstly it should register the function with a unique name (maybe add a random suffix). Secondly, it should de-register that function once it has finished.

140912432 issue    
{
    "url": "https://api.github.com/repos/simonw/sqlite-utils/issues/323/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  completed

Links from other tables

  • 1 row from issues_id in issues_labels
  • 1 row from issue in issue_comments
Powered by Datasette · Queries took 1.014ms · About: github-to-sqlite