issues: 988552851

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
988552851 MDU6SXNzdWU5ODg1NTI4NTE= 1456 conda install results in non-functioning `datasette serve` due to out-of-date asgiref 51016 open 0     0 2021-09-05T16:59:55Z 2021-09-05T16:59:55Z   CONTRIBUTOR  

Over in https://github.com/ctb/2021-sourmash-datasette, I discovered that the following commands fail: conda create -n datasette4 -y datasette=0.58.1 conda activate datasette4 datasette gathertax.db with ImportError: cannot import name 'WebSocketScope' from 'asgiref.typing'.

This appears to be because asgiref 3.3.4 doesn't have WebSocketScope, but later versions do - a simple

pip install asgiref==3.4.1

fixes the problem for me, at least to the point where I can run datasette and poke around as usual.

I note that over in the conda-forge recipe, https://github.com/conda-forge/datasette-feedstock/blob/master/recipe/meta.yaml pins asgiref to < 3.4.0, but I'm not sure why - so I'm not sure how to best resolve this issue :).

 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1456/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    

Links from other tables