issues

Table actions

13 rows where comments = 6 and type = "pull" sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: user, author_association, created_at (date), updated_at (date), closed_at (date)

state 2

repo 2

type 1

  • pull · 13 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
1874327336 PR_kwDOBm6k_c5ZLMSe 2165 DATASETTE_LOAD_PLUGINS environment variable for loading specific plugins simonw 9599 closed 0     6 2023-08-30T20:33:30Z 2023-08-30T22:12:25Z 2023-08-30T22:12:25Z OWNER simonw/datasette/pulls/2165

  • 2164

TODO:

  • [x] Automated tests
  • [ ] Documentation
  • [x] Make sure DATASETTE_LOAD_PLUGINS='' works for loading zero plugins
 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/2165/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
1661860507 PR_kwDOBm6k_c5N_bMw 2056 GitHub Action to lint Python code with ruff cclauss 3709715 open 0     6 2023-04-11T06:41:27Z 2023-04-15T14:24:46Z   FIRST_TIME_CONTRIBUTOR simonw/datasette/pulls/2056

Ruff supports over 500 lint rules and can be used to replace Flake8 (plus dozens of plugins), isort, pydocstyle, yesqa, eradicate, pyupgrade, and autoflake, all while executing (in Rust) tens or hundreds of times faster than any individual tool.

The ruff Action uses minimal steps to run in ~5 seconds, rapidly providing intuitive GitHub Annotations to contributors.

:books: Documentation preview :books:: https://datasette--2056.org.readthedocs.build/en/2056/

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/2056/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
1486011362 PR_kwDOBm6k_c5E3XqB 1940 register_permissions() plugin hook simonw 9599 closed 0   Datasette 1.0a2 8711695 6 2022-12-09T05:09:28Z 2022-12-13T02:05:55Z 2022-12-13T02:05:54Z OWNER simonw/datasette/pulls/1940

Refs #1939

From this comment: https://github.com/simonw/datasette/issues/1939#issuecomment-1343872168

  • [x] Unit test for the registration plugin hook itself
  • [x] Use them in check_permission_actions_are_documented test in conftest.py
  • [x] Add description field to Permissions (and update tests and docs)
  • [x] Documentation for datasette.permissions dictionary
  • [x] If no default= provided in call to permission_allowed() then use default from datasette.permissions list
  • [x] Remove default= from a bunch of places
  • [x] Throw an error if two permissions are registered with the same name or abbreviation (but other attributes differ)
  • [x] Update authentication and permissions documentation to explain that permissions are now registered and have a registered default

:books: Documentation preview :books:: https://datasette--1940.org.readthedocs.build/en/1940/

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1940/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
1348294436 PR_kwDOCGYnMM49qP2V 468 db[table].create(..., transform=True) and create-table --transform simonw 9599 closed 0   3.29 8355157 6 2022-08-23T17:27:58Z 2022-08-27T23:17:55Z 2022-08-27T23:17:55Z OWNER simonw/sqlite-utils/pulls/468

Work in progress. Still needs documentation and tests (and to cover more cases of things that might have changed).

Refs: - #467

:books: Documentation preview :books:: https://sqlite-utils--468.org.readthedocs.build/en/468/

 sqlite-utils 140912432 pull     
{
    "url": "https://api.github.com/repos/simonw/sqlite-utils/issues/468/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
1084193403 PR_kwDOBm6k_c4wDKmb 1574 introduce new option for datasette package to use a slim base image fs111 33631 closed 0     6 2021-12-19T21:18:19Z 2022-08-15T08:49:31Z 2022-08-15T08:49:31Z NONE simonw/datasette/pulls/1574

The official python images on docker hub come with a slim variant that is significantly smaller than the default. The diff does not change the default, but allows to switch to the slim variant with commandline switch (--slim-base-image)

Size comparison:

``` $ datasette package some.db -t fat --install "datasette-basemap datasette-cluster-map"

$ datasette package some.db -t slim --slim-base-image --install "datasette-basemap datasette-cluster-map"

$ docker images REPOSITORY TAG IMAGE ID CREATED SIZE fat latest 807b393ace0d 9 seconds ago 978MB slim latest 31bc5e63505c 8 minutes ago 191MB

```

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1574/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
1082743068 PR_kwDOBm6k_c4v-izc 1559 filters_from_request plugin hook, now used in TableView simonw 9599 closed 0     6 2021-12-16T23:59:33Z 2021-12-17T23:09:41Z 2021-12-17T19:02:15Z OWNER simonw/datasette/pulls/1559

New plugin hook, refs #473

Used it to extract the logic from TableView that handles _search and _through and _where - refs #1518

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1559/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
724369025 MDExOlB1bGxSZXF1ZXN0NTA1NzY5NDYy 1031 Fallback to databases in inspect-data.json when no -i options are passed frankier 299380 closed 0     6 2020-10-19T07:51:06Z 2021-03-29T01:46:45Z 2021-03-29T00:23:41Z FIRST_TIME_CONTRIBUTOR simonw/datasette/pulls/1031

Currenlty Datasette.__init__ checks immutables against None to decide whether to fallback to inspect-data.json. This patch modifies the serve command to pass None when no -i options are passed so this fallback works correctly.

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1031/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
826613352 MDExOlB1bGxSZXF1ZXN0NTg4NjAxNjI3 1254 Update Docker Spatialite version to 5.0.1 + add support for Spatialite topology functions durkie 3200608 closed 0     6 2021-03-09T20:49:08Z 2021-03-10T18:27:45Z 2021-03-09T22:04:23Z NONE simonw/datasette/pulls/1254

This requires adding the RT Topology library (Spatialite changed to RT Topology from LWGEOM between 4.4 and 5.0), as well as upgrading the GEOS version (which is the reason for switching to python:3.7.10-slim-buster as the base image.)

autoconf and libtool are added to build RT Topology, and Spatialite is now built with --disable-minizip (minizip wasn't an option in 4.4 and I didn't want to add another dependency) and --disable-dependency-tracking which, according to Spatialite, "speeds up one-time builds"

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1254/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
763320133 MDExOlB1bGxSZXF1ZXN0NTM3NzkxNjc1 208 sqlite-utils analyze-tables command and table.analyze_column() method simonw 9599 closed 0     6 2020-12-12T05:27:49Z 2020-12-13T07:20:16Z 2020-12-13T07:20:12Z OWNER simonw/sqlite-utils/pulls/208

Refs #207

  • [x] Improve design of CLI output
  • [x] Truncate long values in least/most common
  • [x] Add a -c column selection option
  • [x] Tests
  • [x] Documentation
 sqlite-utils 140912432 pull     
{
    "url": "https://api.github.com/repos/simonw/sqlite-utils/issues/208/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
753767911 MDExOlB1bGxSZXF1ZXN0NTI5NzgzMjc1 1117 Support for generated columns simonw 9599 closed 0     6 2020-11-30T20:10:46Z 2020-11-30T22:23:19Z 2020-11-30T21:29:58Z OWNER simonw/datasette/pulls/1117

Refs #1116. My first attempt at this worked on my laptop but broke in CI, so I'm going to iterate on it in a pull request instead.

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1117/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
733303548 MDExOlB1bGxSZXF1ZXN0NTEzMTA2MDI2 1069 load_template() plugin hook simonw 9599 closed 0   0.51 6026070 6 2020-10-30T15:59:45Z 2020-10-30T17:47:20Z 2020-10-30T17:47:19Z OWNER simonw/datasette/pulls/1069

Refs #1042

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1069/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
314455877 MDExOlB1bGxSZXF1ZXN0MTgxNzIzMzAz 209 Don't duplicate simple primary keys in the link column russss 45057 closed 0     6 2018-04-15T21:56:15Z 2018-04-18T08:40:37Z 2018-04-18T01:13:04Z CONTRIBUTOR simonw/datasette/pulls/209

When there's a simple (single-column) primary key, it looks weird to duplicate it in the link column.

This change removes the second PK column and treats the link column as if it were the PK column from a header/sorting perspective.

This might make it a bit more difficult to tell what the link for the row is, I'm not sure yet. I feel like the alternative is to change the link column to just have the text "view" or something, instead of repeating the PK. (I doubt it makes much more sense with compound PKs.)

Bonus change in this PR: fix urlencoding of links in the displayed HTML.

Before:

After:

datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/209/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
274284246 MDExOlB1bGxSZXF1ZXN0MTUyODcwMDMw 104 [WIP] Add publish to heroku support jacobian 21148 closed 0     6 2017-11-15T19:56:22Z 2017-11-21T20:55:05Z 2017-11-21T20:55:05Z CONTRIBUTOR simonw/datasette/pulls/104

Refs #90

datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/104/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [pull_request] TEXT,
   [body] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
, [active_lock_reason] TEXT, [performed_via_github_app] TEXT, [reactions] TEXT, [draft] INTEGER, [state_reason] TEXT);
CREATE INDEX [idx_issues_repo]
                ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
                ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
                ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
                ON [issues] ([user]);