issues

Table actions

11 rows where milestone = 2919870, state = "closed" and type = "issue" sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: comments, created_at (date), updated_at (date), closed_at (date)

type 1

  • issue · 11 ✖

state 1

  • closed · 11 ✖

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
275135535 MDU6SXNzdWUyNzUxMzU1MzU= 126 Blog entry announcing foreign key support simonw 9599 closed 0   Foreign key edition 2919870 1 2017-11-19T06:09:06Z 2017-11-30T16:49:24Z 2017-11-30T16:49:24Z OWNER  
datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/126/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
276704127 MDU6SXNzdWUyNzY3MDQxMjc= 149 Update custom SQL results to match new table view header simonw 9599 closed 0   Foreign key edition 2919870 1 2017-11-24T22:03:59Z 2017-11-24T22:42:10Z 2017-11-24T22:42:09Z OWNER  

Follow-on from #147 - the custom SQL results page should more closely match the design of the table view, which now looks like this:

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/149/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
275176006 MDU6SXNzdWUyNzUxNzYwMDY= 133 If view is filtered, search should apply within those filtered rows simonw 9599 closed 0   Foreign key edition 2919870 3 2017-11-19T17:25:36Z 2017-11-24T22:30:32Z 2017-11-24T22:30:15Z OWNER   datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/133/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
276476670 MDU6SXNzdWUyNzY0NzY2NzA= 147 Tidy up design of the header of the table page simonw 9599 closed 0   Foreign key edition 2919870 1 2017-11-23T21:52:58Z 2017-11-24T22:02:46Z 2017-11-24T22:02:46Z OWNER  

This is a bit messy:

Depends on #127

datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/147/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
275135719 MDU6SXNzdWUyNzUxMzU3MTk= 127 Filtered tables should show count of all matching rows, if fast enough simonw 9599 closed 0   Foreign key edition 2919870 2 2017-11-19T06:13:29Z 2017-11-24T22:02:01Z 2017-11-24T22:02:01Z OWNER  

Relates to #86. If you are viewing a filtered page e.g. https://fivethirtyeight.datasettes.com/fivethirtyeight-2628db9/bob-ross%2Felements-by-episode?CLOUDS=1 we should show the count of matching rows.

Since this could be an expensive operation, we will run it with a strict time limit (maybe 50ms). If the time limit is exceeded we will display "many" instead, perhaps? Maybe even link to a count(*) query that would get the full 1000ms time limit which the user can click on if they like (that could even Ajax-in the result).

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/127/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
276477888 MDU6SXNzdWUyNzY0Nzc4ODg= 148 Need a != filter simonw 9599 closed 0   Foreign key edition 2919870 0 2017-11-23T22:05:22Z 2017-11-23T22:10:02Z 2017-11-23T22:10:01Z OWNER  

https://datasette-demos.now.sh/sf-trees-ebc2ad9/Street_Tree_List?qCareAssistant=1 shows trees managed by FUF - but how about trees that are NOT managed by FUF?

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/148/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
275175929 MDU6SXNzdWUyNzUxNzU5Mjk= 132 Row view is not currently expanding foreign keys simonw 9599 closed 0   Foreign key edition 2919870 1 2017-11-19T17:24:25Z 2017-11-23T21:51:51Z 2017-11-23T21:51:30Z OWNER   datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/132/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
273703829 MDU6SXNzdWUyNzM3MDM4Mjk= 86 Filter UI on table page simonw 9599 closed 0   Foreign key edition 2919870 10 2017-11-14T08:22:43Z 2017-11-23T20:34:32Z 2017-11-23T20:34:32Z OWNER  

A UI for building up simple table queries by adding additional filter rules that get executed as query parameters in the URL.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/86/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
275176094 MDU6SXNzdWUyNzUxNzYwOTQ= 134 Filtered table view should show a count simonw 9599 closed 0   Foreign key edition 2919870 1 2017-11-19T17:26:53Z 2017-11-19T18:10:49Z 2017-11-19T18:10:49Z OWNER  

Let's do the thing where we attempt to show an accurate count if it can be done in less than 50ms

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/134/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
273678673 MDU6SXNzdWUyNzM2Nzg2NzM= 85 Detect foreign keys and use them to link HTML pages together simonw 9599 closed 0   Foreign key edition 2919870 6 2017-11-14T06:12:05Z 2017-11-19T06:08:19Z 2017-11-19T06:08:19Z OWNER  

https://stackoverflow.com/a/44430157/6083 documents the PRAGMA needed to extract foreign key references for a table.

At a minimum we can link column values known to be foreign keys to the corresponding row page. We could try to summarize the linked row in some way too - somehow extracting a sensible link title, maybe based on additional configuration in the metadata.json file.

Still todo:

  • [x] Fix it to csvs-to-sqlite refactoring command correctly creates primary key on generated tables
  • [x] Ship new csvs-to-sqlite with refactoring command
  • [x] Refactor column logic to be more predictable in our templates (the rowid special case)
  • [x] Mechanism by which table metadata can specify the "label" column for a table
  • [x] Automatically set the label column as the first column that isn't a primary key (falling back on primary key)
  • [x] Code which runs a "select id, label from table where id in (...)" query as part of the tableview and populates a lookup dictionary
  • [x] Modify templates to use values from that lookup dictionary
 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/85/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
274662378 MDU6SXNzdWUyNzQ2NjIzNzg= 113 Fix the   bug on the database custom SQL query view simonw 9599 closed 0   Foreign key edition 2919870 0 2017-11-16T21:01:26Z 2017-11-17T15:40:52Z 2017-11-17T15:40:52Z OWNER  

https://sf-film-locations.now.sh/sf-film-locations-57704b7?sql=select+*+from+Film_Locations_in_San_Francisco

This is the bug I fixed in 01e0c3fa18cd0dd7970e208790ffd683a420c924 - but I only fixed it in one place.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/113/reactions",
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [pull_request] TEXT,
   [body] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
, [active_lock_reason] TEXT, [performed_via_github_app] TEXT, [reactions] TEXT, [draft] INTEGER, [state_reason] TEXT);
CREATE INDEX [idx_issues_repo]
                ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
                ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
                ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
                ON [issues] ([user]);