issues

Table actions

13 rows where milestone = 5818042 and repo = 107914493 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: user, comments, updated_at, author_association, created_at (date), updated_at (date), closed_at (date)

type 1

state 1

repo 1

  • datasette · 13 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
684925907 MDU6SXNzdWU2ODQ5MjU5MDc= 948 Upgrade CodeMirror simonw 9599 closed 0   Datasette 0.49 5818042 8 2020-08-24T19:55:33Z 2020-09-30T20:36:12Z 2020-08-30T18:03:07Z OWNER  

Datasette currently bundles 5.31.0 (from October 2017) - latest version is 5.57.0 (August 2020). https://codemirror.net/doc/releases.html

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/948/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
687711713 MDU6SXNzdWU2ODc3MTE3MTM= 955 Release updated datasette-atom and datasette-ics simonw 9599 closed 0   Datasette 0.49 5818042 2 2020-08-28T04:55:21Z 2020-09-14T22:19:46Z 2020-09-14T22:19:46Z OWNER  

These should release straight after Datasette 0.49 with the change from #953.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/955/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
679808124 MDU6SXNzdWU2Nzk4MDgxMjQ= 940 Move CI to GitHub Issues simonw 9599 closed 0   Datasette 0.49 5818042 20 2020-08-16T19:06:08Z 2020-09-14T22:09:35Z 2020-09-14T22:09:35Z OWNER  

It looks like the tests take 3m33s to run in GitHub Actions, but they're taking more than 8 minutes in Travis

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/940/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
648637666 MDU6SXNzdWU2NDg2Mzc2NjY= 880 POST to /db/canned-query that returns JSON should be supported (for API clients) simonw 9599 closed 0   Datasette 0.49 5818042 11 2020-07-01T03:14:43Z 2020-09-14T21:28:21Z 2020-09-14T21:25:01Z OWNER  

Now that CSRF is solved for API requests (#835) it would be good to support API requests to the .json extension.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/880/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
701294727 MDU6SXNzdWU3MDEyOTQ3Mjc= 965 Documentation for 404.html, 500.html templates simonw 9599 closed 0   Datasette 0.49 5818042 3 2020-09-14T17:36:59Z 2020-09-14T18:49:49Z 2020-09-14T18:47:22Z OWNER   datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/965/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
700728217 MDU6SXNzdWU3MDA3MjgyMTc= 964 raise_404 mechanism for custom templates simonw 9599 closed 0   Datasette 0.49 5818042 1 2020-09-14T03:22:15Z 2020-09-14T17:49:44Z 2020-09-14T17:39:34Z OWNER  

Having tried this out I think it does need a raise_404() mechanism - which needs to be smart enough to trigger the default 404 handler without accidentally going into an infinite loop.

Originally posted by @simonw in https://github.com/simonw/datasette/issues/944#issuecomment-691788478

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/964/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
681516976 MDU6SXNzdWU2ODE1MTY5NzY= 944 Path parameters for custom pages simonw 9599 closed 0   Datasette 0.49 5818042 5 2020-08-19T03:25:17Z 2020-09-14T03:21:45Z 2020-09-14T02:34:58Z OWNER  

Custom pages let you e.g. create a templates/pages/about.html page and have it automatically served at /about.

It would be useful if these pages could capture path patterns. I like the Python format string syntax for this (also used by Starlette): /foo/bar/{slug}.

So... how about embedding those patterns in the filenames themselves?

templates/pages/museums/{slug}.html

Would capture any hits to /museums/something and use that page to serve them.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/944/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
699947574 MDU6SXNzdWU2OTk5NDc1NzQ= 963 Currently selected array facets are not correctly persisted through hidden form fields mhalle 649467 closed 0   Datasette 0.49 5818042 1 2020-09-12T01:49:17Z 2020-09-12T21:54:29Z 2020-09-12T21:54:09Z NONE  

Faceted search uses JSON array elements as facets rather than the arrays. However, if a search is "Apply"ed (using the Apply button), the array itself rather than its elements used.

To reproduce: https://latest.datasette.io/fixtures/facetable?_sort=pk&_facet=created&_facet=tags&_facet_array=tags

Press "Apply", which might be done when removing a filter. Notice that the "tags" facet values are now arrays, not array elements. It appears the "&_facet_array=tags" element of the query string is dropped.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/963/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
691475400 MDU6SXNzdWU2OTE0NzU0MDA= 958 Upgrade to latest Black (20.8b1) simonw 9599 closed 0   Datasette 0.49 5818042 0 2020-09-02T22:24:19Z 2020-09-11T21:34:24Z 2020-09-02T22:25:10Z OWNER  

Black has some changes: https://black.readthedocs.io/en/stable/change_log.html#b0 - in particular:

  • re-implemented support for explicit trailing commas: now it works consistently within any bracket pair, including nested structures (#1288 and duplicates)
  • Black now reindents docstrings when reindenting code around it (#1053)
 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/958/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
699622046 MDU6SXNzdWU2OTk2MjIwNDY= 962 datasette --pdb option for debugging errors simonw 9599 closed 0   Datasette 0.49 5818042 1 2020-09-11T18:33:10Z 2020-09-11T21:34:24Z 2020-09-11T18:38:01Z OWNER  

I needed to debug an exception from deep inside a Jinja template the other day. I hacked this together and it helped.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/962/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
684111953 MDU6SXNzdWU2ODQxMTE5NTM= 947 datasette --get exit code should reflect HTTP errors simonw 9599 closed 0   Datasette 0.49 5818042 1 2020-08-23T04:17:08Z 2020-09-11T21:33:15Z 2020-09-11T21:33:15Z OWNER  

If you run datasette . --get / and the result is a 500 or 404 error (anything that's not a 200 or a 30x) the exit code from the command should not be 0.

It should still output the returned content to stdout.

This will help with writing soundness checks, as seen in https://til.simonwillison.net/til/til/github-actions_grep-tests.md

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/947/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
682005535 MDU6SXNzdWU2ODIwMDU1MzU= 945 datasette install -U for upgrading packages simonw 9599 closed 0   Datasette 0.49 5818042 1 2020-08-19T17:12:04Z 2020-08-28T04:53:14Z 2020-08-19T17:20:50Z OWNER  

This will also give Homebrew a way to upgrade Datasette itself without having to wait for the latest packaged version to land in Homebrew core.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/945/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
687681018 MDU6SXNzdWU2ODc2ODEwMTg= 953 register_output_renderer render function should be able to return a Response simonw 9599 closed 0   Datasette 0.49 5818042 1 2020-08-28T03:21:21Z 2020-08-28T04:53:03Z 2020-08-28T04:03:01Z OWNER  

That plugin hook was designed before Datasette had a documented Response class. It should optionally be allowed to return a Response in addition to the current custom dictionary.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/953/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [pull_request] TEXT,
   [body] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
, [active_lock_reason] TEXT, [performed_via_github_app] TEXT, [reactions] TEXT, [draft] INTEGER, [state_reason] TEXT);
CREATE INDEX [idx_issues_repo]
                ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
                ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
                ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
                ON [issues] ([user]);