issues

Table actions

4 rows where repo = 107914493, state = "closed" and user = 127565 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 2

state 1

  • closed · 4 ✖

repo 1

  • datasette · 4 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
1218133366 I_kwDOBm6k_c5Imz12 1728 Writable canned queries fail with useless non-error against immutable databases wragge 127565 closed 0   Datasette 0.62 8303187 13 2022-04-28T03:10:34Z 2022-08-14T16:34:40Z 2022-08-14T16:34:40Z CONTRIBUTOR  

I've been banging my head against a wall for a while and would appreciate any pointers...

  • I have a writeable canned query to update rows in the db.
  • I'm using the github-oauth plugin for authentication.
  • I have allow set on the query to accept my GitHub id and a GH organisation.
  • Authentication seems to work as expected both locally and on Cloudrun -- viewing /-/actor gives the same result in both environments
  • I can access the 'padlocked' canned query in both environments.

Everything seems to be the same, but the canned query works perfectly when run locally, and fails when I try it on Cloudrun. I'm redirected back to the canned query page and the db is not changed. There's nothing in the Cloudstor logs to indicate an error.

Any clues as to where I should be looking for the problem?

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1728/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
1213281044 PR_kwDOBm6k_c42qyUI 1717 Add timeout option to Cloudrun build wragge 127565 closed 0     2 2022-04-23T11:51:21Z 2022-04-24T14:03:08Z 2022-04-24T14:03:08Z CONTRIBUTOR simonw/datasette/pulls/1717

I've found that the Cloudrun build phase often hits a timeout limit with large databases. I believe the default timeout is 10 minutes. This pull request just adds a --timeout option to the cloudrun publish command and passes the value on to the build step.

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1717/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
1076388044 I_kwDOBm6k_c5AKGDM 1547 Writable canned queries fail to load custom templates wragge 127565 closed 0   Datasette 0.60 7571612 6 2021-12-10T03:31:48Z 2022-01-13T22:27:59Z 2021-12-19T21:12:00Z CONTRIBUTOR  

I've created a canned query with "write": true set. I've also created a custom template for it, but the template doesn't seem to be found. If I look in the HTML I see (stock_exchange is the db name):

<!-- Templates considered: query-stock_exchange.html, *query.html -->

My non-writeable canned queries pick up custom templates as expected, and if I look at their HTML I see the canned query name added to the templates considered (the canned query here is date_search):

<!-- Templates considered: query-stock_exchange-date_search.html, query-stock_exchange.html, *query.html -->

So it seems like the writeable canned query is behaving differently for some reason. Is it an authentication thing? I'm using the built in --root authentication.

Thanks!

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1547/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
978614898 MDExOlB1bGxSZXF1ZXN0NzE5MTc1NTkz 1447 Remove underscore from search mode parameter name wragge 127565 closed 0     1 2021-08-25T01:28:04Z 2021-08-25T01:28:58Z 2021-08-25T01:28:58Z CONTRIBUTOR simonw/datasette/pulls/1447

The fulltext search documentation refers to the parameter as searchmode but the metadata.json example uses search_mode. The latter doesn't actually seem to work.

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1447/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [pull_request] TEXT,
   [body] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
, [active_lock_reason] TEXT, [performed_via_github_app] TEXT, [reactions] TEXT, [draft] INTEGER, [state_reason] TEXT);
CREATE INDEX [idx_issues_repo]
                ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
                ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
                ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
                ON [issues] ([user]);