{"id": 1123392399, "node_id": "PR_kwDOBm6k_c5C9ZuP", "number": 1893, "state": "closed", "locked": 0, "title": "Upgrade to CodeMirror 6, add SQL autocomplete", "user": {"value": 95570, "label": "bgrins"}, "body": "In an effort to get closer to table / column autocomplete I took a shot at https://github.com/simonw/datasette/issues/1796. I haven't done a lot of testing but would be curious if this fixes some of the concerns raised in https://github.com/simonw/datasette/issues/1796#issue-1355148385 for example.\r\n\r\nDone:\r\n* Changed to bundling using rollup as per https://codemirror.net/examples/bundle/\r\n* Restored a fromTextArea-like function from https://codemirror.net/docs/migration/\r\n* Removed old JS and CSS files (no external CSS needed anymore as per https://codemirror.net/examples/styling/)\r\n* Updated instructions for building the bundle\r\n\r\nNot done:\r\n* cmResize had an error, so commented out the resize handle\r\n* Add extraKeys option for shift+enter and tab\r\n\r\n<!-- readthedocs-preview datasette start -->\r\n----\n:books: Documentation preview :books:: https://datasette--1893.org.readthedocs.build/en/1893/\n\r\n<!-- readthedocs-preview datasette end -->", "created_at": "2022-11-15T20:52:35Z", "updated_at": "2022-11-16T23:54:02Z", "closed_at": "2022-11-16T23:49:06Z", "merged_at": "2022-11-16T23:49:06Z", "merge_commit_sha": "ae11fa5887e03376704c22e5d0969c1e0642d8d8", "assignee": null, "milestone": null, "draft": 0, "head": "f254be4b38936e95e7a7f25866e7c6b0520db96f", "base": "6f610e1d94b7b8ec605b5b7fcb01537f6adf9c5b", "author_association": "CONTRIBUTOR", "repo": {"value": 107914493, "label": "datasette"}, "url": "https://github.com/simonw/datasette/pull/1893", "merged_by": null, "auto_merge": null}
{"id": 1125261188, "node_id": "PR_kwDOBm6k_c5DEh-E", "number": 1898, "state": "closed", "locked": 0, "title": "Use DOMContentLoaded instead of load event for CodeMirror initialization", "user": {"value": 95570, "label": "bgrins"}, "body": " Closes #1894\r\n\r\n<!-- readthedocs-preview datasette start -->\r\n----\n:books: Documentation preview :books:: https://datasette--1898.org.readthedocs.build/en/1898/\n\r\n<!-- readthedocs-preview datasette end -->", "created_at": "2022-11-17T00:19:21Z", "updated_at": "2022-11-18T07:29:01Z", "closed_at": "2022-11-18T07:29:01Z", "merged_at": "2022-11-18T07:29:01Z", "merge_commit_sha": "3ecd131e57add427d847b614c920c9624bb2e66b", "assignee": null, "milestone": null, "draft": 0, "head": "5eb4ea45ce6cdc7003fc7c5175977b025b0f111e", "base": "00e233d7a7f6443cb95fb5227c23580c48551cad", "author_association": "CONTRIBUTOR", "repo": {"value": 107914493, "label": "datasette"}, "url": "https://github.com/simonw/datasette/pull/1898", "merged_by": null, "auto_merge": null}