github
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | pull_request | body | repo | type | active_lock_reason | performed_via_github_app | reactions | draft | state_reason |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
640943441 | MDU6SXNzdWU2NDA5NDM0NDE= | 853 | Ensure register_routes() works for POST | 9599 | closed | 0 | 5533512 | 1 | 2020-06-18T06:24:55Z | 2020-06-24T04:30:30Z | 2020-06-18T16:22:02Z | OWNER | https://twitter.com/amjithr/status/1273496759684050944 | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/853/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
645975649 | MDU6SXNzdWU2NDU5NzU2NDk= | 867 | register_routes() should support non-async view functions too | 9599 | closed | 0 | 5533512 | 1 | 2020-06-26T03:11:25Z | 2020-06-27T18:30:41Z | 2020-06-27T18:30:40Z | OWNER | I was looking at this: https://github.com/simonw/datasette-block-robots/blob/main/datasette_block_robots/__init__.py ```python from datasette import hookimpl from datasette.utils.asgi import Response async def robots_txt(): return Response.text("User-agent: *\nDisallow: /") @hookimpl def register_routes(): return [ (r"^/robots\.txt$", robots_txt), ] ``` And I realized that if `register_routes()` could support non-async view functions it could be reduced to this: ```python @hookimpl def register_routes(): return [ (r"^/robots\.txt$", lambda: Response.text("User-agent: *\nDisallow: /")), ] ``` | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/867/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
646734280 | MDExOlB1bGxSZXF1ZXN0NDQwOTQ2ODE3 | 869 | Magic parameters for canned queries | 9599 | closed | 0 | 5533512 | 1 | 2020-06-27T18:37:21Z | 2020-06-28T02:58:18Z | 2020-06-28T02:58:17Z | OWNER | simonw/datasette/pulls/869 | Implementation for #842 TODO: - [x] Add tests for built-in magic parameters - [x] Magic parameters should not show up as blank form fields on the query page - [x] Update documentation for new `_request_X` (now called `_header_X`) implementation where X is a key from the ASGI scope - [x] Make sure these only work for canned queries, not for arbitrary SQL queries (security issue) - [x] Add test for the `register_magic_parameters` plugin hook - [x] Add documentation for the `register_magic_parameters` plugin hook | 107914493 | pull | { "url": "https://api.github.com/repos/simonw/datasette/issues/869/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
0 | ||||
646840273 | MDU6SXNzdWU2NDY4NDAyNzM= | 871 | Rename the _timestamp magic parameters to _now | 9599 | closed | 0 | 5533512 | 1 | 2020-06-28T04:49:08Z | 2020-06-28T19:49:49Z | 2020-06-28T19:49:49Z | OWNER | I like the shorter name better. Follows on from #842. | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/871/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
647879783 | MDU6SXNzdWU2NDc4Nzk3ODM= | 876 | Add log out link to the pattern portfolio | 9599 | closed | 0 | 5533512 | 1 | 2020-06-30T05:42:15Z | 2020-06-30T23:50:04Z | 2020-06-30T23:47:31Z | OWNER | Follows #875 | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/876/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
648569227 | MDU6SXNzdWU2NDg1NjkyMjc= | 879 | Database page documentation still talks about hashes in URLs | 9599 | closed | 0 | 5533512 | 1 | 2020-06-30T23:43:17Z | 2020-06-30T23:48:06Z | 2020-06-30T23:45:42Z | OWNER | https://datasette.readthedocs.io/en/0.44/pages.html > Note that these URLs end in a 7 character hash. This hash is derived from the contents of the database, and ensures that each URL is immutable: the data returned from a URL containing the hash will always be the same, since if the contents of the database file changes by even a single byte a new hash will be generated. This isn't accurate any more - that's not default behaviour, and it may be removed entirely in #647. | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/879/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed | |||||
649373451 | MDU6SXNzdWU2NDkzNzM0NTE= | 885 | Blog entry about the release | 9599 | closed | 0 | 5533512 | 1 | 2020-07-01T22:44:37Z | 2020-07-01T22:44:48Z | 2020-07-01T22:44:47Z | OWNER | 107914493 | issue | { "url": "https://api.github.com/repos/simonw/datasette/issues/885/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
completed |