github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/1603#issuecomment-1016589519 | https://api.github.com/repos/simonw/datasette/issues/1603 | 1016589519 | IC_kwDOBm6k_c48l-zP | 9599 | 2022-01-19T15:36:38Z | 2022-01-19T15:36:38Z | OWNER | Also people can use a custom base template and link to a custom favicon if they want to. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1108235694 | |
https://github.com/simonw/datasette/issues/1603#issuecomment-1016589140 | https://api.github.com/repos/simonw/datasette/issues/1603 | 1016589140 | IC_kwDOBm6k_c48l-tU | 9599 | 2022-01-19T15:36:16Z | 2022-01-19T15:36:16Z | OWNER | For the moment then I will hard-code a new favicon and leave it to ASGI plugins if people want to define their own. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1108235694 | |
https://github.com/simonw/datasette/issues/1603#issuecomment-1016588326 | https://api.github.com/repos/simonw/datasette/issues/1603 | 1016588326 | IC_kwDOBm6k_c48l-gm | 9599 | 2022-01-19T15:35:33Z | 2022-01-19T15:35:33Z | OWNER | I don't think abusing the template loader mechanism for this will work: Jinja provides an API for loading text templates, but I don't think it can be sensibly abused to open binary image files instead. Loaded code is here: https://github.com/pallets/jinja/blob/main/src/jinja2/loaders.py | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1108235694 | |
https://github.com/simonw/datasette/issues/1603#issuecomment-1016579661 | https://api.github.com/repos/simonw/datasette/issues/1603 | 1016579661 | IC_kwDOBm6k_c48l8ZN | 9599 | 2022-01-19T15:27:05Z | 2022-01-19T15:27:05Z | OWNER | I'd like this to be customizable. I'm going to load it from the template loading system such that a custom favicon for a specific instance can be dropped in using a file in `templates/`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1108235694 |