github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/sqlite-utils/issues/450#issuecomment-1185982012 | https://api.github.com/repos/simonw/sqlite-utils/issues/450 | 1185982012 | IC_kwDOCGYnMM5GsKY8 | 9599 | 2022-07-15T22:02:59Z | 2022-07-15T22:03:49Z | OWNER | From https://sqlite-utils.datasette.io/en/latest/cli-reference.html Commands that currently have an `--ignore` flag, and their descriptions: - `insert`: Ignore records if pk already exists - `create-table`: If table already exists, do nothing - `add-foreign-key`: If foreign key already exists, do nothing - `drop-table`: *description is missing* - `create-view`: If view already exists, do nothing - `drop-view`: *description is missing* And `create-index` has: - `--if-not-exists`: Ignore if index already exists | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1292060682 | |
https://github.com/simonw/sqlite-utils/issues/450#issuecomment-1185983894 | https://api.github.com/repos/simonw/sqlite-utils/issues/450 | 1185983894 | IC_kwDOCGYnMM5GsK2W | 9599 | 2022-07-15T22:06:29Z | 2022-07-15T22:37:20Z | OWNER | Commands that could have `--ignore` added to them: - [x] `enable-fts` - [x] `disable-fts` (not doing) - [x] `add-column` - [x] `add-foreign-keys` (decided not to do this) - [x] `duplicate` - [x] `add-geometry-column` (decided not to do this) - [x] `create-spatial-index` (decided not to do this) | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1292060682 | |
https://github.com/simonw/sqlite-utils/issues/450#issuecomment-1185988277 | https://api.github.com/repos/simonw/sqlite-utils/issues/450 | 1185988277 | IC_kwDOCGYnMM5GsL61 | 9599 | 2022-07-15T22:11:52Z | 2022-07-15T22:11:52Z | OWNER | For `enable-fts` I should use `--replace` instead, since that matches how the Python API works: https://github.com/simonw/sqlite-utils/blob/9dd4cf891d9f4565019e030ddc712507ac87b998/sqlite_utils/db.py#L2088-L2106 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1292060682 | |
https://github.com/simonw/sqlite-utils/issues/450#issuecomment-1185988480 | https://api.github.com/repos/simonw/sqlite-utils/issues/450 | 1185988480 | IC_kwDOCGYnMM5GsL-A | 9599 | 2022-07-15T22:12:20Z | 2022-07-15T22:12:20Z | OWNER | `disable-fts` already fails silently if the table doesn't have FTS setup. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1292060682 | |
https://github.com/simonw/sqlite-utils/issues/450#issuecomment-1185993791 | https://api.github.com/repos/simonw/sqlite-utils/issues/450 | 1185993791 | IC_kwDOCGYnMM5GsNQ_ | 9599 | 2022-07-15T22:23:02Z | 2022-07-15T22:23:02Z | OWNER | `create-spatial-index` is tricky. For consistency with `create-index` it should really use `--if-not-exists` - but under the hood it's not using `IF NOT EXISTS` because those indexes are created using `select CreateSpatialIndex(...)`. Really this highlights that `--if-not-exists` is a bad name for that option on `create-index`. I'm tempted to add `--ignore` to `create-index` and mark `--if-not-exists` as deprecated - though it will still work because I don't want to release a major version bump. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1292060682 | |
https://github.com/simonw/sqlite-utils/issues/450#issuecomment-1185994282 | https://api.github.com/repos/simonw/sqlite-utils/issues/450 | 1185994282 | IC_kwDOCGYnMM5GsNYq | 9599 | 2022-07-15T22:24:12Z | 2022-07-15T22:24:12Z | OWNER | I can do this for `--create-index` instead: ``` Options: --name TEXT Explicit name for the new index --unique Make this a unique index --if-not-exists, --ignore Ignore if index already exists --analyze Run ANALYZE after creating the index --load-extension TEXT SQLite extensions to load -h, --help Show this message and exit. ``` That supports both names for the option. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1292060682 | |
https://github.com/simonw/sqlite-utils/issues/450#issuecomment-1185997860 | https://api.github.com/repos/simonw/sqlite-utils/issues/450 | 1185997860 | IC_kwDOCGYnMM5GsOQk | 9599 | 2022-07-15T22:32:51Z | 2022-07-15T22:32:51Z | OWNER | `add-foreign-keys` is enough of a power-feature that I'm happy not to add this there. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1292060682 | |
https://github.com/simonw/sqlite-utils/issues/450#issuecomment-1186001408 | https://api.github.com/repos/simonw/sqlite-utils/issues/450 | 1186001408 | IC_kwDOCGYnMM5GsPIA | 9599 | 2022-07-15T22:37:40Z | 2022-07-15T22:37:40Z | OWNER | I'm going to skip `add-geometry-column` and `create-spatial-index` as well. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1292060682 | |
https://github.com/simonw/sqlite-utils/issues/450#issuecomment-1186002019 | https://api.github.com/repos/simonw/sqlite-utils/issues/450 | 1186002019 | IC_kwDOCGYnMM5GsPRj | 9599 | 2022-07-15T22:39:09Z | 2022-07-15T22:39:09Z | OWNER | Here are all of the changes I made in this issue: https://github.com/simonw/sqlite-utils/compare/e10536c7f59abbb785f092bf83c4ab94c00e31a3...b9a89a0f2c3559989efe65f25a6e1f8fa76fe8b0 | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1292060682 |