github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/issues/2038#issuecomment-1463110978 | https://api.github.com/repos/simonw/datasette/issues/2038 | 1463110978 | IC_kwDOBm6k_c5XNU1C | 9599 | 2023-03-10T02:09:41Z | 2023-03-10T02:09:41Z | OWNER | I'm torn on this. It's useful for me right now for refactoring, but I feel like it should be a permanent thing, not a setting - or it should default to on and people should turn it off, but who would ever do that? | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1618249044 | |
https://github.com/simonw/datasette/issues/2038#issuecomment-1463112173 | https://api.github.com/repos/simonw/datasette/issues/2038 | 1463112173 | IC_kwDOBm6k_c5XNVHt | 9599 | 2023-03-10T02:11:06Z | 2023-03-10T02:11:06Z | OWNER | Here's an example of something that would break: https://github.com/simonw/datasette/blob/56b0758a5fbf85d01ff80a40c9b028469d7bb65f/datasette/templates/database.html#L12-L15 Because `metadata` is an empty dictionary sometimes, so `{{ metadata.title or database }}` would raise an error and need to be replaced by `{{ metadata.get("title") or database }}`. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1618249044 |