github
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/simonw/datasette/pull/2118#issuecomment-1668789134 | https://api.github.com/repos/simonw/datasette/issues/2118 | 1668789134 | IC_kwDOBm6k_c5jd7OO | 9599 | 2023-08-08T01:46:12Z | 2023-08-08T01:46:12Z | OWNER | I'm going to squash merge this even though it's a bit big, because I want a clean passing commit in the `main` branch. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1823352380 | |
https://github.com/simonw/datasette/pull/2118#issuecomment-1668786770 | https://api.github.com/repos/simonw/datasette/issues/2118 | 1668786770 | IC_kwDOBm6k_c5jd6pS | 9599 | 2023-08-08T01:42:55Z | 2023-08-08T01:42:55Z | OWNER | > UPDATE: Fixed the `_size=max` bit, but I've not replicated the behaviour where it adds `?_labels=on` if there are expandable columns yet. It looks like that behaviour is only relevant to table views, and it's already implemented - https://latest.datasette.io/fixtures/roadside_attraction_characteristics links to https://latest.datasette.io/fixtures/roadside_attraction_characteristics.csv?_labels=on&_size=max | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1823352380 | |
https://github.com/simonw/datasette/pull/2118#issuecomment-1668715803 | https://api.github.com/repos/simonw/datasette/issues/2118 | 1668715803 | IC_kwDOBm6k_c5jdpUb | 9599 | 2023-08-07T23:50:26Z | 2023-08-08T01:41:53Z | OWNER | This bit needs some more work: https://github.com/simonw/datasette/blob/a791115e31e64e9bbd1d36f4d46887b3e42e752a/datasette/views/database.py#L514-L518 The original logic for that is from here, I need to figure out how to replicate it: https://github.com/simonw/datasette/blob/5139c0886a7f6bb94d317ba0665aa6e728716028/datasette/views/base.py#L368 https://github.com/simonw/datasette/blob/5139c0886a7f6bb94d317ba0665aa6e728716028/datasette/views/base.py#L342-L344 UPDATE: Fixed the `_size=max` bit, but I've not replicated the behaviour where it adds `?_labels=on` if there are expandable columns yet. | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1823352380 | |
https://github.com/simonw/datasette/pull/2118#issuecomment-1668781558 | https://api.github.com/repos/simonw/datasette/issues/2118 | 1668781558 | IC_kwDOBm6k_c5jd5X2 | 9599 | 2023-08-08T01:34:42Z | 2023-08-08T01:34:42Z | OWNER | 3 failures left: ``` =================================================================== short test summary info ==================================================================== FAILED tests/test_html.py::test_query_json_csv_export_links - assert '<a href="/fixtures.csv?sql=select+1&_size=max">CSV</a>' in '<!DOCTYPE html>\n<html>\n<head>\n <title>fixtures: select 1</title>\n <link r... FAILED tests/test_api.py::test_cors[/fixtures.json?sql=select+blah-400] - KeyError: 'Access-Control-Allow-Origin' FAILED tests/test_table_api.py::test_max_returned_rows - KeyError: 'query' =============================================== 3 failed, 1309 passed, 2 skipped, 1 xfailed in 61.34s (0:01:01) ================================================ ``` | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
1823352380 |